Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Justin Sternberg
@jtsternberg
the biggest frustration with groups is the name/id attributes
PG Lewis
@pglewis
but I'd like to verify you're seeing that as well
Justin Sternberg
@jtsternberg
But I know @sc0ttkclark has talked about doing something more javascripty so we too many inputs
PG Lewis
@pglewis
I can send you my function.php if that helps
though if you're seeing something broken I haven't come across, I'd like to get a copy of that
Justin Sternberg
@jtsternberg
let me look again
PG Lewis
@pglewis
pretend I have a magic wand I can wave to fix loading and saving :)
Justin Sternberg
@jtsternberg
I merged my trunk in.. maybe that has something to do with it? (I doubt it)
want me to push mine?
PG Lewis
@pglewis
I don't think you can merge the trunk changes in directly
I would revert those and run off the branch as is
confuses the matter
I'll be working on merging those in myself today
I already have them in my trunk
we're testing the nested-fields-trunk branch btw
Justin Sternberg
@jtsternberg
I can and did. :D there's not that much actually (and I just removed the stuff I added yesterday around auto-field creation)
only changes are JS
PG Lewis
@pglewis
changes to add_field in CMB2, n'est pas?
that's not even in CMB2 in my branch
that's in CMB2_Field_Group now
if the merge put that in CMB2 it's going to override the one I'm using
Justin Sternberg
@jtsternberg
yah, when I merged, I remove those changes completely
PG Lewis
@pglewis
and breakage ensues
Justin Sternberg
@jtsternberg
don't believe me? check out my branch compared to yours. https://github.com/WebDevStudios/CMB2/tree/feature/nested-fields-trunk
PG Lewis
@pglewis
to cut down on variable here, though... since I'm seeing the group fields displaying and you're not
Justin Sternberg
@jtsternberg
sure, will use your branch
PG Lewis
@pglewis
I would like you to test the code that's in our branch just to make sure
btw, saving for fields that aren't in a group fields should work fine
like in the user mb or options mb from the snippet lib
that's my enhanced version of the example functions, plus options
PG Lewis
@pglewis
the special "about page" metabox shows, pretty much everything appears to be functioning
there are other things I need to do once it's passing tests and save/load and remaining refactor details are worked out
since we're instantiating fields immediately now, I need to create a test metabox with 250 fields
I need to know any performance impact when abused
Justin Sternberg
@jtsternberg
sorry, caught up in work stuff again
PG Lewis
@pglewis
np, I type fast and can be a nasty chat-bomber :o
Justin Sternberg
@jtsternberg
it's no problem, as long as you're cool w/ me floating in/out of here
PG Lewis
@pglewis
I'm pretty much around until I crash tonight, you're getting concentrated-PG this week
it's important to me to evaluate the full viability of this because it needs to move forward in some fashion before Pods 3 can move forward
and also, if I talk you into this much, my next target is a Fields refactor I'm probably going to have a tough time getting through congress :)
I would like to rid it of the $args array like CMB2 ditched meta_box
Justin Sternberg
@jtsternberg
oof
PG Lewis
@pglewis
again, they're all field properties and the extra layer to get to them doesn't make much sense to me, but moreover, it's becoming the bottle-neck I'm hitting at the final bit of clean up vs tests
but one punch to the gut at a time, I'll let you see what you think of where we've landed thus far
Justin Sternberg
@jtsternberg
ha ha fair enough
PG Lewis
@pglewis
the bottom line is, despite the litter of the getters/setters, I think the API does everything it needs to that way while insulating the details completely now
assuming we deprecated prop() and __get and hopped in a time-machine to when those got removed completely, the CMB2 class is getting fairly tight in that regard, I think
most of the "looks a little messy" stuff left is for back compat I think
I came from a VB6 world in another life