Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Scott Kingsley Clark
@sc0ttkclark
where's your code to enqueue?
oh i see now
Ronald Huereca
@ronalfy
it's in bootstrap. I had to run it at a low priority
to get customizer to work properly
I'm going to work on the multi-check tools. But have at it. The timer just doesn't appear.
Ronald Huereca
@ronalfy
Yeah, that's what I used
the scripts are all in there properly
Just nothing displays.
Scott Kingsley Clark
@sc0ttkclark
hmm, so script loads to page, but you can't get it to actually work on the time field itself?
Ronald Huereca
@ronalfy
yah if I load the scripts on the front
I'm honestly going to do a pull request after I this multicheck to work and I can shelve the time pieces for later.
Ronald Huereca
@ronalfy
@sc0ttkclark here ya go WebDevStudios/CMB2#468
if you look at CMB-Customizer, it has all the required and mapping needed
Scott Kingsley Clark
@sc0ttkclark
can we pull our the bootstrap stuff into the area before we run the action you're hooking into there?
pull out*
i'll go through the code and do format cleanup and general review too
Ronald Huereca
@ronalfy
No, the bootstrap needs to be there or it needs to happen early
Scott Kingsley Clark
@sc0ttkclark
why call add_action( 'cmb2_init', 'cmb2_customizer_init', 1, 1 ); when you could put the code ahead of running cmb2_init itself in CMB2
Ronald Huereca
@ronalfy
ugh, didn't know that was an option
Do you mind just plowing through those. I am totally brain-spent.
I say either reject the pull request and continue working on mine, or merge into customizer branch and we can continue working on it there.
Scott Kingsley Clark
@sc0ttkclark
don't need to reject the PR, can be modified and PR automatically updates
Scott Kingsley Clark
@sc0ttkclark
@ronalfy to verify, you're done with the customizer integration -- excluding repeatable / group field functionality right? i can go through and tweak formatting, put the bootstrap loading before cmb2_init, etc?
Ronald Huereca
@ronalfy
@sc0ttkclark yes. I think I commented out which fields I was unable to do
@sc0ttkclark yeah, I did it in the pull request
Can't get to work: text_time, select_timezone, text_date_timestamp, text_datetime_timestamp, text_datetime_timestamp_timezone , hidden, wysiwyg
Sample code is in readme.md
Scott Kingsley Clark
@sc0ttkclark
ok cool
Ronald Huereca
@ronalfy
I swore I did it somewhere lol
@sc0ttkclark you are def welcome to school me.
I can probably get WYSIWYG, but not sure the editor is the place for that
customizer .. whatever
but everything should be in my readme.md
@sc0ttkclark I'm not the lead, but I think we can sneak in customizer as a beta feature and improve as needed.
Scott Kingsley Clark
@sc0ttkclark
yeah, once i get done with my part, i think we'll be in a place we can get people to help test and figure out the remaining non-repeatable/group field types
Ronald Huereca
@ronalfy
Cool. My brain is officially fried. I'm sure you can imaghine.
Scott Kingsley Clark
@sc0ttkclark
lol yep
Ronald Huereca
@ronalfy
I keep thinking to the Kill Bill line: you didn't think it would be that easy, did you?
"Ya know, for a second there, I kinda did."
Logging off. You gents have a good weekend. @sc0ttkclark if you need me, @ me because I get these cool notification emails :D
Ronald Huereca
@ronalfy
@sc0ttkclark @jtsternberg ping me today if you want to talk CMB2.
Scott Kingsley Clark
@sc0ttkclark
i didn't have time this weekend to go fixin up format, will do this morning
Scott Kingsley Clark
@sc0ttkclark
some commits about to come in
Scott Kingsley Clark
@sc0ttkclark
taking a little longer, found some more areas to improve
@jtsternberg 'options' in the field args, is that always a list of choices?
wysiwyg seems to use it as extra args to send to wp_editor(), but just making sure the norm is for choices
Ronald Huereca
@ronalfy
@sc0ttkclark are you working on my branch because then I should pull the pull request?
Scott Kingsley Clark
@sc0ttkclark
i'm on your branch