Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 20 15:02
    SvenAlHamad closed #669
  • Jan 20 15:02
    SvenAlHamad commented #669
  • Jan 20 15:01
    SvenAlHamad unlabeled #669
  • Jan 20 14:59
    SvenAlHamad commented #667
  • Jan 20 14:57
    SvenAlHamad labeled #667
  • Jan 20 14:57
    SvenAlHamad labeled #667
  • Jan 20 14:47
    SvenAlHamad labeled #666
  • Jan 20 14:46
    SvenAlHamad commented #668
  • Jan 20 14:46
    SvenAlHamad labeled #669
  • Jan 20 14:46
    SvenAlHamad labeled #669
  • Jan 20 14:45
    SvenAlHamad commented #669
  • Jan 20 14:43
    SvenAlHamad commented #665
  • Jan 20 14:35
    SvenAlHamad commented #666
  • Jan 20 09:46
    Pavel910 assigned #669
  • Jan 20 09:46
    rpalmite opened #669
  • Jan 20 09:34
    Pavel910 labeled #668
  • Jan 20 09:33
    Pavel910 commented #668
  • Jan 20 09:28
    Pavel910 commented #667
  • Jan 20 09:28
    rpalmite opened #668
  • Jan 20 09:26
    Pavel910 commented #666
Pavel Denisjuk
@Pavel910
not sure what you mean?
ramin
@rmros
sorry
webiny app builder is working on non-render assets or pre-render assets?
pre-render is when we compiled react assets to static site for cdn
Pavel Denisjuk
@Pavel910
ah I see, ok so: our Page Builder is not like Gatsby, where you pre-render static HTML and upload to S3.
It is created for dynamic content, so we use server-side-render. When you publish a page, we trigger a server-side-render to populate the cache.
When a user visits a URL, the cache is loaded from DB and stored into CDN. All the other visitors load content directly from CDN.
So you don't need to rebuild and redeploy your site when you make changes via Page Builder.
ramin
@rmros
wow, complete answer , why we no create server-side-render serverless function to convert those contents to static and then inject to cdn ?
Pavel Denisjuk
@Pavel910
Unfortunately CloudFront does not have a way to insert cache content; it can only cache the content that was returned after a request was processed.
so we can't avoid that first page visit, but loading data from DB once is no big deal.
ramin
@rmros
understand so its not big deal its just one first time,
Pavel Denisjuk
@Pavel910
yes. and the page content comes from DB so you don't have to wait for the entire SSR, just a single DB query.
ramin
@rmros
im trying to add some extra features in webiny , for now im working to find a way lets other ui frameworks use webiny not just react
i understand webiny page builder is using slatejs as core
Pavel Denisjuk
@Pavel910
You can build the whole UI from scrath using Vue or Angular, and only use our API, but then you lose a lot of features we already have and will launch in the future.
actually no, Slate is only used for text areas.
The whole editor is our own "framework", and Slate is just used to add the RichText editing.
ramin
@rmros
aha , yes, i just started to learn how you develope webiny , i hope add some features or plugins later
ramin
@rmros
in your seem is a way to i research about agnostic ui framework webiny based?
Pavel Denisjuk
@Pavel910
I don't think you'll be able to recreate all the existing apps in another framework in a short time.
We only work in React, and have no experience in other frameworks so unfortunately we cannot give you any useful advices.
Our API is GraphQL, so in theory you would be able to use that and build all the apps in Angular (for example), but that's a lot of work.
It would not be compatible with our existing UI system.
ramin
@rmros
yes you right, pavel thanks a lot ,
Adrian Smijulj
@doitadrian

Hi @qtlaw_gitlab @rpalmite_gitlab!

Just wanted to inform you that the issue was fixed, I just deployed everything from scratch, and it worked as expected.
In short, we had a problem with package versions… because of the way how NPM handles 0.*.* versioned packages, when creating a new project, older versions of commodo package were pulled, and that caused the issue you were having.

If you want to give Webiny another try, in your existing project, just run yarn upgrade @webiny and that should update all of the Webiny NPM packages. To be sure everything is as it should be, please just open the node_modules/@commodo/ folders, and check package.json in each one (there are 6 or 7 of them), the version of each package should be 1.0.0 or greater. If so, just hit webiny deploy-api to redeploy the API, and you should be good to go.

The alternative is to remove everything that was deployed, by executing the webiny remove-api and webiny remove-apps, deleting the project you created, and just creating a new one from scratch, by running the webiny create my-project command as you already did before.

Adrian Smijulj
@doitadrian
BTW we have plans to set up CI soon, so we don’t have to experience these kind of issues again.
The whole system will be much stable once we do that, and it will help us move forward much easier.
piekarski
@piekarski
admin app is working for me but when I try yarn start on the site app the browser displays the message "An error occurred." after displaying a brief "loading locales" spinner
Pavel Denisjuk
@Pavel910
You can try investigating by looking at CloudWatch logs for site and ssr lambdas
Just a note here; what you see now is kind of an "old" SSR mechanism which is buggy; we're wrapping our next release as we speak, which is focused on a much better SSR and site delivery.
piekarski
@piekarski
sweet can't wait!
piekarski
@piekarski
Is there any documentation on how I can add an existing react/serverless app mainly so that I can take advantage of ssr functionality
Pavel Denisjuk
@Pavel910

Unfortunately not yet :(

But whatever apps we have available are already included in the default setup.
An app is just a collection of plugins, and all of them are included in apps/site/plugins/index.js

piekarski
@piekarski
hi getting the following errors loading deployed site from browser:
from the ssr service:2020-01-20T22:10:05.348Z d019c63e-b343-45a3-8dab-47ca97bac4f9 ERROR Invoke Error
{
"errorType": "Error",
"errorMessage": "GraphQL error: PbPage.findByIds is not a function\nGraphQL error: PbPage.findByIds is not a function\nGraphQL error: PbPage.findByIds is not a function",
"graphQLErrors": [
{
"message": "PbPage.findByIds is not a function",
"path": [
"pageBuilder",
"notFoundPage"
],
"extensions": {
"code": "INTERNAL_SERVER_ERROR",
"serviceName": "pageBuilder",
"query": "{\n pageBuilder {\n page: getHomePage {\n data {\n id\n title\n url\n version\n publishedOn\n snippet\n content\n createdBy {\n typename\n id\n }\n settings {\n _empty\n general {\n image {\n typename\n id\n }\n tags\n layout\n typename\n }\n seo {\n title\n description\n meta {\n name\n content\n typename\n }\n typename\n }\n social {\n image {\n typename\n id\n }\n title\n description\n meta {\n property\n content\n typename\n }\n typename\n }\n typename\n }\n category {\n id\n name\n typename\n }\n typename\n }\n error {\n code\n message\n typename\n }\n typename\n }\n errorPage: getErrorPage {\n data {\n id\n title\n url\n version\n publishedOn\n snippet\n content\n createdBy {\n typename\n id\n }\n settings {\n _empty\n general {\n image {\n typename\n id\n }\n tags\n layout\n typename\n }\n seo {\n title\n description\n meta {\n name\n content\n typename\n }\n typename\n }\n social {\n image {\n typename\n id\n }\n title\n description\n meta {\n property\n content\n typename\n }\n typename\n }\n typename\n }\n category {\n id\n name\n typename\n }\n typename\n }\n error {\n code\n message\n typename\n }\n typename\n }\n notFoundPage: getNotFoundPage {\n data {\n id\n title\n url\n version\n publishedOn\n snippet\n content\n createdBy {\n typename\n id\n }\n settings {\n _empty\n general {\n image {\n typename\n id\n }\n tags\n layout\n typename\n }\n seo {\n title\n description\n meta {\n name\n content\n typename\n }\n typename\n }\n social {\n image {\n typename\n id\n }\n title\n description\n meta {\n property\n content\n typename\n }\n typename\n }\n typename\n }\n category {\n id\n name\n typename\n }\n __typename\n }\n
from site app: {
"errorType": "TypeError [ERR_INVALID_ARG_TYPE]",
"errorMessage": "The \"buffer\" argument must be one of type string, Buffer, TypedArray, DataView, or ArrayBuffer. Received type undefined",
"code": "ERR_INVALID_ARG_TYPE",
"stack": [
"TypeError [ERR_INVALID_ARG_TYPE]: The \"buffer\" argument must be one of type string, Buffer, TypedArray, DataView, or ArrayBuffer. Received type undefined",
" at zlibBufferSync (zlib.js:143:13)",
" at Object.syncBufferWrapper [as gzipSync] (zlib.js:733:14)",
" at Runtime../handler/handler.js.module.exports.handler (/var/task/handler.js:21192:29)",
" at process._tickCallback (internal/process/next_tick.js:68:7)"
]
Quinn Lawrence
@qtlaw_gitlab
I am having the same issue... Anyone have any ideas?
Adrian Smijulj
@doitadrian

Thank you guys for the reports and I’m sorry you had to experience this.
The issue is unfortunately related to the recent changes in the commodo library.

But we are planning to do a larger release tomorrow/Thursday, and with it, everything will work as expected I assure you.
I will update you both as soon as this is resolved!

Pavel Denisjuk
@Pavel910
The next release will be worth the wait; we've greatly improved things on many fronts: SSR, error reporting, Typescript, so hang on just a little bit longer :)
Quinn Lawrence
@qtlaw_gitlab
Awesome, cant wait! I am doing a small POC presentation on Wednesday though and wanted to show Webiny up and running... If I pull back a previous version of @webiny/cli can I generate a new project that will work or will I have the same issues?
Adrian Smijulj
@doitadrian
let me check
Adrian Smijulj
@doitadrian
I’m actually trying to see what would be needed in order for the current version to work properly, almost there :)
Adrian Smijulj
@doitadrian
I will publish a fix so you’ll just run yarn upgrade @commodo and it should work
sec
Adrian Smijulj
@doitadrian
please run the yarn upgrade @commodo command in your project, that should pull the latest fix I just released, after that, it would be best to redeploy the API completely, with webiny deploy-api
I’ll be here if you’ll need me
@qtlaw_gitlab @piekarski
Quinn Lawrence
@qtlaw_gitlab
Awesome! I'll give it a shot
Eric Hemmerlin
@ehemmerlin
Hello, thanks for the good work you are doing on Webiny. I would like to upgrade an installed project to its latest version. Will "yarn upgrade" inside the project do the trick ?
Adrian Smijulj
@doitadrian
Not sure, depends on the version you’re currently at really, but if possible, I would wait for the newest release we’re about to do in these this week, because this relaese will introduce a lot of new, cool, and unfortunately, breaking changes
Eric Hemmerlin
@ehemmerlin
Ok I'll wait, thanks Adrian
Adrian Smijulj
@doitadrian
No problem @ehemmerlin