Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 17 07:27

    delete-merged-branch[bot] on GitHubSync-20190917-072643

    (compare)

  • Sep 17 07:27

    GeertvanHorrik on develop

    GitHubSync update Merge pull request #94 from Wil… (compare)

  • Sep 17 07:27
    GeertvanHorrik closed #94
  • Sep 17 07:26
    GeertvanHorrik opened #94
  • Sep 17 07:26

    GeertvanHorrik on GitHubSync-20190917-072643

    GitHubSync update (compare)

  • Sep 02 00:48
    lock[bot] locked #92
  • Sep 02 00:48
    lock[bot] commented #92
  • Sep 02 00:48
    lock[bot] locked #93
  • Sep 02 00:48
    lock[bot] commented #93
  • Aug 31 19:48
    lock[bot] locked #91
  • Aug 31 19:48
    lock[bot] commented #91
  • Aug 30 18:48
    lock[bot] locked #90
  • Aug 30 18:48
    lock[bot] commented #90
  • Aug 29 00:13

    dependabot-preview[bot] on nuget

    (compare)

  • Aug 29 00:13

    dependabot-preview[bot] on develop

    Bump LoadAssembliesOnStartup.Fo… Merge pull request #93 from Wil… (compare)

  • Aug 29 00:13
    dependabot-preview[bot] closed #93
  • Aug 29 00:12

    dependabot-preview[bot] on nuget

    (compare)

  • Aug 29 00:12

    dependabot-preview[bot] on develop

    Bump Catel.Fody from 4.1.0 to 4… Merge pull request #92 from Wil… (compare)

  • Aug 29 00:12
    dependabot-preview[bot] closed #92
  • Aug 29 00:12
    dependabot-preview[bot] labeled #93
Geert van Horrik
@GeertvanHorrik
we have a separate statusbar that simply watches this service as well and toggle visibility on an icon
samirem
@samirem
@GeertvanHorrik at first startup after installation my app gets a CrashWarningWindow, do you know why this could be?
Geert van Horrik
@GeertvanHorrik
This is something from Orchestra, happens if the app hasn't been started corretly previously
samirem
@samirem
yeah, but if the user does a fresh installation, the first startup of the application gives this window
Geert van Horrik
@GeertvanHorrik
that's not good. Do you initialize the %appdata% based on existing data?
this windows is being shown when %appdata%\company\product\started_failed.txt exists
samirem
@samirem
hm, that catalogue should not exist prior to installation, and I'm only adding the "standard" squirrel files/catalogues during installation
Geert van Horrik
@GeertvanHorrik
if you run the app twice, it could be instance 1 still starting up
and the 2nd instance showing this window
but I have no details about logging, et
samirem
@samirem
yeah maybe
as far as I know, at the end of squirrel installation the app is started
and then in my application I run the "SquirrelHelper.HandleSquirrelAutomatically();" to check if the app was just installed
that shows the window from Orc.Squirrel.Xaml, with a "run" button to run the app
Geert van Horrik
@GeertvanHorrik
that all looks good
samirem
@samirem
and when my user press this button, then the problem occurs
Geert van Horrik
@GeertvanHorrik
what you can do is enable debug logging for your app
in app config, add this
  <configSections>
    <sectionGroup name="catel">
      <section name="logging" type="Catel.Logging.LoggingConfigurationSection, Catel.Core" />
    </sectionGroup>
  </configSections>

  <catel>
    <logging>
      <listeners>
        <!--TODO: the line below must be commented out in stable release-->
        <!--<listener type="Catel.Logging.FileLogListener" IgnoreCatelLogging="true" IsDebugEnabled="true" IsInfoEnabled="true" IsWarningEnabled="true" IsErrorEnabled="true" />-->
      </listeners>
    </logging>
  </catel>
then you can easily uncomment the line when you want debug logging in production
samirem
@samirem
What should I look for in the log file? (i.e., what namespace produces the startupfailed.txt file?)
Geert van Horrik
@GeertvanHorrik
something in orchestra, not 100 % sure
samirem
@samirem
16:52:08:757 => [DEBUG] [Orchestra.Services.EnsureStartupService] [1] Creating fail safe file check
16:52:08:758 => [DEBUG] [Orc.FileSystem.FileService] [1] Creating file 'C:\Users\SESAEM\AppData\Roaming\Construction Software\Continuous Beam\startupfailed.txt'
nothing strange before this
oh wait a second, it seems like my second app starts before my first app has closed, like you pointed out
samirem
@samirem
my app is doing a lot of startup stuff even after this line:
16:52:05:939 => [INFO] [Orc.Squirrel.SquirrelHelper] [1] Closing application
Should it not break the startup process here and shut down asap?
Geert van Horrik
@GeertvanHorrik
your app should shut down, but not sure if it's something that's done automatically or whether you should be doing that
it's something we embed in our apps by default, so a long time ago when we wrote this
samirem
@samirem

@GeertvanHorrik
It seems that the "IsUpdatedInstalled" is never set to true, even if the application was updated.
https://github.com/WildGums/Orc.Squirrel/blob/develop/src/Orc.Squirrel/Orc.Squirrel.Shared/Services/UpdateService.cs#L210

In my observations, the exit code is always 0, even if the application was successfully updated.

Geert van Horrik
@GeertvanHorrik
Correct, we use a custom build of Squirrel with exit codes that make sense
samirem
@samirem
Oh cool, is this available for me to use as well?
Geert van Horrik
@GeertvanHorrik
if you want, yes
but I didn't have a lot of time to keep it up-to-date to be honest, so it's a bit outdated, but works great for us
I tried several times to PR these features but Paul doesn't seem really open to these ideas
samirem
@samirem
That's a shame.. For me it is necessary to get some feedback if application was updated or not, does he prefer another method of doing this? I saw something about standardoutput
Thanks for the fork, I think it will work great for me as well even if it's not up-to-date
Do you think it's an alternative to update the Orc.Squirrel library to use "his" method instead of exit codes?
Geert van Horrik
@GeertvanHorrik
I don't know what his exit codes are, at the time I wrote all of this, there were no exit codes
and since we have to maintain 60+ libs, we have to prioritize, so never bothered looking into this again (since it works fine for us)
samirem
@samirem
I totally get it, "if it ain't broken, why fix it?" ;)
But would it be of interest if I did a PR on this? I could investigate how the "official" squirrel way to do this would be, and try to implement it in Orc.Squirrel
Geert van Horrik
@GeertvanHorrik
definitely, we would be open to that :)
samirem
@samirem
Cool, I'll let you know if I need some guidance. I hope that I can find some time for this soon
Geert van Horrik
@GeertvanHorrik
My tip: first create a ticket and discuss it on the squirrel repo before doing anything
samirem
@samirem
Thanks for the tip, that sounds like a good way to start
samirem
@samirem
@GeertvanHorrik You told me earlier that you show a statusbar icon after the app has been updated. How do you show it? Some Orc.XX-package, or code you can't share?
Geert van Horrik
@GeertvanHorrik
I think LogViewer (app) also does something like this
it shows how we use it in our internal apps as well