These are chat archives for WildGums/Orc.Squirrel

13th
Jul 2017
samirem
@samirem
Jul 13 2017 09:01

@GeertvanHorrik
It seems that the "IsUpdatedInstalled" is never set to true, even if the application was updated.
https://github.com/WildGums/Orc.Squirrel/blob/develop/src/Orc.Squirrel/Orc.Squirrel.Shared/Services/UpdateService.cs#L210

In my observations, the exit code is always 0, even if the application was successfully updated.

Geert van Horrik
@GeertvanHorrik
Jul 13 2017 09:26
Correct, we use a custom build of Squirrel with exit codes that make sense
samirem
@samirem
Jul 13 2017 09:26
Oh cool, is this available for me to use as well?
Geert van Horrik
@GeertvanHorrik
Jul 13 2017 09:28
if you want, yes
but I didn't have a lot of time to keep it up-to-date to be honest, so it's a bit outdated, but works great for us
I tried several times to PR these features but Paul doesn't seem really open to these ideas
samirem
@samirem
Jul 13 2017 09:30
That's a shame.. For me it is necessary to get some feedback if application was updated or not, does he prefer another method of doing this? I saw something about standardoutput
Thanks for the fork, I think it will work great for me as well even if it's not up-to-date
Do you think it's an alternative to update the Orc.Squirrel library to use "his" method instead of exit codes?
Geert van Horrik
@GeertvanHorrik
Jul 13 2017 09:32
I don't know what his exit codes are, at the time I wrote all of this, there were no exit codes
and since we have to maintain 60+ libs, we have to prioritize, so never bothered looking into this again (since it works fine for us)
samirem
@samirem
Jul 13 2017 09:33
I totally get it, "if it ain't broken, why fix it?" ;)
But would it be of interest if I did a PR on this? I could investigate how the "official" squirrel way to do this would be, and try to implement it in Orc.Squirrel
Geert van Horrik
@GeertvanHorrik
Jul 13 2017 09:34
definitely, we would be open to that :)
samirem
@samirem
Jul 13 2017 09:36
Cool, I'll let you know if I need some guidance. I hope that I can find some time for this soon
Geert van Horrik
@GeertvanHorrik
Jul 13 2017 09:37
My tip: first create a ticket and discuss it on the squirrel repo before doing anything
samirem
@samirem
Jul 13 2017 09:38
Thanks for the tip, that sounds like a good way to start