Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 10:31

    delete-merged-branch[bot] on GitHubSync-20190820-103111

    (compare)

  • 10:31

    GeertvanHorrik on develop

    GitHubSync update Merge pull request #81 from Wil… (compare)

  • 10:31
    GeertvanHorrik closed #81
  • 10:31
    GeertvanHorrik opened #81
  • 10:31

    GeertvanHorrik on GitHubSync-20190820-103111

    GitHubSync update (compare)

  • Aug 19 00:13

    dependabot-preview[bot] on nuget

    (compare)

  • Aug 19 00:13

    dependabot-preview[bot] on develop

    Bump Fody from 5.1.1 to 5.2.0 … Merge pull request #80 from Wil… (compare)

  • Aug 19 00:13
    dependabot-preview[bot] closed #80
  • Aug 19 00:12
    dependabot-preview[bot] labeled #80
  • Aug 19 00:12
    dependabot-preview[bot] opened #80
  • Aug 19 00:11

    dependabot-preview[bot] on nuget

    Bump Fody from 5.1.1 to 5.2.0 … (compare)

  • Aug 14 12:56

    delete-merged-branch[bot] on GitHubSync-20190814-125550

    (compare)

  • Aug 14 12:56

    GeertvanHorrik on develop

    GitHubSync update Merge pull request #79 from Wil… (compare)

  • Aug 14 12:56
    GeertvanHorrik closed #79
  • Aug 14 12:56
    GeertvanHorrik opened #79
  • Aug 14 12:56

    GeertvanHorrik on GitHubSync-20190814-125550

    GitHubSync update (compare)

  • Aug 14 10:24

    delete-merged-branch[bot] on GitHubSync-20190814-102420

    (compare)

  • Aug 14 10:24

    GeertvanHorrik on develop

    GitHubSync update Merge pull request #78 from Wil… (compare)

  • Aug 14 10:24
    GeertvanHorrik closed #78
  • Aug 14 10:24
    GeertvanHorrik opened #78
samirem
@samirem
nothing strange before this
oh wait a second, it seems like my second app starts before my first app has closed, like you pointed out
samirem
@samirem
my app is doing a lot of startup stuff even after this line:
16:52:05:939 => [INFO] [Orc.Squirrel.SquirrelHelper] [1] Closing application
Should it not break the startup process here and shut down asap?
Geert van Horrik
@GeertvanHorrik
your app should shut down, but not sure if it's something that's done automatically or whether you should be doing that
it's something we embed in our apps by default, so a long time ago when we wrote this
samirem
@samirem

@GeertvanHorrik
It seems that the "IsUpdatedInstalled" is never set to true, even if the application was updated.
https://github.com/WildGums/Orc.Squirrel/blob/develop/src/Orc.Squirrel/Orc.Squirrel.Shared/Services/UpdateService.cs#L210

In my observations, the exit code is always 0, even if the application was successfully updated.

Geert van Horrik
@GeertvanHorrik
Correct, we use a custom build of Squirrel with exit codes that make sense
samirem
@samirem
Oh cool, is this available for me to use as well?
Geert van Horrik
@GeertvanHorrik
if you want, yes
but I didn't have a lot of time to keep it up-to-date to be honest, so it's a bit outdated, but works great for us
I tried several times to PR these features but Paul doesn't seem really open to these ideas
samirem
@samirem
That's a shame.. For me it is necessary to get some feedback if application was updated or not, does he prefer another method of doing this? I saw something about standardoutput
Thanks for the fork, I think it will work great for me as well even if it's not up-to-date
Do you think it's an alternative to update the Orc.Squirrel library to use "his" method instead of exit codes?
Geert van Horrik
@GeertvanHorrik
I don't know what his exit codes are, at the time I wrote all of this, there were no exit codes
and since we have to maintain 60+ libs, we have to prioritize, so never bothered looking into this again (since it works fine for us)
samirem
@samirem
I totally get it, "if it ain't broken, why fix it?" ;)
But would it be of interest if I did a PR on this? I could investigate how the "official" squirrel way to do this would be, and try to implement it in Orc.Squirrel
Geert van Horrik
@GeertvanHorrik
definitely, we would be open to that :)
samirem
@samirem
Cool, I'll let you know if I need some guidance. I hope that I can find some time for this soon
Geert van Horrik
@GeertvanHorrik
My tip: first create a ticket and discuss it on the squirrel repo before doing anything
samirem
@samirem
Thanks for the tip, that sounds like a good way to start
samirem
@samirem
@GeertvanHorrik You told me earlier that you show a statusbar icon after the app has been updated. How do you show it? Some Orc.XX-package, or code you can't share?
Geert van Horrik
@GeertvanHorrik
I think LogViewer (app) also does something like this
it shows how we use it in our internal apps as well