@Miaourt Yjs is meant to be a "CRDT for all the things". Though I still plan to implement some features that will make certain things easier.
I don't know how large large in your context is. But if your document grows behind a certain threshold you could organize your bullets using subdocuments. https://docs.yjs.dev/api/subdocuments This would allow you to load bullets asynchronously / on-demand. But Yjs handles very large documents as outlined here: https://blog.kevinjahns.de/are-crdts-suitable-for-shared-editing/
i am also getting the following error in console
- Uncaught (in promise) TypeError: decoder.arr is undefined decoding.js:239
- WebRTC: ICE failed, add a TURN server and see about:webrtc for more details
on a new peer i get the following error in console as well
- Uncaught TypeError: user is undefined yjs.mjs:1941
Hi @nandit123 ,
Are you using y-indexeddb for offline editing? https://docs.yjs.dev/getting-started/allowing-offline-editing
I maintain several signaling servers with very low specs that your clients use to find each other. These servers are located in Europe, and the US. It probably takes a bit longer for peers to find each other if they are not in a region with a signaling server. You could set up a a custom signaling server to speed up the signaling process. https://github.com/yjs/y-webrtc/#signaling
• Uncaught TypeError: user is undefined yjs.mjs:1941
• Uncaught (in promise) TypeError: decoder.arr is undefined decoding.js:239
Could you please report an issue with steps to reproduce in https://github.com/yjs/y-webrtc/issues ?
WebRTC: ICE failed, add a TURN server and see about:webrtc for more details
It seems you are behind a proxy. WebRTC requires you to be able to connect to other peers directly. This is like BitTorrent (remember when we explicitly needed to forward ports on the router?). The Webrtc spec defines several methods to connect to other peers (without explicitly forwarding ports). The gold standard is to use Triple ICE (basically trying out every possible connection method until something works; which is implemented by simple-peer, the webrtc package that Yjs uses). In the case that no method works (which apparently is the case in your scenario) then the client tries to connect through a TURN server (imagine a dumb server simply forwarding messages). I don't maintain TURN servers because that would be too expensive. You can add your own TURN server or purchase access to TURN servers.
The ClientID is used for conflict resolution. So it is important that you understand all the side-effects of retaining a ClientID across sessions. The simple answer is: Yjs is designed to create a new ClientID for every session to avoid sync conflicts. The recommended method to identify users is using the Awareness feature. If you still want to retain a ClientID, you can do so by simply overwriting the ydoc.clientID property. But you must ensure that no other Y.Doc instance is currently holding that ClientID. This is not always possible: A user might open several browser-windows with the same user-account. When two Y.Doc instances with the same ClientID exist, the document might get permanently corrupted without a way to recover. So do this with caution.
I'm trying out the awareness protocol, and either misunderstanding what is supposed to happen, or making a silly mistake with the code. I have two clients, each running the following (this is a slightly simplified version):
import * as Y from 'yjs';
import { WebsocketProvider } from 'y-websocket';
import * as awareness from 'y-protocols/awareness.js';
const doc = new Y.Doc();
const wsProvider = new WebsocketProvider('wss://cress.soc.surrey.ac.uk/wss', 'prsm', doc);
yAwareness = new awareness.Awareness(doc);
yAwareness.on('change', function () {
console.log(yAwareness.getStates());
});
yAwareness.setLocalState('test', newDate());What I see is that, when the setLocalState is executed on each client, the observer reports the change of state of the local client, but never reports the state of the other client (which is what I had understood is the point of the awareness protocol). I also have (not shown) Y.Map and Y.Array types shared between the two clients, and the sharing works as expected, so it is not that there is no communication between the clients, just not the awareness.
Hey @aslakhellesoy , you are right - it is not enabled by default. You could enable it by adding an undo-manager and hooking it to the keybindings. I'd also love to get a PR on it :) But probably going to add it in the next few weeks anyway. I have a new client who is using codemirror and there are some things that I want to iron out: e.g. better remote cursor rendering.
Hey @dmonad was just searching through gitter about undo/redo on yjs. Is this still in the pipeline for you? It looks like it's still commented out in y-codemirror
yAwareness = new awareness.Awareness(doc);it should have been:
yAwareness = wsProvider.awareness;With that change, and with providing an object to setLocalState, it now works. thx
3 replies
I'm currently not, and there is no timeline. My highest priority right now is to get the documentation finished which turned out to be a lot of work. I also maintain lots of other packages, all in my free time. So sorry, I can't do that right now. But you could hook up the undomanager yourself and test out if there are any issues. It currently doesn't handle restoring selections right now, which is something I'm planning to implement (when hitting undo, it should restore the selection before the change. This is useful, for example, when selecting some text , then deleting it, and then undoing that deletion - you expect that the selection is restored)
"aa" and then cntrl-z, cntrl-z -- it does the right thing.
But if i then try: cntrl-y, cntrl-y -- I only get "a" back
const e = 'a';
const element = new Y.Map();
console.log('setting text to', e);
element.set('text', new Y.Text(e));
console.log(element.get('text'));I also wanted you to this ticket: yjs/yjs#207 I haven't decided if I want to fix the described behavior. But it really seems inconsistent..