These are chat archives for abranson/rockpool

29th
Jul 2016
Andrew Branson
@abranson
Jul 29 2016 14:15
maybe.
but it was just if body is empty then use preview
or actually may have been the other way around
which is why it got dropped
still haven't managed to replicate the phone call hang
ruff
@rufferson
Jul 29 2016 14:16
on jolla-c?
Andrew Branson
@abranson
Jul 29 2016 14:16
yep
ruff
@rufferson
Jul 29 2016 14:16
so what are conditions to reproduce? just to receive a call?
Andrew Branson
@abranson
Jul 29 2016 14:16
and my jolla1 has been on 2.0.2+ for a while now too
and that didn't do it either
not that i get many phone calls, but i get some
someone said it was more likely to crash if the watch initiated the hangup
but we've had all sort of reports. all i know is that when a phone call ends, sometimes rockpoold grabs all the memory and either gets OOM killed or the whole phone dies
ruff
@rufferson
Jul 29 2016 14:17
and it was certainly reported for mainline and latest beta
Andrew Branson
@abranson
Jul 29 2016 14:18
i don't think anyone's reported it on the jolla1, but i can't see how it could be a hardware issue. maybe adaptation
though the jolla1 doesn't have the call recording option enabled
ruff
@rufferson
Jul 29 2016 14:18
what was the reason to use private class for call handler btw?
It's a bit obscure to me
Andrew Branson
@abranson
Jul 29 2016 14:18
came from libwatchfish
intention was to push that back to javispedro at some point
tbh the pebbled call handler was much simpler. only supported one call though
ruff
@rufferson
Jul 29 2016 14:19
ok, so maybe worth reworking - if not to fix then at least to understand what happens when :)
atm it's a bit cumbersome
I mean I have no idea how Qt controls life cycle of the private class, whether it's destructed before parent, who's set as a parent, all these kind of things. It's all driven by macros
of course i can just go to headers and reverse engineer that, but i see no reason to have that private class in the first place
Andrew Branson
@abranson
Jul 29 2016 14:32
agree
it's too complex for rockpool's needs
Andrew Branson
@abranson
Jul 29 2016 15:39
btw, successfully tested the canned sms today while driving. it's great! though i went to add a new canned response afterwards, and got a strange feeling one of my old ones had been removed. will try again next time i get an SMS
it's all telegram and whatsapp these days. hardly ever get call or smses.
ruff
@rufferson
Jul 29 2016 17:02
I'm using mostly google hangouts via builtin client (telepathy/gabber) so canned messages applies to it as well. If you can find a way to send whatsapp/telegram messages - we can implement it as well
and yes editing canned messages needs throughout testing, post implementation i did functional sanity tests and all looked ok, but after some time (after restart?) i noticed message layout is a bit weird - not those messages I expected to see
Andrew Branson
@abranson
Jul 29 2016 22:55
Have you tried Hangish? It works well, and supports group and offline messages. It used to show the hangouts icon on the pebble, but that seems to have reverted to the 'instant message' in a bottle.