Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Kevin Smith
    @ksmth
    you could put a var searchQuery, category; at the top of the file where fetchStrategies is defined
    then, whenever fetchStrategies is called, it puts the new values in those variables and only actually does something when it has both
    exophunk
    @exophunk
    @ksmth okay so I don't store the searchQuery & category in any state or store but just in a class var of the component who fires the action?
    Kevin Smith
    @ksmth
    no, not the component who fires the action
    where fetchStrategies is defined
    exophunk
    @exophunk
    ah , right, sorry. okay. I will try that, thank you! Isn't it weird for a Actions class to save some kind of state?
    Kevin Smith
    @ksmth
    hm, I don't know.
    Kevin Smith
    @ksmth
    tadjik1: sorry man, no idea. it's really the outer FluxComponent that's doing all the harm
    the weird thing is, I have also checked whether flux is defined and an instance of Flux … and it is
    Darío Javier Cravero
    @dariocravero
    @exophunk actions shouldn't hold any state at all
    Kevin Smith
    @ksmth
    dariocravero: if you subscribe to that logic, it'd be one action for both input change events. for the first change, you put that value into a store and that would then propagate back to the component. then on the second change you put that value together with the new value
    Sergey Zelenov
    @tadjik1
    @ksmth no prob, thanks a lot for help! I've checked it too, and have no idea whats wrong)
    @ksmth but when i resolve it - I'll tell you)
    Darío Javier Cravero
    @dariocravero
    hey guys, I've just pushed a react native compatible implementation of the component in #185 :) what're your thoughts about it?
    Darío Javier Cravero
    @dariocravero
    Just saw #181 and commented over there :)
    Josh Girvin
    @girvo
    Hey all
    Quick question: async actions — what’s the best way of handling errors?
    Jeffrey Morgan
    @jeffdm
    I had the same question^^
    Josh Girvin
    @girvo
    I figure it’s best to just hand it on to the store (which has a try-catch block as normal) — is that correct?
    Jeffrey Morgan
    @jeffdm
    hmm I'm stuck on this a bit in general with flux
    how do you easily show error state
    Josh Girvin
    @girvo
    Also, damned mocha and babel — trying to get the silly thing to let me do ‘let result = await api.getSomething()'
    Josh Girvin
    @girvo
    Got it, I missed the it(‘description of unit’, async () => { let whatever = await api.getSomething() }); async on the lambda
    ES7 async-await is so damned nice.
    Jeffrey Morgan
    @jeffdm
    ah
    how is it over all with the tooling?
    (babel etc)
    thinking of moving an entire app to async-await but not sure if it will just complicate things
    Josh Girvin
    @girvo
    Pretty great, some tiny little edge cases but they were more because of lacking documentation
    I’m building Expedia.com’s Viewfinder application in React and Flummox, ES6/ES7 all the way through. It’s pretty exciting!
    Jeffrey Morgan
    @jeffdm
    wow! cool!, on my side I'm moving github.com/kitematic/kitematic to flux
    trying to find a nice set of guidelines to build a scalable front end
    Josh Girvin
    @girvo
    Oh kitematic!!
    :D :D :D we <3 kitematic haha
    Though one of these days I’m going to help make it work nicer with docker-compose and local Dockerfiles ;)
    Jeffrey Morgan
    @jeffdm
    :)!!! good to hear!!
    what do you primarily use kitematic for?
    also - if you could only have one of {Dockerfile, docker-compose} which one would be more important?
    also, contributions always welcome :)
    just curious - plans for both! just wondering which is moore importabt
    Josh Girvin
    @girvo
    Dockerfiles would be more important for sure
    Jeffrey Morgan
    @jeffdm
    thx - by this do you mean building an image from a local Dockerfile?
    Josh Girvin
    @girvo
    Key part of our development workflow, as is docker-compose but we can do without that :) being able to build a local Dockerfile and run the image that is created would be amazing
    Jeffrey Morgan
    @jeffdm
    I see, good! thanks so much! does the Docker Hub auto build feature work for this?
    (in meantime)
    Darío Javier Cravero
    @dariocravero
    @jeffdm this is the result of a good while building on react + flux and iterating on its tooling to get the process as smooth as possible. It uses browserify, babel and mocha. It provides a playground for both: the browser and (now) iOS. Testing is done following this guidelines - I'll port that to flummox soon although it should be way simpler than marty.
    Seb Insua
    @sebinsua
    I am wondering what is the best way of writing isomorphic flummox apps that store authentication tokens within localStorage? Is there some kind of isomorphic library for interfacing with this, since obviously by default Node does not support it.
    Darío Javier Cravero
    @dariocravero
    @sebinsua would that help? https://www.npmjs.com/package/localstorage-down
    Seb Insua
    @sebinsua
    I guess it would, I just want to make sure that I am not doing something crazy and other people do similar things.
    Sergey Zelenov
    @tadjik1

    hey guys.
    I have a problem with server-side rendering app with flummox.
    this is the code - https://github.com/tadjik1/soundcloud-player

    and this is the problem: acdlite/flummox#186

    maybe someone met it?