Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 11:24
    jamesrea83 opened #2655
  • 11:23

    jamesrea83 on 1912

    #1912 expose _isResetOnRevisit … (compare)

  • 10:31

    oliverfoster on 2647-2

    Fixed merge errors (compare)

  • 10:31
    oliverfoster synchronize #2652
  • 10:28
    oliverfoster synchronize #2652
  • 10:28

    oliverfoster on 2647-2

    Switched to single quotes fixes issue/2642 adds package-l… Resolves #2377, adds ESLint as … and 3 more (compare)

  • 10:20
    oliverfoster synchronize #2648
  • 10:20

    oliverfoster on 2647

    fixes issue/2642 adds package-l… Resolves #2377, adds ESLint as … issue/2649 added change:_isActi… and 1 more (compare)

  • 10:17
    oliverfoster closed #2649
  • 10:17

    oliverfoster on 2649

    (compare)

  • 10:17

    oliverfoster on master

    issue/2649 added change:_isActi… (compare)

  • 10:17
    oliverfoster closed #2650
  • 09:38

    jamesrea83 on 1912

    (compare)

  • 09:35
    jamesrea83 synchronize #2654
  • 09:35

    jamesrea83 on 2639

    Added titles, made help text mo… (compare)

  • 09:32

    oliverfoster on 2377

    (compare)

  • 09:32
    oliverfoster closed #2462
  • 09:32

    oliverfoster on master

    Resolves #2377, adds ESLint as … (compare)

  • 09:31
    oliverfoster closed #2642
  • 09:31

    oliverfoster on 2642

    (compare)

Oliver Foster
@oliverfoster
Again, if you want input into how Adapt will progress over the next few versions, please add comments on Adapt v6+ proposal document. Thanks @brian-learningpool for yours.
Oliver Foster
@oliverfoster
Even just comments of approval, disappointment or excitement are welcome.
Chuck Lorenz
@chucklorenz
might also consider seeking comments from the forum, perhaps
Oliver Foster
@oliverfoster
That's a good idea
Oliver Foster
@oliverfoster
I'll do that in the morning. My phone doesn't play well with the forum it seems.
Thanks Chuck
Chuck Lorenz
@chucklorenz
:ok_hand:
Jérôme Loï
@gorhgorh
@oliverfoster the proposal looks amazing, I still need to wrap my head about the "remove src/course" folder thing tho (I really often erase build to get a "clean" state), also, I did not followed the discutions, but it seems that you want ppl to use the AT rather than use straight code ? I can see the move, but i can also see even less work toward developpers like me, hehe
Matt Leathes
@moloko
@gorhgorh the remove src/course thing would make Adapt work more like regular web development where you only need to run a dev/build command if you make changes to the code, not when you make changes to the content.
If you give https://github.com/cgkineo/rub-cli a try it already works like this (and also allows you to build multiple modules from the same codebase)
Jérôme Loï
@gorhgorh
I can totally see the idea
i just need to change some habits of mine
also, i never commit builds right now
Matt Leathes
@moloko

but it seems that you want ppl to use the AT rather than use straight code

I'm not sure this is accurate

Jérôme Loï
@gorhgorh
With the push for wider adoption of the AAT and in seeking to simplify the build environments, the src/course pathway can be entirely removed.
taken straight from the proposal
english is not my first language so maybee i did not understood correctly ?
hooo rub looks really nice
Matt Leathes
@moloko
no I see what you mean but no we aren't pushing people away from the framework and into the AAT (at least to my knowledge!)
Oliver Foster
@oliverfoster

[..] it seems that you want ppl to use the AT rather than use straight code?

Yea, my wording could have been clearer, that is not the case. We want people using the framework directly to have just as much involvment and more flexibility in the things they create. This will just make it easier to do that.
grunt clean will work for clearing up the build folder but retaining the build/course

Jérôme Loï
@gorhgorh
great, and this was just my own feedback, including MY habits, that should not be taken in account for the roadmap )
the only bit I'm not sure about is that would mean that we add the build to version control, isn't it ?
that would mean add builded files to version control, too, so this would add more to the versionning system than the old src/course, isn't it ?
as the will still be there in the plugins / theme dirs, right ?
Matt Leathes
@moloko
if it helps, this is how we version control our projects
Untitled-1.jpg
I think the plan is to drop the components/extensions/menu/theme subfolders
yes - see page 7
'Plugin architecture: Utilise bower correctly'
Oliver Foster
@oliverfoster

that would mean add builded files to version control, too, so this would add more to the versionning system than the old src/course, isn't it ?

Yes (and no). You wouldn't have two copies of your source files, but you would have the output files. One of the ideas is to stop having two copies of the course source files. If you had multiple videos in your source folder then you would end up with fewer MB of version controlled data but possible more files.

Oliver Foster
@oliverfoster

as the will still be there in the plugins / theme dirs, right ?

no, the src/course won't be in the src folder any more, only in the build/course

Jérôme Loï
@gorhgorh
ok thanks for the detail, i think i get it now
Oliver Foster
@oliverfoster
:+1: cool, it does sound like you will have to change your behaviour a little with how you clean the build folder and which files you edit. we've been finding that it makes everything a lot easier.
Jérôme Loï
@gorhgorh
alias 'rm -rf build'=grunt clean
Oliver Foster
@oliverfoster
This it the pr adaptlearning/adapt_framework#2644 @gorhgorh
The document is just a proposal.
Oliver Foster
@oliverfoster
added support for ES6+ adaptlearning/adapt_framework#2648
tomgreenfield
@tomgreenfield
cool, thanks ollie
Oliver Foster
@oliverfoster
subsequent pr to convert AdaptModel to an ES Class adaptlearning/adapt_framework#2651
Oliver Foster
@oliverfoster
thanks tom
Matt Leathes
@moloko
could we get one more (non-Kineo) review on adaptlearning/adapt-contrib-vanilla#249 ? like to get it merged so that we can release vanilla tomorrow
Oliver Foster
@oliverfoster
into the wilderness, off you go vanilla, fly-fly!
Andrew Bone
@Link2Twenty
Hi all, is there a way to reset certain pages back to their un-visited state? A function that can be called on contentObjects or something?
I guess I could reset each component but that feels like a lot of work
The problem I am trying to solve is. I want to make a chain of pages but if you fail at any point you return to to the beginning of the chain with every page reset.
Oliver Foster
@oliverfoster
I guess I could reset each component but that feels like a lot of work
Oliver Foster
@oliverfoster
this is actually a lot easier than it sounds
i don't think we have an api to do that in one go though
to do all the components in a page:
var pageModel = Adapt.findById('pageId');
pageModel.findDescendantModels('components').forEach(function(component) {
  component.reset();
}):
or if you wanted to make sure all descendants were done:
var pageModel = Adapt.findById('pageId');
pageModel.getAllDescendantModels().forEach(function(descendant) {
  descendant.reset();
}):