Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 23 20:51
    zarek3333 opened #124
  • Jul 22 15:01

    tomgreenfield on adapt_framework#3202

    (compare)

  • Jul 22 15:01
    tomgreenfield closed #221
  • Jul 22 15:01

    tomgreenfield on master

    Switch to widget for inview lis… Merge pull request #221 from ad… (compare)

  • Jul 22 15:01
    tomgreenfield closed #3202
  • Jul 22 14:40

    oliverfoster on 3205

    (compare)

  • Jul 22 14:40

    oliverfoster on master

    issue/3205 Ensure articles with… (compare)

  • Jul 22 14:40
    oliverfoster closed #123
  • Jul 22 14:40
    oliverfoster closed #3205
  • Jul 22 13:57
    oliverfoster synchronize #3209
  • Jul 22 13:57

    oliverfoster on 3208

    Update grunt/tasks/javascript.j… (compare)

  • Jul 22 12:30
    oliverfoster edited #3208
  • Jul 22 12:28
    oliverfoster labeled #3209
  • Jul 22 12:28
    oliverfoster labeled #3209
  • Jul 22 12:27
    oliverfoster review_requested #3209
  • Jul 22 12:27
    oliverfoster opened #3209
  • Jul 22 12:27
    oliverfoster assigned #3209
  • Jul 22 12:26

    oliverfoster on 3208

    issue/3208 Correct bad librarie… (compare)

  • Jul 22 12:24
    oliverfoster edited #3208
  • Jul 22 12:23
    oliverfoster labeled #3208
Oliver Foster
@oliverfoster
i guess we would move the role=group outside of the title, body, instruction, option container, add an id to the component__header and point the group at it, then it'd pass their test
i'll check if it reads any better
Kevin Doherty
@kevindoherty30
@oliverfoster that is perfect, that gives me a lot to go on, really appreciate the detailed response and I think you may be right that they are reading the spec verbatim and not understanding the different ways of implementing it
Oliver Foster
@oliverfoster
have you got an adapt_framework issue on github for it?
Kevin Doherty
@kevindoherty30
No I didn't want to raise an issue on it as I wasn't sure if it was an actual issue or not
Oliver Foster
@oliverfoster
Cool, i'll make one
i like it, it's nice
Oliver Foster
@oliverfoster
that is except the authoring tool produces invalid ids...
hmm
Oliver Foster
@oliverfoster
PRs:
adapt_framework: grunt warn on empty parents adaptlearning/adapt_framework#3135 (1x +1)
adapt_framework: headers lose focus if completed with focus adaptlearning/adapt_framework#3133 (3x +1)
adapt-contrib-trickle: re-write adaptlearning/adapt-contrib-trickle#113 (1x +1 @tomgreenfield)
adapt_framework: locking should ignore _isOptional adaptlearning/adapt_framework#3146 (3x +1)
Oliver Foster
@oliverfoster
interesting enhancement here if anyone fancies a look adaptlearning/adapt_framework#3149
Kevin Doherty
@kevindoherty30
@oliverfoster I was just looking at the spoor issue - adaptlearning/adapt-contrib-spoor#216
I can see that it has been merged to master but do you know when the text tagged version of spoor with this fix will be released?
Oliver Foster
@oliverfoster
hopefully later in the week or early next week?
there's just time getting in the way as far as I can tell
/all does anyone have the time to release spoor?
tomgreenfield
@tomgreenfield
might be able to tomorrow...
Oliver Foster
@oliverfoster
:+1:
ninode97
@ninode97
image.png
how to ensure that assets being moved to assets directory from the theme?
image.png
I am able to move only those .pngs that are pointed in the properties.schema.
but if I just place other needed image assets they wouldn't be moved to assets on folder on the course build step
Oliver Foster
@oliverfoster
Different assets folder.
One is in the root, the other is in the course folder I think.
ninode97
@ninode97
@oliverfoster Thanks for response!
Would it be possible to have static assets from the theme (plugin) without pointing them in the properties.schema?
image.png
Only default_0 and default_1 are being moved to the course folders. but those 2 other images are not being moved..
Oliver Foster
@oliverfoster
All included plugin assets get copied to the output. They have nothing to do with the schema.
Plugin assets and course assets are different things.
See the adapt-contib-media for an example.
You have to force rebuild in the AAT to copy new plugin assets if you've reuploaded a modified plugin.
ninode97
@ninode97
Sorry!
It worked I just needed to reference it in .less as url(assets/assetName.png)
Thank you very much!
Oliver Foster
@oliverfoster
:+1:
Oliver Foster
@oliverfoster
k-jensen
@k-jensen
@oliverfoster nice nice, was going to try it out in the authoring tool, but I think the src needs an "Asset:audio"? it's "Asset:other" at the moment
Oliver Foster
@oliverfoster
cool, ta
fixed
k-jensen
@k-jensen
thanks, all working now, love that you can put it anywhere, really useful!
Oliver Foster
@oliverfoster
:+1:
almost anywhere
k-jensen
@k-jensen
You mean my course title can't be 6 audio files?! outrageous xD
Oliver Foster
@oliverfoster
actually, i think i'd steer clear of putting it in the page/course titles altogether
it seems to come out in the brower window title
that's something i need to think about
Sam Howell
@squire:privacytools.io
[m]
Hoping someone could help me out with a question I've been asked about the adapt-close plugin:
"Does it always just try and close the window or is there a setting to unload the course and replace it with a generic 'thank you' page if it can't?"
Oliver Foster
@oliverfoster
nope, the only way adapt-close can close the window is if it was opened as a popup
and it will never not be able to close a popup