Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 20 14:55

    joe-allen-89 on v4.2.1

    (compare)

  • Oct 20 14:50

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 14:37

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 14:31

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 14:25

    joe-allen-89 on v3.3.2

    (compare)

  • Oct 20 14:20

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 14:19

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 14:19

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 14:16

    joe-allen-89 on v6.5.1

    (compare)

  • Oct 20 14:09

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 14:08

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 14:07

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 13:58

    joe-allen-89 on v5.0.2

    (compare)

  • Oct 20 13:44

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 13:44

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 13:43

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 13:24

    joe-allen-89 on v5.3.1

    (compare)

  • Oct 20 13:14

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 13:13

    joe-allen-89 on master

    Version bumped for bug fix (compare)

  • Oct 20 13:12

    joe-allen-89 on master

    Version bumped for bug fix (compare)

Oliver Foster
@oliverfoster

Hi.. I'm using 5.13 version of the framework. The previous version that I worked on was 5.10 in which I could import jquery extensions like jPlayer using define within any component. With the latest version 5.13 i'm unable to do the same. The bundler throws an error 'Cannot read property 'type' of undefined'.. Any help on this?

Can you be more specific on which file and line the error is coming from?

Oliver Foster
@oliverfoster

Quick + 1s

ES6 Conversions

Item scoring

Accessibility

Oliver Foster
@oliverfoster
  • matching and nvda not narrative
Kevin Doherty
@kevindoherty30
Hi @oliverfoster I have just seen that adaptlearning/adapt_framework#3142 is showing as fixed on the 5.14.0 framework release. Does this just require the framework update or are there any plugin updates required for it?
tomgreenfield
@tomgreenfield
i need to do some releases of plugins...will try to this week
Oliver Foster
@oliverfoster
Cahir O'Doherty
@cahirodoherty-learningpool
Hey guys, urgent PR here adaptlearning/adapt-contrib-media#220
Thanks @tomgreenfield for pinpointing the problem so quickly
Cahir O'Doherty
@cahirodoherty-learningpool
happy for me to get that merged and tagged?
tomgreenfield
@tomgreenfield
cheers cahir
Kevin Doherty
@kevindoherty30
Hi All,
We are currently testing f/w 5.14.0 and looking to test out adaptlearning/adapt_framework#3142, although the MCQ/GMCQ updates haven't yet been tagged in a released version of the components. Does anyone know when these plugin updates might get released?
tomgreenfield
@tomgreenfield
i can release those today for you kevin
Kevin Doherty
@kevindoherty30
That would be great, thank you @tomgreenfield
ethan-lp
@ethan-lp
Hey guys, just wanted to query an issue we've seen from Customers today. When assessment feedback is presented to a user placeholders such as {{{score}}} and {{{maxScore}}} are only returning 0. Just wanted to check if we could be missing something regarding config?
Oliver Foster
@oliverfoster
need to know which version of the fw and assessment you're using @ethan-lp
Oliver Foster
@oliverfoster
image.png
current version works
ethan-lp
@ethan-lp
@oliverfoster Thank you. FW is 5.14.0 and Assessment is 4.4.0. So I'll need to dig a little further I think
Oliver Foster
@oliverfoster
:+1:
See if it works using a vanilla course first?
Have you got branching / randomisation on?
ethan-lp
@ethan-lp
Yeah I checked that out already with a vanilla course and only OS plugins. Avoided branching, and with randomisation on or off still no luck
Oliver Foster
@oliverfoster
cool
was it broken in os?
ethan-lp
@ethan-lp
Yes it was also breaking for me with that set up, when I debug through adapt-assessmentArticleModel.js the '_getScore' and '_getMaxScore' are only ever returning 0 for me
Oliver Foster
@oliverfoster
:+1:
will have a look in a minute
ethan-lp
@ethan-lp
Thank you @oliverfoster
eleanor-heath
@eleanor-heath

model.maxScore returns undefined for me in this function within the assessmentArticleModel

_getMaxScore: function() {
const questionComponents = this._getCurrentQuestionComponents();
const maxScore = questionComponents.reduce((maxScore, model) => (maxScore += model.maxScore || 0), 0);
return maxScore;
}

tomgreenfield
@tomgreenfield
does it work with the master branch? the framework hasn't had a tagged release yet with the scoring stuff
Oliver Foster
@oliverfoster
it's because you're using the master assessment which wasn't for 5.14.0
or what tom said
tomgreenfield
@tomgreenfield
i'd prefer to do a release of the framework before the src/core ripper pr goes in. how does that make you feel @oliverfoster?
Oliver Foster
@oliverfoster
warm and fuzzy
tomgreenfield
@tomgreenfield
haha
cool, will get that out today
ethan-lp
@ethan-lp
Thank you both!
Oliver Foster
@oliverfoster
:+1: sorry for the confusion
it's the new item specific scoring stuff
ethan-lp
@ethan-lp
No worries, more so my lack of experience. I couldn't get to the bottom of it on Friday. Appreciate the time and help
Muthu
@muthuselvan86
Hi All, I have a requirement to tailor our course content for a specific customer basically alter the Block/component content. I don't want to create a separate course for this minimum content change instead manage through some flag on same course settings. I am thinking of to create an extension to show /hide the content based on that flag. But is there any better way to achieve this requirement? (I'm using Framework 5.6.1). Appreciate your help!
Oliver Foster
@oliverfoster
nope, that sounds about right, i would duplicate the course and remove the pieces
Muthu
@muthuselvan86
Yea thats quick! The problem will be i end up creating multiple duplicate courses that would be hard to maintain. The approach would be to add a custom text field in block or components JSONS and manage to show the content through flag and template adjustment for specific customer(extension). Thinking of any better approach!.
Oliver Foster
@oliverfoster
you should be able to:
const clientVersion = Adapt.course.get('_clientVersion');
if (!version) return;
Adapt.data.forEach(model => {
  const modelClientVersion = model.get('_clientVersion');
  if (!modelClientVersion) return;
  if (!modelClientVersion.split(' ').includes(clientVersion)) model.set('_isAvailable', false);
});
Which means any model with _clientVersion must match the _clientVersion in course.json
you could then put _clientVersion: 'version1' or _clientVersion: 'version2' in course.json and a block model with _clientVersion: 'version1 version2' would appear
but the same block wouldn't appear if _clientVersion: 'version3' was put in the course.json
tomgreenfield
@tomgreenfield
careful about the String.includes() if the number of versions gets into double digits e.g. version10
Muthu
@muthuselvan86
Wow! Thank you for your time! Nice Solution! Let me summarize if i understand your approach completely. I need to come up with a small extension that should run the above code as soon as the Adapt dataLoaded and set the model availability based on the clientVersion.
Oliver Foster
@oliverfoster
bingo
i would do it at block level probably?