by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Helen Bailey
    @hmaffin
    :thumbsup:
    Tom Taylor
    @taylortom
    But would that be something we define as Adapt, or something that should be provided by the theme dev?
    Helen Bailey
    @hmaffin
    hm
    Tom Taylor
    @taylortom
    that's the next question :D
    Helen Bailey
    @hmaffin
    each answer leads to more questions!
    ok seriously weird
    which colour do i need to change for what's behind ""Page Title" as above in my screenshot
    Tom Taylor
    @taylortom
    I'm not sure I've made that accessible in my theme helen, I couldn't find it myself :laughing:
    Helen Bailey
    @hmaffin
    because in the list, "Background colour" was showing as pale aqua for me (and was the only one that WAS that colour, so I changed it to purply, but the behind Page title is still blue (despite it not being present in the options anywhere) and my page background is purply
    oh well then ;)
    so if I don't want the pale aqua there.... tough? :P
    Tom Taylor
    @taylortom
    Yeah, didn't look into how that's defined
    Helen Bailey
    @hmaffin
    ok
    Tom Taylor
    @taylortom
    it should be 'background-color-inverted'
    Rui @LetItHappen
    @letithappen
    Hi @taylortom ! I just checked out issue/1495 branch and already seeing the theme editor option on the AT. But I can't get over the contructor error
    should I try to update my vanilla theme
    ?
    Rui @LetItHappen
    @letithappen
    blob
    Aniket Dharia
    @aniketdharia
    Same error for me too
    Rui @LetItHappen
    @letithappen
    maybe I branched it the wrong way? What I did was "git checkout remotes/origin/issue/1495"
    then the grunt build
    node server run ok
    AT seems all ok
    But choosing Vanilla theme or other one of my results in that error
    meant "of mine"
    Tom Taylor
    @taylortom
    I think that error's related to the vanilla schema. Have you tested the alternative vanilla I linked to?
    Rui @LetItHappen
    @letithappen
    I'm certainly looking the wrong way because I can't find it on that link
    Tom Taylor
    @taylortom
    https://github.com/taylortom/adapt-contrib-vanilla
    Rui @LetItHappen
    @letithappen
    thanks
    I'll try with this one
    Tom Taylor
    @taylortom
    It's linked somewhere in my PR (not very obvious, admittedly)
    :+1:
    Rui @LetItHappen
    @letithappen
    I can see the color options now! great!
    Tom Taylor
    @taylortom
    :tada:
    Rui @LetItHappen
    @letithappen
    I think now I done it also to one of my test themes, just filling the properties.schema
    changing version on bower
    and uploading new version
    Tom Taylor
    @taylortom
    Cool, any luck?
    Rui @LetItHappen
    @letithappen
    yes
    it works just as the vanilla
    canstudios-paulh
    @canstudios-paulh
    Thinking out loud... What about a class in AT compatible themes which indicate selectable elements for colouring?
    Tom Taylor
    @taylortom
    Certainly feasible
    Could apply similar logic to other types of editing
    Tom Taylor
    @taylortom
    The more I think about this, the more sense it makes.
    I'm intending to get the tool to a stage whereby we have two different build processes for preview and publishing
    Aniket Dharia
    @aniketdharia
    @taylortom we actually do...
    the tool does not build each time you make an update.. it just updates json files
    Tom Taylor
    @taylortom
    The only thing that changes is a parameter though
    They're fundamentally the same
    But yes, there is a slight distinction already