These are chat archives for adaptlearning/theming

19th
Sep 2017
Oliver Foster
@oliverfoster
Sep 19 2017 09:51
oh yea!
cool
Nils Sanderson
@nilslp
Sep 19 2017 09:51
@oliverfoster
So I just wanted to see what happened with the progress on adaptlearning/adapt_framework#1189.

I have been checking what the minimum code required for a theme is (kind of working backwards) but just with the minimum of boxmenu and blank component from the builder. There is a lot of LESS (variables, mixins) and handlebars required.

From looking at the branch above I can see alot of stuff was moved, but not sure the status of any of this or what the plan was?

Oliver Foster
@oliverfoster
Sep 19 2017 10:03
well... what happened was that aniket, guy and I decided what to do, then it all fizzled out
Nils Sanderson
@nilslp
Sep 19 2017 10:04
What would your proposed solution to getting this sorted, be? Fork off that repo and continue finishing (with the comments you have made at the bottom of the issue?)
Oliver Foster
@oliverfoster
Sep 19 2017 10:05
hmm, i'm not entirely sure what's needed now. fundamentally we need a quick way of theming authoring tool courses, second to that we need a really sripped down core theme which has nothing but basic structural stuff in it. getting the mix right between those two things is pretty difficult in one theme
Nils Sanderson
@nilslp
Sep 19 2017 10:05
yeah
so i have removed everything that is not needed in a theme (local theme) to see what the minimum is with the boxmenu and blank component.
I figure starting here and moving the core stuff into the framework and working my way through a good number of plugins should be fine.
Oliver Foster
@oliverfoster
Sep 19 2017 10:08
i understand the method, how is performing that series of steps going to leave you at the right conclusion?
Nils Sanderson
@nilslp
Sep 19 2017 10:08
At the end of the day if the theme redeclares variables or handlebars we dont care (maybe not true, but i mean in theory it doesnt matter) as they are overriding something that already exists and the main thing is that it wont break because of a missing variable
Oliver Foster
@oliverfoster
Sep 19 2017 10:08
i would imagine you'll probably end up with a whole list of required variables that all the plugins need to build
Nils Sanderson
@nilslp
Sep 19 2017 10:10
I think its a step in the right direction, because at the moment there is talk about disconnecting the theme/plugins from the core, i feel this is the first step.
If there is improvements, changes, better practices to be enforced that can come in the next step.
Trying to do this all at the same time seems like it could be more error prone.
Oliver Foster
@oliverfoster
Sep 19 2017 10:10
cool
Nils Sanderson
@nilslp
Sep 19 2017 10:12
Im not trying to argue im right vs your right or anything, i just feel this was talked about 3 years ago and its still being talked about as opposed to small actions in the right direction? Could be very wrong based on your work adaptlearning/adapt_framework#1189 here.
I figure moving what is required into the core and making an updated base(vanilla) template theme for people to copy would be a good first step?
Oliver Foster
@oliverfoster
Sep 19 2017 10:13
cool, give it a shot, don't go too far and talk through your problems
i think it'll be fine
there are a whole lot of varied theming requirements from everyone in the community
so a layered approach is a good approach
Nils Sanderson
@nilslp
Sep 19 2017 10:15
Yeah i mean i do know this wont work potentially everywhere (or even well) but figure its a good place to start.
also Wanted to just check this hypothetical with you, the problem is the reliance on the vanilla code (less/hbs). If it all sat in core (i know this is bad but just as its in my head) then everything should build? Just a speaking my thoughts thing.
Oliver Foster
@oliverfoster
Sep 19 2017 10:19
yup, that was one of my initial intentions
having no theme should be possible
Nils Sanderson
@nilslp
Sep 19 2017 10:19
Yeah
Oliver Foster
@oliverfoster
Sep 19 2017 10:19
or, like you said, the starting point
Nils Sanderson
@nilslp
Sep 19 2017 10:19
as per our previous conversation i hope i am now aligned with your thinkings
Oliver Foster
@oliverfoster
Sep 19 2017 10:20
x)
Nils Sanderson
@nilslp
Sep 19 2017 10:20
:)
What would your preference be for this as in would you like me to continue in adaptlearning/adapt_framework#1189 but with my own changes and branch stuff or make an entirely new ticket (and keep it up to date)?
Oliver Foster
@oliverfoster
Sep 19 2017 10:23
by all means, start again
Nils Sanderson
@nilslp
Sep 19 2017 10:36
Cheers @oliverfoster
Nils Sanderson
@nilslp
Sep 19 2017 11:00
Hi, will be tracking this issue here: adaptlearning/adapt_framework#1804
Ciaran Duffy
@ciaranlp
Sep 19 2017 14:28
what you guys said ^^^^^^
Nils Sanderson
@nilslp
Sep 19 2017 15:11
Hey @oliverfoster does this still apply in your thinkings? - https://github.com/oliverfoster/example-core-less
Taken from here - adaptlearning/adapt_framework#1189
Oliver Foster
@oliverfoster
Sep 19 2017 15:13
yes @nilslp
unless you can figure out something more sensible?
Nils Sanderson
@nilslp
Sep 19 2017 15:14
Given the structure for the themes/plugin has been changed here: adaptlearning/adapt-contrib-vanilla#202
yup
Nils Sanderson
@nilslp
Sep 19 2017 15:18
Stupid wasting time on this but i just want to try and align things where I can:
Screen Shot 2017-09-19 at 16.18.13.png
common hasnt been referenced anywhere else in the codebases that im aware of
and would it be ok to name modules > plugins?
I think common is fine just maybe change modules to plugins? Unless there is good reason not to?
@brian-learningpool or @ciaranlp care to throw another opinion in the mix?
Nils Sanderson
@nilslp
Sep 19 2017 15:27
OK. I will keep what you have above @oliverfoster
Oliver Foster
@oliverfoster
Sep 19 2017 15:29
um modules > plugins i guess so, there is a distinction between a module and a plugin in the wiki info, but i'm not sure it's entirely a good separation - seeing as those modules will probably become plugins in v4
Nils Sanderson
@nilslp
Sep 19 2017 15:29
up to you im just setting it up here now so whatever you want...?
Oliver Foster
@oliverfoster
Sep 19 2017 15:30
modules is fine for the moment, we can always migrate them to plugins when they actually become plugins
common is just stuff that is used by all plugins + core
Nils Sanderson
@nilslp
Sep 19 2017 15:30
:thumbsup:
anything to group mixins or anything or make a utility directory?
or shove them into variables?
Oliver Foster
@oliverfoster
Sep 19 2017 15:31
responsive.less is a good example of that
that's up to you
see how many files you end up with that are just mixins
it might not be worth separating
Nils Sanderson
@nilslp
Sep 19 2017 15:32
transitions.less atm
think just in variables for now
Oliver Foster
@oliverfoster
Sep 19 2017 15:34
fair enough
Nils Sanderson
@nilslp
Sep 19 2017 15:37
maybe a plugins folder can be added so that the leftover stuff from the vanilla less port can be shoved in there until such times...?
shouldnt have plugins in it long term but as a step towards where we want to be
Oliver Foster
@oliverfoster
Sep 19 2017 15:40
the plugins folder shouldn't really be in core at all, i think if we were to have multiple themes (in the future) we would have a basic theme with the plugins folder which is separate
the plugins folder is really for theme related overrides
there shouldn't be any core plugin overrides if you see what i mean?
Nils Sanderson
@nilslp
Sep 19 2017 15:40
i know, i just mean in the interim or we can call it compatibility if you want, its more to allow us to move forward while not breaking anything
i do
2 secs
Oliver Foster
@oliverfoster
Sep 19 2017 15:41
:+1:
Nils Sanderson
@nilslp
Sep 19 2017 15:41
your right sorry
i have moved things from vanilla over but i was yet to delete these
getting confused my bad
Oliver Foster
@oliverfoster
Sep 19 2017 15:42
x) it's easily done
take time
there's a lot going on in the theme
Nils Sanderson
@nilslp
Sep 19 2017 15:42
:ok_hand:
yeah, had in my head there were plugin variables added in but its all good
(was trying to make a better template theme at the same time as sorting the core)
hence i will not be sorting the template theme until im sorted here :)