These are chat archives for adaptlearning/theming

2nd
Oct 2017
Nils Sanderson
@nilslp
Oct 02 2017 13:45

Hi @oliverfoster. Have you had a chance to look at:

I have put some code up here: https://github.com/nilslp/adapt_framework/tree/issue/1804 if you get time, please have a look through and comment.
I have not as yet went through with a fine comb and sorted all duplicates and such but the majority of the files were not bad for combining code.
I have left a distinct break in the files where there was a merge of code from theme and core. I do intend to go through all of this and strip it all back to the bare minimum but I know that @oliverfoster you are very familiar with this all and can probably kickstart it all in the right direction.

Oliver Foster
@oliverfoster
Oct 02 2017 13:47
not yet @nilslp I'm stupid busy at the moment, i'll try and get to it tonight, having a bit of a rough monday morning trying to catch up with lots of stuff i haven't done yet
sorry
Nils Sanderson
@nilslp
Oct 02 2017 13:47
No problem im sure you are. Thanks :thumbsup:
Oliver Foster
@oliverfoster
Oct 02 2017 19:41
@nilslp i did a pr with your code to review only
adaptlearning/adapt_framework#1825
let me know what you think, sorry it's taken so long
Nils Sanderson
@nilslp
Oct 02 2017 19:44
Hey great thanks very much. Looks like you spent some time on so really appreciate it thanks. Will get to it tomorrow :thumbsup:
Oliver Foster
@oliverfoster
Oct 02 2017 19:45
No worries. Some of the comments are a bit abstract, so you'll probably need clarification. I've left all the bits you've got WIP comments on cos I figured it'll become clearer what needs to happen to those after we get through the comments I left.
Most of the WIP bits will be just a straight merge + simplify, but some will need a tidy, as expected I'm sure.