Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Guy Willis
    @guywillis
    Could quite well be, Matt!
    OMG using a mixture of braces on line and braces after? the man's cracked
    Guy Willis
    @guywillis
    I think I've reviewed all current indentation PR's. All good, just a couple of comments on Hotgraphic and Matching
    Nils Sanderson
    @nilslp
    Thanks, a bit busy at the moment, hopefully get to a few more soon
    Guy Willis
    @guywillis
    Any luck getting time on the indentation prs @nilslp @BillGilmoreLP ?
    Nils Sanderson
    @nilslp
    Nope sorry @guywillis
    Guy Willis
    @guywillis
    Any idea when you may have some free time @nilslp ?
    Nils Sanderson
    @nilslp
    atm possibly friday
    Nils Sanderson
    @nilslp
    adaptlearning/adapt_framework#2381 < all PR’s linked here. The ones that are tick'd have already been merged.
    Oliver Foster
    @oliverfoster
    :+1:
    Nils Sanderson
    @nilslp

    Thanks @oliverfoster so there are only 3 left.

    2 of which I think you want the refactor work merged first and then indented before they are merged in:

    1 of which I think is fine to be merged now:

    just need matt's prs bringing through
    :fish:
    Matt Leathes
    @moloko
    :fried_shrimp:
    Oliver Foster
    @oliverfoster
    :dolphin:
    :whale:
    Nils Sanderson
    @nilslp
    Nils Sanderson
    @nilslp
    Good afternoon folks
    I know @guywillis is off at the moment and I am not sure if anyone has came across this yet: https://github.com/adaptlearning/adapt_framework/commit/4d9b2ef9b840f5312635885b260a2d7fe19363e6#diff-75a42229138a2ed8b53d97a3d1598089
    But I think the screenSize calculation is been broken here (v5 so not released)
    The calculation divides e.g. 1920 / 17.6 = 109.09 then compares against the medium breakpoint first which is 759 (but no breakpoint will ever be lower than 109) and this is on a widescreen monitor.
    Not quite sure what the original thought was so not 100% on what to update it to, but I have reverted it on my own testing atm.
    Here endeth the typing..
    Guy Willis
    @guywillis
    Hey @nilslp
    Guy Willis
    @guywillis

    As mentioned in the link above, the screen size values change depending on the body font size with the idea that adapt becomes more responsive and fluid rather than having strict break points (responsive vs adaptive).

    Adapt would still contain some of the benefits of adaptive (break points for swapping out images / components etc) but it's positioned in a more fluid way whereby the image or interaction would only change if it's appropriate (according to screensize / font size)

    Oliver Foster
    @oliverfoster
    is v5 released yet?
    Matt Leathes
    @moloko
    dunno, let me check the spreadsheet and see how many plugins you've released... ;-)
    Oliver Foster
    @oliverfoster
    it's alright Guy... sit down...
    ;D
    Matt Leathes
    @moloko
    none!
    any assistance gratefully received
    Oliver Foster
    @oliverfoster
    I'm attempting to provide moral assistance...
    I think I've made Guy cry though...
    so...
    Matt Leathes
    @moloko
    that's fine, he can cry and release at the same time
    they're both forms of release after all
    Oliver Foster
    @oliverfoster
    Nicely done v5 peoples. A stupendous job well done!
    Brian Quinn
    @brian-learningpool
    great job, all! :+1:
    Matt Leathes
    @moloko
    and without further ado, I present to you: https://adaptlearning.github.io/v5demo/
    wow this conversation started in march
    Brian Quinn
    @brian-learningpool
    got there in the end though
    looks crisp - - I like it
    Matt Leathes
    @moloko
    I think v4 took a similar amount of time. considering that it was the best part of three years between v2 and v3 we're still doing a lot better than we were!
    Matt Leathes
    @moloko
    any objections to me closing this room now?
    Oliver Foster
    @oliverfoster
    Nope
    Brian Quinn
    @brian-learningpool
    is there a v6 room?
    Oliver Foster
    @oliverfoster
    not yet