ADempiere Business Suite ERP/CRM/MFG/SCM/POS done the Bazaar way in an open and unabated fashion. Focus is on the Community that includes Subject Matter Specialists, Implementors and End-Users.
@DisplayName("Given the GardenWorld context")
class ProcessBuilderTest extends CommonGWSetup {
private static final String CLIENT_ACCOUNTING_IMMEDIATE = "I";
ProcessBuilder clientAcctProcessor;
ProcessBuilder resetAccounting;
@BeforeEach
void givenClientAccountingEnabled() {
enableClientAccounting();
}
@Nested
@DisplayName("When the first process is created")
class WhenASingleProcessIsCreated {
@BeforeEach
void whenClientAcctProcessorIsCreated() {
clientAcctProcessor = ProcessBuilder.create(ctx)
.process(org.adempiere.process.ClientAcctProcessor.class)
.withTitle("ClientAcctProcessorTest");
}
@Test
@DisplayName("When the first process is run, "
+ "then the process succeeds")
void whenTheClientAcctProcessorIsRun_itSucceeds() {
ProcessInfo info = clientAcctProcessor.execute(trxName);
assertEquals("OK", info.getSummary());
}
@Nested
@DisplayName("When a second process is created")
class WhenASecondProcessIsCreated {
@BeforeEach
void whenFactResetProcessorIsCreated() {
resetAccounting = ProcessBuilder.create(ctx)
.process(org.compiere.process.FactAcctReset.class)
.withTitle("FactAcctReset")
.withParameter(FactAcctReset.AD_CLIENT_ID,
AD_CLIENT_ID)
.withParameter(FactAcctReset.DELETEPOSTING, true)
.withParameter(FactAcctReset.DATEACCT,
TimeUtil.getDay(1999, 01, 01), today);
}
@Test
@DisplayName("When the second process is executed, "
+ "then it succeeds")
void whenTheFactResetProcessorIsRun_itSucceeds() {
ProcessInfo info = resetAccounting.execute(trxName);
assertTrue(info.getSummary().startsWith("Updated"));
}
@Test
@DisplayName("When the first process is executed again, "
+ "then it should succeed")
void butWhenTheClientAcctProcessorIsRun_itShouldSucceed() {
ProcessInfo info = clientAcctProcessor.execute(trxName); // This throws a NPE
assertEquals("OK", info.getSummary());
}
}
}
private void enableClientAccounting() {
MSysConfig gwAccounting = getOrCreateClientAcctConfig();
gwAccounting.setValue(CLIENT_ACCOUNTING_IMMEDIATE);
gwAccounting.saveEx();
}
private MSysConfig getOrCreateClientAcctConfig() {
return clientAccountingConfigs(AD_CLIENT_ID)
.filter(config -> config.getAD_Client_ID() == AD_CLIENT_ID)
.findFirst()
.orElseGet(() -> {
MSysConfig config = new MSysConfig(ctx, 0, null);
config.setName("CLIENT_ACCOUNTING");
config.saveEx();
return config;
});
}
private Stream<MSysConfig> clientAccountingConfigs(int clientId) {
String where = "Name=? AND AD_Client_ID IN (0, ?)";
return new Query(ctx, I_AD_SysConfig.Table_Name, where, null)
.setOnlyActiveRecords(true)
.setParameters("CLIENT_ACCOUNTING", clientId)
.setOrderBy("AD_Client_ID DESC, AD_Org_ID DESC")
.list(MSysConfig.class)
.stream();
}
}
I think the cause is that the processBuilder field is static.
then I can test and same time make merge the refactory testing , please can syncronice your branch with last develop branch
1.- you need are sure that this line https://github.com/adempiere/adempiere/blob/3d9b6c996abbb86e3e1ab6a425119d7fde20d1e2/base/src/org/adempiere/process/ClientAcctProcessor.java#L304
or
no return a null value , the first that I executed I got null , I not understand m this throw an exception NPE
I rebuild all project and when a got a value timestamp then the testing continue
I adding the DateAcct column the FM_Batch only to solve the error
then the testing continue
So the test now show next:
@ProcessRunError@ @Error@ Client Accounting is not enabled
In order to run this process you need to enable client accounting, this can be done in window System Configurator, setting the parameter CLIENT_ACCOUNTING to [I]mmediate or [Q]ueue
5 replies
So that I think that test no have right design, because the Client Accounting is not enabled
@Test
@DisplayName("Then the ClientAcctProcessor doIt method should "
@DisplayName("Then the ClientAcctProcessor doIt method should "
+ "throw an exception")
final void whenClientAcctDisabled_throwsException() {
assertThrows(AdempiereException.class, () -> {
process.execute(trxName);
});
}
because I got exception but the assertThrows not passed
1 reply
I think your other type y problems are not in the thread to see with processBuilder
I think it is good to always validate that the process is carried out with no exception in all its problems so that you can be sure that before you evaluate any assertion that the process is successful
ProcessInfo info = process.execute(trxName);
if (info.isError())
throw new AdempiereException(info.getThrowable().toString());
@e-Evolution I responded in threads except for the picture above. I'm not sure if it applied to the comment "I think that the exception is not propagate ..." or not. I marked up the picture to show where the failures are coming from. For the assertThrows, no error was caught - which means the exception was thrown as expected - so the test whenClientAcctDispabled_throwsException passed.
I've added the following logical assert method to the test and used it everyplace I expect the process to succeed.
private void assertProcessWasSuccessful(ProcessInfo info) {
assertFalse(info.isError());
assertEquals("OK", info.getSummary());
}
@Test
@DisplayName("When passed no parameters, then the process should "
+ "succeed")
final void whenNoParameters_doItReturnsOk() throws Exception {
ProcessInfo info = process.execute(trxName);
assertProcessWasSuccessful(info);
}
For the processBuilder error, when I make the following changes, the tests pass:
Note - ideally, I'd refactor the field name so it doesn't match the class name, but the changes show the idea.
Other proiblem that I found was that report to @yamelsenih Yamel , the table FM_Batch have not DateAcct then the return Client Accounting Processor return an NPE for this reason
Here is the fix adempiere/adempiere#3226
@e-Evolution Wow. That was fast! Thanks.
@fly8monkey We are aware the site is down. You can access info at https://adempiere.gitbook.io/docs/ or http://wiki.adempiere.io/ADempiere_ERP
We had an issue when moving to a new DNS. I hope we can resolve it soon.
@yamelsenih @e-Evolution Travis CI builds don't seem to be running. There may be a credit issue as they move from travis-ci.org to travis-ci.com. It should still be free for Open Source projects. Can you check it out?
Hi @mckayERP thanks, Travis now have plans for free and pay for. I change this to github actions and is ok, here a merge: https://github.com/adempiere/adempiere/runs/1746527315
now is ok, see: https://github.com/adempiere/adempiere/runs/1746527315
nice