Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 07 04:26
    eelti edited #3385
  • Mar 07 04:17
    eelti opened #3385
  • Mar 06 03:23
  • Mar 05 17:40
    GabrielMartinezBranisa starred adempiere/adempiere
  • Mar 04 14:14

    e-Evolution on develop

    Add github actions to use a sin… Merge pull request #3384 from m… (compare)

  • Mar 04 14:14
    e-Evolution closed #3384
  • Mar 04 14:14
    e-Evolution closed #3383
  • Mar 04 13:07

    mckayERP on #3383_UpdateGithubActionsForJava1.8

    (compare)

  • Mar 04 12:56
    mckayERP review_requested #3384
  • Mar 04 12:56
    mckayERP review_requested #3384
  • Mar 04 12:56
    mckayERP review_requested #3384
  • Mar 04 12:56
    mckayERP opened #3384
  • Mar 04 12:50

    mckayERP on #3383_UpdateGithubActionsForJava1.8

    Update github actions to use ja… (compare)

  • Mar 04 12:44

    mckayERP on develop

    Add github actions to use a sin… (compare)

  • Mar 04 12:40
    mckayERP labeled #3383
  • Mar 04 12:40
    mckayERP assigned #3383
  • Mar 04 12:40
    mckayERP opened #3383
  • Mar 04 12:38

    mckayERP on develop

    #3368 Throws an error when doin… (compare)

  • Mar 04 12:32
    mckayERP synchronize #3377
  • Mar 04 12:32

    mckayERP on #3309_FixGardenWorldCleanUp

    Fix an assumption in the TimeUt… (compare)

e-Evolution
@e-Evolution
about the When Acccounting is reset for some case got an exeption :
image.png

@ProcessRunError@ @Error@ Client Accounting is not enabled

In order to run this process you need to enable client accounting, this can be done in window System Configurator, setting the parameter CLIENT_ACCOUNTING to [I]mmediate or [Q]ueue

5 replies
So that I think that test no have right design, because the Client Accounting is not enabled
e-Evolution
@e-Evolution
I think that the exception is not propagate or thi test is not right
@Test
@DisplayName("Then the ClientAcctProcessor doIt method should "
            + "throw an exception")
    final void whenClientAcctDisabled_throwsException() {

        assertThrows(AdempiereException.class, () -> {
            process.execute(trxName);
        });

    }
because I got exception but the assertThrows not passed
image.png
1 reply
I think your other type y problems are not in the thread to see with processBuilder
I think it is good to always validate that the process is carried out with no exception in all its problems so that you can be sure that before you evaluate any assertion that the process is successful
e-Evolution
@e-Evolution
please adding this lines in your test code when finish any process execution
1 reply
       ProcessInfo info = process.execute(trxName);
            if (info.isError())
                throw new AdempiereException(info.getThrowable().toString());
Michael McKay
@mckayERP
image.png
Michael McKay
@mckayERP
@e-Evolution I responded in threads except for the picture above. I'm not sure if it applied to the comment "I think that the exception is not propagate ..." or not. I marked up the picture to show where the failures are coming from. For the assertThrows, no error was caught - which means the exception was thrown as expected - so the test whenClientAcctDispabled_throwsException passed.
I've added the following logical assert method to the test and used it everyplace I expect the process to succeed.
private void assertProcessWasSuccessful(ProcessInfo info) {

    assertFalse(info.isError());
    assertEquals("OK", info.getSummary());

}

    @Test
    @DisplayName("When passed no parameters, then the process should "
            + "succeed")
    final void whenNoParameters_doItReturnsOk() throws Exception {

        ProcessInfo info = process.execute(trxName);
        assertProcessWasSuccessful(info);                

    }
Michael McKay
@mckayERP
image.png
For the processBuilder error, when I make the following changes, the tests pass:
Note - ideally, I'd refactor the field name so it doesn't match the class name, but the changes show the idea.
e-Evolution
@e-Evolution
@mckayERP the change is ok , create the pull request please
Yamel Senih
@yamelsenih
Hik

Other proiblem that I found was that report to @yamelsenih Yamel , the table FM_Batch have not DateAcct then the return Client Accounting Processor return an NPE for this reason

Here is the fix adempiere/adempiere#3226

Michael McKay
@mckayERP
@e-Evolution The pull request is prepared adempiere/adempiere#3322.
@e-Evolution Wow. That was fast! Thanks.
Michael McKay
@mckayERP
@yamelsenih @e-Evolution Travis CI builds don't seem to be running. There may be a credit issue as they move from travis-ci.org to travis-ci.com. It should still be free for Open Source projects. Can you check it out?
e-Evolution
@e-Evolution
@mckayERP , @yamelsenih know this subject , he said me will check
fly8monkey
@fly8monkey
Hi everybody, nice to meet you all. I start to learn about Adempiere, but can't access adempiere.net for installing tutorial, is its website still alive? Thanks you all.
Michael McKay
@mckayERP
@fly8monkey We are aware the site is down. You can access info at https://adempiere.gitbook.io/docs/ or http://wiki.adempiere.io/ADempiere_ERP
We had an issue when moving to a new DNS. I hope we can resolve it soon.
Yamel Senih
@yamelsenih

@yamelsenih @e-Evolution Travis CI builds don't seem to be running. There may be a credit issue as they move from travis-ci.org to travis-ci.com. It should still be free for Open Source projects. Can you check it out?

Hi @mckayERP thanks, Travis now have plans for free and pay for. I change this to github actions and is ok, here a merge: https://github.com/adempiere/adempiere/runs/1746527315

nice
Michael McKay
@mckayERP
@yamelsenih Thanks!
e-Evolution
@e-Evolution
Wonderful monitoring for ADempiere of a PostgreSQL Cluster with Grafana and Promethe https://twitter.com/eEvolution_/status/1352683391087505408?s=20
ADempiere on a PostgreSQL Cluster with Kubernetes https://twitter.com/eEvolution_/status/1352688543097872385?s=20
e-Evolution
@e-Evolution
@mckayERP can please solve the error build
so I can merge the develop please
Michael McKay
@mckayERP
@e-Evolution Thanks for the review on that PR. I hope it makes a big difference to the developers. For me, it really speeds up the pace of my work and makes the most of the limited time I have.
e-Evolution
@e-Evolution
Hi i check and made merge
Into the develop
Is ok
Michael McKay
@mckayERP
Yes. I've already made another PR on top of it.
e-Evolution
@e-Evolution
Exist small change transacction name
But is ok
Michael McKay
@mckayERP
@e-Evolution I was thinking that spelling things out was better, but in hind-sight, I prefer trxName as it is still understood and short. I'll update it.
sajeev
@sajeevsahadev
Is our ADempiere follow GRPR compliances?
Yamel Senih
@yamelsenih
hi @sajeevsahadev you can see it here: https://github.com/adempiere/adempiere-gRPC-Server/releases
e-Evolution
@e-Evolution
how is GRPR?