Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 11:53
    mckayERP commented #3434
  • 11:01
    mckayERP commented #3377
  • 10:52
    mckayERP review_requested #3433
  • Apr 14 21:23
    e-Evolution synchronize #3342
  • Apr 14 21:18
    yamelsenih commented #3342
  • Apr 14 21:16

    yamelsenih on develop

    #3266 Error in calculating quan… (compare)

  • Apr 14 21:16
    yamelsenih closed #3343
  • Apr 14 21:13
    yamelsenih labeled #3428
  • Apr 14 21:13
    yamelsenih labeled #3428
  • Apr 14 21:13
    yamelsenih assigned #3428
  • Apr 14 21:12
    yamelsenih edited #3434
  • Apr 14 21:12
    yamelsenih commented #3377
  • Apr 14 21:04

    e-Evolution on develop

    Adding a clear method to empty … Adding a clear method to empty … Merge pull request #3240 from O… (compare)

  • Apr 14 21:04
    e-Evolution closed #3240
  • Apr 14 21:04
    e-Evolution closed #3239
  • Apr 14 21:00
    rcapecce commented #3240
  • Apr 14 20:47
    e-Evolution milestoned #3435
  • Apr 14 20:47
    e-Evolution assigned #3435
  • Apr 14 20:47
    e-Evolution labeled #3435
  • Apr 14 20:47
    e-Evolution review_requested #3435
e-Evolution
@e-Evolution
I think your other type y problems are not in the thread to see with processBuilder
I think it is good to always validate that the process is carried out with no exception in all its problems so that you can be sure that before you evaluate any assertion that the process is successful
please adding this lines in your test code when finish any process execution
1 reply
       ProcessInfo info = process.execute(trxName);
            if (info.isError())
                throw new AdempiereException(info.getThrowable().toString());
Michael McKay
@mckayERP
image.png
Michael McKay
@mckayERP
@e-Evolution I responded in threads except for the picture above. I'm not sure if it applied to the comment "I think that the exception is not propagate ..." or not. I marked up the picture to show where the failures are coming from. For the assertThrows, no error was caught - which means the exception was thrown as expected - so the test whenClientAcctDispabled_throwsException passed.
I've added the following logical assert method to the test and used it everyplace I expect the process to succeed.
private void assertProcessWasSuccessful(ProcessInfo info) {

    assertFalse(info.isError());
    assertEquals("OK", info.getSummary());

}

    @Test
    @DisplayName("When passed no parameters, then the process should "
            + "succeed")
    final void whenNoParameters_doItReturnsOk() throws Exception {

        ProcessInfo info = process.execute(trxName);
        assertProcessWasSuccessful(info);                

    }
Michael McKay
@mckayERP
image.png
For the processBuilder error, when I make the following changes, the tests pass:
Note - ideally, I'd refactor the field name so it doesn't match the class name, but the changes show the idea.
e-Evolution
@e-Evolution
@mckayERP the change is ok , create the pull request please
Yamel Senih
@yamelsenih
Hik

Other proiblem that I found was that report to @yamelsenih Yamel , the table FM_Batch have not DateAcct then the return Client Accounting Processor return an NPE for this reason

Here is the fix adempiere/adempiere#3226

Michael McKay
@mckayERP
@e-Evolution The pull request is prepared adempiere/adempiere#3322.
@e-Evolution Wow. That was fast! Thanks.
Michael McKay
@mckayERP
@yamelsenih @e-Evolution Travis CI builds don't seem to be running. There may be a credit issue as they move from travis-ci.org to travis-ci.com. It should still be free for Open Source projects. Can you check it out?
e-Evolution
@e-Evolution
@mckayERP , @yamelsenih know this subject , he said me will check
fly8monkey
@fly8monkey
Hi everybody, nice to meet you all. I start to learn about Adempiere, but can't access adempiere.net for installing tutorial, is its website still alive? Thanks you all.
Michael McKay
@mckayERP
@fly8monkey We are aware the site is down. You can access info at https://adempiere.gitbook.io/docs/ or http://wiki.adempiere.io/ADempiere_ERP
We had an issue when moving to a new DNS. I hope we can resolve it soon.
Yamel Senih
@yamelsenih

@yamelsenih @e-Evolution Travis CI builds don't seem to be running. There may be a credit issue as they move from travis-ci.org to travis-ci.com. It should still be free for Open Source projects. Can you check it out?

Hi @mckayERP thanks, Travis now have plans for free and pay for. I change this to github actions and is ok, here a merge: https://github.com/adempiere/adempiere/runs/1746527315

nice
Michael McKay
@mckayERP
@yamelsenih Thanks!
e-Evolution
@e-Evolution
Wonderful monitoring for ADempiere of a PostgreSQL Cluster with Grafana and Promethe https://twitter.com/eEvolution_/status/1352683391087505408?s=20
ADempiere on a PostgreSQL Cluster with Kubernetes https://twitter.com/eEvolution_/status/1352688543097872385?s=20
e-Evolution
@e-Evolution
@mckayERP can please solve the error build
so I can merge the develop please
Michael McKay
@mckayERP
@e-Evolution Thanks for the review on that PR. I hope it makes a big difference to the developers. For me, it really speeds up the pace of my work and makes the most of the limited time I have.
e-Evolution
@e-Evolution
Hi i check and made merge
Into the develop
Is ok
Michael McKay
@mckayERP
Yes. I've already made another PR on top of it.
e-Evolution
@e-Evolution
Exist small change transacction name
But is ok
Michael McKay
@mckayERP
@e-Evolution I was thinking that spelling things out was better, but in hind-sight, I prefer trxName as it is still understood and short. I'll update it.
sajeev
@sajeevsahadev
Is our ADempiere follow GRPR compliances?
Yamel Senih
@yamelsenih
hi @sajeevsahadev you can see it here: https://github.com/adempiere/adempiere-gRPC-Server/releases
e-Evolution
@e-Evolution
how is GRPR?
Horacio
@piracio
I think we need some clarity, @sajeevsahadev you mean gRPC ? or gdpr security compliance?
sajeev
@sajeevsahadev
Hi @piracio , @yamelsenih , Sorry, its my typing mistake, What I meant is GDPR security compliance.
Horacio
@piracio
To be compliance we need to have a certification and encryption of PII data, I think we are not doing that at the moment ( I May be wrong ), anything that identifies customers needs to be offuscated, for example:
source IP, email, etc.
ID CARDS needs to be encrypted or hashed with SHA256 minimum, after having all this we need to sort an audit to get the certification.
sajeev
@sajeevsahadev
image.png
@piracio we are encrypting only the passwords by default at this moment. In case we have to do that for other columns, I think, we have an option.
Other than the encryption of columns, what all measures we need to take care of? Also, do we need to encrypt all the HR related data as well?
Mario Calderon
@marcalwestf

hello @/all as you may know, the next release (3.9.4) is on February 1st, 2021.

There are some pull requests where we'd need support from community members, like the ones concerning moving to JDK 10 and 11 (adempiere/adempiere#1941 y https://github.com/adempiere/adempiere/pull/2326).

Also helpful would be to test the improvements on Client Account Processor ( adempiere/adempiere#3336)
Thanks in advance for your support.

Yamel Senih
@yamelsenih
hi