Aelve/guide

Matt Renaud

@m-renaud

I don't have a tonne of free time to work on this right now unfortunately, so most of my contributions will probably be style tweaks and improving the docs since those things are easy to do when I have a few spare minutes. @neongreen probably would know best how to add a spell checker

fendor

@fendor

There is editors.widget, so i suppose, that would be a nice start :)

something like https://www.javascriptspellcheck.com/ seems to be helpful

Matt Renaud

@m-renaud

That looks promising :)

Created a couple pull requests for style changes, I noticed that the vue branch is linked to from the "source on github" link on the page so my changes are based off of there, not sure if there's another branch I should be making the changes to.

Artyom Kazak

@neongreen

I’m travelling so I haven’t been paying attention to this chat for a while, but here I’m back

Artyom Kazak

@neongreen

don’t change link colors

I think :visited link colors are useful, but I agree that they should be less messy.

possibly a different font?

This would likely be different for the old frontend and the new frontend (since they have a slightly different feel overall). The old frontend is in maintenance mode now, but I’ll merge and/or bikeshed any incoming PRs :)

invasive colors

The whole “color items by tag” thing was a bad decision — nobody understands how it works and why the colors are different. It’ll just go away.

Artyom Kazak

@neongreen

Also, do you think it would be possible to add some kind of spell checker?

Hm-m, I thought browsers provided that? Apparently there’s a spellcheck=“true” HTML5 option

Once we have user profiles, enabling/disabling it will be an option in the settings.

fendor

@fendor

Hm-m, I thought browsers provided that? Apparently there’s a spellcheck=“true” HTML5 option

I tested that, but it did not work when changed via inspector.
Maybe I have to configure the browser accordingly

Artyom Kazak

@neongreen

Did you add it as an HTML property (by clicking on the node), or as a CSS property? Only the former works

fendor

@fendor

as an HTML property, by editing the node.

Artyom Kazak

@neongreen

Alright, then I guess we’d have to solve it by using a proper editor widget

fendor

@fendor

maybe, i dont know why it does not work.

Artyom Kazak

@neongreen

It doesn’t matter whether it’s the user’s fault or the browser’s fault or Guide’s fault

The philosophy of all current and future Aelve’s projects is that everything is always considered our fault and then we just figure out what to fix first

fendor

@fendor

i suppose that is a healthy attitude for the best user experience

Artyom Kazak

@neongreen

In the particular case of spellchecking, I’m not surprised; even if it’s enabled in HTML the browser is still free to do whatever it wishes and AFAIK there are settings somewhere that control stuff like “default language”, “enable/disable spellchecking”, etc

In Chrome and Firefox they are somewhere in the preferences, in Vivaldi I had to dig into the flags page

fendor

@fendor

I actually checked on firefox, if the spellchecking is enabled, and it is

Artyom Kazak

@neongreen

The section "Guides and tutorials" is that also meant for tutorials to various topics?

I’m not sure, to be honest. Mixing content and links in one section might not be the best idea. Perhaps the “Guides and tutorials” section should be renamed to something like “Original guides and tutorials”, and all other stuff should be linked from respective items

Vladislav Sabanov

@willbasky

@m-renaud hi, your commits deployed!

Matt Renaud

@m-renaud

Awesome! I'll be sending some more PRs today/tomorrow when I have a chance :)

Matt Renaud

@m-renaud

Agreed that the "colours by tag" is confusing at best

Matt Renaud

@m-renaud

Thoughts on using a lighter blue for unvisited links and darker for visited links?
https://imgur.com/a/hBitPrz

Then you still get the visual cue for what you've visited before but its not distracting from the content

fendor

@fendor

That looks like a nice compromise!

Artyom Kazak

@neongreen

When I look at the screenshot I feel like it’s vice-versa

Perhaps let’s steal the exact shades that people are used to, e.g. from https://stackoverflow.com/ (they are similar there but more subtle, I think)

Matt Renaud

@m-renaud

+1 to exact shades people are used to, I just picked random shades of blue

Matt Renaud

@m-renaud

Created #231 (rounded corners) and #232 (link colour)

Matt Renaud

@m-renaud

What browser are you using? Adding spellcheck="true" to the <textarea> tag worked for Chrome desktop

Matt Renaud

@m-renaud

Just added a section on do notation, it still needs a lot of work but one thing I remember being hard when I was learning was a concise explanation of how do notation works with examples. See https://guide.aelve.com/haskell/do-notation-eg3jkvay

fendor

@fendor

Firefox

I really like your explanation of do! However, if you are aiming at beginners, it might be sensible to use more parenthesis instead of $.

Matt Renaud

@m-renaud

Good point about $, I'll change that :)

I'm also a little loose with language in a few spots, like "Read a line of input from the console, the string that is read is returned", while not wrong it isn't exactly correct either since it doesn't return a string, but I couldn't think of better beginner friendly wording. Any suggestions?

Artyom Kazak

@neongreen

Well, the distinction between execution and evaluation (or “IO vs pure functions” for beginners) probably deserves a page of its own, there’s no simple phrasing change that would make it click

Matt Renaud

@m-renaud

Gotcha, I'm going to tweak the wording a little bit but will leave it mostly as is.

Also, what's the status of authentication so that changes can be tracked/attributed. I imagine this would be a good way to audit any spam changes that get made instead of the changes being made anonymously.

Artyom Kazak

@neongreen

Status of authentication: Github auth will be rewritten and merged in at some point, but rewriting the frontend is the first priority.

I expect that the new frontend will become the default in less than a month.

Your PRs for the old frontend will all be merged in and they’ll make the old frontend more pleasant to use for this month, but you might also want to look at the new frontend:

cd front
npm install
npm run start:dev

(and then go to http://locahost:5000)

Matt Renaud

@m-renaud

Neat! I noticed that the content is different in production vs. new frontend, when the switch happens will the most recent production data be used (I'm assuming it will be)?

Artyom Kazak

@neongreen

The new frontend currently pulls the content from staging (for convenience), which runs at http://aelve.com:4801. We reset it to production content every now and then :)

Staging will soon be updated to serve the new frontend, I just haven’t gotten around to that.

(By the way: if anybody wants to get their hands dirty and help me with deployment, I’ll gladly add your key to the server.)

mixailflash

@mixailflash

@m-renaud Hello. Your code in production.

Matt Renaud

@m-renaud

Cool, thanks!

Where communities thrive

People

Repo info

Activity