Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

aerospaceresearch/VisMa

Moved to https://aerospaceresearch.zulipchat.com/#narrow/stream/181873-visma

People

Repo info

Activity

Jan 17 16:55

Pradhansuman3112 commented #241
Jan 17 16:53

spursbyte commented #241
Dec 16 2020 17:55

vieiraroger commented #243
Dec 15 2020 06:20

kabirkedia commented #214
Nov 17 2020 06:41

namanbansalcodes opened #248
Nov 15 2020 19:26

godspeed5 commented #243
Nov 05 2020 05:19

99bcsagar commented #214
Nov 05 2020 05:19

99bcsagar commented #143
Nov 05 2020 05:15

99bcsagar commented #63
Oct 16 2020 14:29

gr8geek commented #241
Oct 14 2020 06:55

Meghana-12 commented #241
Oct 12 2020 14:35

MostafaOmar98 commented #241
Oct 03 2020 18:39

rudrajit1729 commented #241
Aug 27 2020 20:21

vieiraroger commented #244
Aug 15 2020 19:35

mayankDhiman closed #247
Aug 15 2020 19:35

mayankDhiman commented #247
Aug 15 2020 19:33

mayankDhiman closed #246
Aug 15 2020 19:33

mayankDhiman commented #246
Aug 15 2020 19:28

rudrajit1729 commented #247
Aug 13 2020 13:57

rudrajit1729 commented #247

Shantanu Mishra

@8hantanu

If pytest passes that is enough.

Pulkit Mishra

@PulkitMishra

Thanks a lot @8hantanu
I was running pytest but being on Ubuntu it was running on python 2.7 by default.
Those on Ubuntu should run
python3 -m pytest
instead (leaving this here for future reference by potential contributors)

Pulkit Mishra

@PulkitMishra

Review #76 please.

Shantanu Mishra

@8hantanu

👍 for including unit tests

Pulkit Mishra

@PulkitMishra

Thanks @8hantanu
I was writing some more tests though.

Pulkit Mishra

@PulkitMishra

Anyway, I like the project. Will keep on contributing as and when I find time:)

Abhishek Singh

@ZER-0-NE

@PulkitMishra I can't seem to be getting the message Box displayed. Can you check once?
I can still reproduce the same error.

Pulkit Mishra

@PulkitMishra

@ZER-0-NE can you please specify how?

I have tried many cases. Please do let me know in case there's something i might be missing

Kousik Rajesh

@kousikr26

Hello, I found this project interesting and would like to contribute.

Kousik Rajesh

@kousikr26

what is the cause of issue #78 and how do I start?

Shantanu Mishra

@8hantanu

Exponent simplification is currently not supported. You can surely start working on it(go through the visma/simplify/simplify.py module), but for starters I would recommend to go through the code and check off the simple FIXMEs and TODOs you can find in the code. Please refer this before making a PR.

Kousik Rajesh

@kousikr26

Ok sure will start working on it

Kousik Rajesh

@kousikr26

Why does this happen?
alt

Pulkit Mishra

@PulkitMishra

hey @kousikr26 i have only made a few contribution so not really sure but maybe you could try using pdb, step through the code and you will understand what causes this. Code's documentation is excellent to say the least. You'll understand.

Abhishek Singh

@ZER-0-NE

Exponent simplification is currently not supported as @8hantanu mentioned, so it leads to erroneous results I guess.

Shantanu Mishra

@8hantanu

@kousikr26 The terms were differentiated without being simplified. Even then it should have followed the product rule, but it has not been implemented in the calculus module yet, hence the above result. I have fixed the multiplication for now.

This was one of the first coding projects I worked on, so there are many places where the code might seem hacky and might not follow the best practices. I try to fix these things whenever I find some time. :)

Pulkit Mishra

@PulkitMishra

What are you looking for in adding custom equation list?
Are you looking for the facility of adding equations from a file?
Please elaborate.

Shantanu Mishra

@8hantanu

Are you looking for the facility of adding equations from a file?

Yes. I was thinking of adding an option in the menu bar for importing/exporting equations. The option would enable importing the equations from a given equations file into the equation history box.

Shantanu Mishra

@8hantanu

The user should be able to browse and select the file. Same goes for exporting.

Pulkit Mishra

@PulkitMishra

@8hantanu implemented. Check #83
Next, in tester.py you have asked to Categorize all test cases into COVERAGE and BASIS
Don't quite understand. Can you please explain?

Shantanu Mishra

@8hantanu

When I was writing the test cases I thought I would write the minimal tests(BASIS e.g 1 + 1, x*y etc) at one place which would cover most of the code and the (edge)cases (COVERAGE eg. x^2 * yx^3/ x^4 - y), the more complex ones in the other file. Well categorizing it is not of the utmost importance(might as well never do it) but if new test cases can be included in their respective test modules to increase coverage, that'd be great.

If interested in viewing coverage report(line by line coverage of each module) it can be found in htmlcov/ folder after running ./run test

Suyang Chen

@he1l0world

hey. Is anyone woking on this aerospaceresearch/visma#82? If not, can I have a try

Shantanu Mishra

@8hantanu

@he1l0world Sure. Go ahead.

Mayank Dhiman

@mayankDhiman

hey, I want to start contributing to aerospaceresearch.net (want to get started by contributing to Visma). Please help me get started.

Mayank Dhiman

@mayankDhiman

aerospaceresearch/visma#90; small PR, it changes the title of newly added popup browser window from "main.py" to "Wiki" as the second title appears a bit informative. Please review.

Suyang Chen

@he1l0world

hey,@8hantanu I'm not quite sure about this aerospaceresearch/visma#82. I tried to add ScrollArea or ScrollBar but it looks like it can't be issue. Can u guide me with this?

Suyang Chen

@he1l0world

Is that because of the Matplotlib.Canvas

Shantanu Mishra

@8hantanu

hey, I want to start contributing to aerospaceresearch.net (want to get started by contributing to Visma). Please help me get started.

@mayankDhiman Go through this.

Is that because of the Matplotlib.Canvas

@he1l0world Yes it is because of the matplot canvas. It tries to adapt to the current widget size and resizes itself. I too tried to add a scroll bar but there was no option for it in the matplot figure, so I tried to increase the dimension of the canvas and make it scrollable in smaller qwidget but that too didn't work(hence the font settings).

Suyang Chen

@he1l0world

@8hantanu so can we use other widget instead of canvas

Suyang Chen

@he1l0world

I also tried Qslider but didn't know how to connect the action with the canvas

Shantanu Mishra

@8hantanu

Yes you can use other widgets to render latex. I used the canvas as it didn't add any extra dependencies.

Suyang Chen

@he1l0world

okay I will try. Thanks

Suyang Chen

@he1l0world

@8hantanu I tried to use "Add Equations", the program crashed. Here is the details

I would like to add it to issue and try to fix it.

Shantanu Mishra

@8hantanu

Sure. When you add it to the issues could you please elaborate it.

Suyang Chen

@he1l0world

sure

Suyang Chen

@he1l0world

Hey, @8hantanu Can you review this aerospaceresearch/visma#92

Pulkit Mishra

@PulkitMishra

@he1l0world seems like you have some

Pulkit Mishra

@PulkitMishra

issues with git. I could help if you want to

Suyang Chen

@he1l0world

@PulkitMishra Yeah I'll be appreciate if you can help me.

Suyang Chen

@he1l0world

I got git detached when I try to checkout to original/dev branch and I can't push my changes

When i'm trying to push, it will be like this

Suyang Chen

@he1l0world

Abhishek Singh

@ZER-0-NE

@he1l0world try pushing your changes to the local branch 'dev' instead of pushing to the remote branch origin/dev.