Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Adolfo Builes
    @abuiles
    @aexmachina hi
    Simon Wade
    @aexmachina
    Hey there
    Thanks for jumping in
    What I'm confused about is...
    Adolfo Builes
    @abuiles
    no worries
    I'm about to sign off for the day
    but what's the issue?
    Simon Wade
    @aexmachina
    this line seems to me to not add to the registry if the version is not above 0.2.0
    also, I was incorrect in saying that it supports ember-cli versions < 0.2.0 (it was actually npm link not working when I did the test)
    so I'm confused
    what's the intention of the version check in shouldSetupRegistryInIncluded()?
    Adolfo Builes
    @abuiles
    shouldSetupRegistryInIncluded is actually to support versions above 2.0
    so they should work
    Simon Wade
    @aexmachina
    including 0.2.0-beta.1?
    Adolfo Builes
    @abuiles
    no
    0.2.0.beta.1
    will call setupRegister
    Simon Wade
    @aexmachina
    I'm not seeing a setupRegister method
    Adolfo Builes
    @abuiles
    one thing though
    sorry
    setupPreprocessorRegistry
    https://github.com/aexmachina/ember-cli-sass#ember-cli-versions-prior-to-020 is not true, it should come from config/environment.js
    too
    so the release should actually be 4.0
    since the API is changing
    Simon Wade
    @aexmachina
    Okay, right - so is this.project.config(env) available in < 0.2.0?
    Adolfo Builes
    @abuiles
    yes
    Simon Wade
    @aexmachina
    Right okay now I understand
    Adolfo Builes
    @abuiles
    now I have doubts about this.project.config(env) but I believe it is
    I can double check tomorrow
    c
    so I assume it is safe..
    I'll confirm you tomorrow
    (my tomorrow)
    Simon Wade
    @aexmachina
    Yeah okay, I will have to clean this up then
    Cool, thanks I will sort it out
    Adolfo Builes
    @abuiles
    cool
    on the other hand
    I updated a couple of projects
    to use
    ember-cli-sass beta and they are all working fine
    with ember-cli 0.2.0
    :)
    Simon Wade
    @aexmachina
    So final question, on what grounds did you decide to move the config to config\environment. js?
    Adolfo Builes
    @abuiles
    @aexmachina is in the PR :), but check this out http://cl.ly/image/1T3L3l0d1B1w