These are chat archives for airbnb/enzyme

18th
Nov 2017
Edd Yerburgh
@eddyerburgh
Nov 18 2017 17:47
@ljharb how would you respond to people that say adding JSDOM generated browser variables to the global object in node is an anti pattern?
Jordan Harband
@ljharb
Nov 18 2017 21:23
@eddyerburgh what "people"?
i'd say that's really stupid advice, since the whole point of jsdom is to simulate a browser env, and that requires globals being on the global object.
Edd Yerburgh
@eddyerburgh
Nov 18 2017 22:05
Agreed, unfortunately some of my colleagues have found this page in the JSDOM wiki — https://github.com/tmpvar/jsdom/wiki/Don't-stuff-jsdom-globals-onto-the-Node-global. This issue demonstrates that opinion—airbnb/enzyme#507