Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 31 2019 08:18
    FieryCod commented #1379
  • Jan 30 2019 10:01
    atif089 commented #1379
  • Jan 30 2019 10:01
    atif089 commented #1379
  • Jan 30 2019 10:01
    atif089 commented #1379
  • Jan 30 2019 04:11
    tclindner opened #1998
  • Jan 28 2019 05:21

    ljharb on master

    [eslint config] [base] [patch] … [eslint config] [patch] extend … Merge pull request #1996 from r… (compare)

  • Jan 28 2019 05:21
    ljharb closed #1996
  • Jan 28 2019 04:50
    ljharb synchronize #1996
  • Jan 27 2019 21:45
    ljharb closed #1997
  • Jan 27 2019 21:45

    ljharb on master

    [editorial] [react] fix typo [eslint config] [*] [deps] upda… (compare)

  • Jan 27 2019 21:39
    ljharb synchronize #1997
  • Jan 27 2019 21:39
    ljharb labeled #1997
  • Jan 27 2019 21:39
    ljharb labeled #1997
  • Jan 26 2019 18:14
    ljharb labeled #1996
  • Jan 26 2019 18:14
    ljharb labeled #1996
  • Jan 26 2019 18:13
    ljharb synchronize #1996
  • Jan 26 2019 18:05
    ljharb commented #1996
  • Jan 26 2019 08:55
    telmen opened #1997
  • Jan 24 2019 19:37
    peteclark3 commented #1689
  • Jan 24 2019 17:25
    ljharb commented #747
Karma Drukpa
@coderkarma
hello
const addPepperoniToPizza = arr => {
let result = arr.map((ele) => {
        if (arr.indexOf(ele.includes("pepperoni"))) {
            arr.push("pepperoni")
        }
        return ele;
    })
    return result;
}
console.log(addPepperoniToPizza(['onions', 'olives', 'pineapple']));
Any one here..
Jordan Harband
@ljharb
yes, but this is the repo for airbnb's javascript style guide
do you have a question?
(that code is bad btw because you're mutating arr, and worse, you're doing it while you're iterating over it.
)
Ry1xao
@Ry1xao
alien
Mr. Tomtastic Hoffmann
@Bot-Mr-Tomtastic
Does anyone have the guide
?
Btw, what does airbnb have to do with JS?
I thought airbnb was an airline 🙄
Do you guys like write codes for that airline using JS?
Jordan Harband
@ljharb
@Bot-Mr-Tomtastic this guide is how airbnb writes and recommends writing js
and no, its not an airline
Mr. Tomtastic Hoffmann
@Bot-Mr-Tomtastic
Haha ok
Jordan Harband
@ljharb
it's really not that crazy when you consider things like facebook, a social network, makes react
etc
cuanhanshansi
@cuanhanshansi
yeah
mansoorshaik0201
@mansoorshaik0201
has any one used nwjc to convert multiple js files to single bin file
??
Anton Honcharuk
@Ensive
@ljharb
Hello, I've created a PR for one of the recent issues around javascript/react styleguide (bind & arrow functions)
airbnb/javascript#2014 please take a look when you have time
Anton Honcharuk
@Ensive
Thank you for merging my PR. I see that build with last commit is errored on Travis CI. Anything I can help with?
Jordan Harband
@ljharb
@ensive don't worry about errors; in particular if you deleted the branch, the build will error because there's nothing to check out
Anton Honcharuk
@Ensive
@ljharb addressed your review comments in PR: airbnb/javascript#2017
Jordan Harband
@ljharb
thanks
Ghost
@ghost~57cbaf6040f3a6eec0634f49

Heya, I need to replace this object

klass {
  lockScalingX: true,
  lockScalingY: true,
  lockMovementX: true,
  lockMovementY: true,
  originX: 'center',
  originY: 'center',
  centeredRotation: false,
  }

To this

{
  lockScalingX: true,
  lockScalingY: true,
  lockMovementX: true,
  lockMovementY: true,
  originX: 'center',
  originY: 'center',
  centeredRotation: false,
  }

Need to remove klass. How can i do it?

PeachyPeach
@jairadichoso
Hi, can somebody help me with this?
https://stackoverflow.com/questions/51776060/angular-6-breadcrumb-not-working
I'm getting ERROR TypeError: Cannot read property 'breadcrumb' of undefined
Jordan Harband
@ljharb
@dpnashsh that first one isn't valid syntax, so it looks like maybe you're looking at some kind of debug output
however, this is not a general JS help channel; it's for the airbnb javascript style guide.
PeachyPeach
@jairadichoso
chartjs tick label wont show
autoskip:false wont work
Anton Honcharuk
@Ensive
@ljharb
Thank you for merging my PR. I will check on other issues I might be able to resolve.
Let me know if you think I could help with something particular.
spinningcat
@spinningcat
hey
why it exclude firsdt image in second turn and after https://jsfiddle.net/1zmea9yc/1/
Jordan Harband
@ljharb
@ensive np. i think we could use the most help on enzyme and react-dates - the styleguide doesn't tend to need much contributor help :-)
@spinningcat this isn't a general JS help channel, it's for airbnb's javascript styleguide
superchow
@superchow
<code>var a = Date.now()</code>
Ghost
@ghost~57cbaf6040f3a6eec0634f49
Heya, is there any spreadsheet inline editor using angular js which gives an option to copy and paste the whole row or column. There are many others which gives all the features except copy and pasting data in bulk. I have gone through UI-Grid but this feature is not present there. Anyone worked on such stuff????
Gopal Singh
@gopalsingh
how can we resolve CORB Issue in Chrome ??
Bojan Dimitrovski
@bdimitrovski
hi all! would anyone know how background (or background-image) can be transitioned "painlessly" for FF, IE and the likes? it seems ages passed since webkit browsers started supporting this, but still no sign of native support for gecko and the .. ehrm others with the I word :D
Muhammad
@MuhammadJamaluddin
This is my first time using a style guide in my workflow. I was wondering what is the best way to incorporate Airbnb's style guide within my workflow? should I just refer back to the documentation & read the corresponding section or is there a tool/a configuration file that could help (please elaborate & give details)... Thanks in advance.
Jordan Harband
@ljharb
@muhammadjamaluddin add eslint to CI, and prevent merges unless it passes
Muhammad
@MuhammadJamaluddin
I don't get any eslint errors/warnings when I use function declarations or even mix them with function expressions, any idea why?
Jordan Harband
@ljharb
we don't have that rule enabled right now.
Muhammad
@MuhammadJamaluddin
What about the (7.1 functions) section on the Github's documentation?!
& for future reference, how can I know the "currently enabled rules"?
Jordan Harband
@ljharb
not everything in the guide is linted against.
the linting config is a subset of the guide, generally.
Muhammad
@MuhammadJamaluddin
I see. Thank you, Jordan.