airbnb/javascript

JavaScript Style Guide

Muhammad

@MuhammadJamaluddin

and I have babel integrated within the webpack configuration

Jordan Harband

@ljharb

so, that's an eslint/npm bug. are you using latest eslint? if you have a lockfile, have you fully updated it?

Muhammad

@MuhammadJamaluddin

This is the version that got installed by the command eslint": "^6.1.0"

Jordan Harband

@ljharb

try rerunning the install command

Muhammad

@MuhammadJamaluddin

Will do

Muhammad

@MuhammadJamaluddin

same :(

BTW, I am using the VSCode ESlint extension

Jordan Harband

@ljharb

ahhh that's a different thing

run it on the command line

if it only breaks in vscode, it's a vscode bug.

Muhammad

@MuhammadJamaluddin

That makes sense

It does show up in the command line

$ /node_modules/.bin/eslint client/src/index.jsx

C:\Users\Muhammad\Desktop\clash royale\client\src\index.jsx
  11:18  error  Parsing error: Unexpected token =

✖ 1 problem (1 error, 0 warnings)

Jordan Harband

@ljharb

ok, then it's that npm eslint thing

do you have a lockfile?

you could try deleting the lockfile and rerunning npm install

Muhammad

@MuhammadJamaluddin

I do have a package-lock.josn file

Alright, will do...

same...

Jordan Harband

@ljharb

in that case i'm not sure. i've seen that bug occur on some repos but not others

you could try downgrading eslint to v5

Muhammad

@MuhammadJamaluddin

I see, how can I do that?

Jordan Harband

@ljharb

npm install --save-dev eslint@5

Muhammad

@MuhammadJamaluddin

Thanks, Jordan ❤️

I really appreciate your help...

Muhammad

@MuhammadJamaluddin

Oh, just solved it :D

Jordan Harband

@ljharb

what was it?

Muhammad

@MuhammadJamaluddin

I found this answer:
https://stackoverflow.com/questions/36001552/eslint-parsing-error-unexpected-token

I did exactly what he said & it worked

Jordan Harband

@ljharb

that's a hack tho

eslint can certainly parse it

it's just that the wrong parser version is being used

Muhammad

@MuhammadJamaluddin

I see, will go with that in the meantime... is that something that could be resolved from your side?

Jordan Harband

@ljharb

Igor Gassmann

@IGassmann

Hey y'all! How do you guys handle the class-methods-use-this error when implementing methods of an inherited class? The method can't be transformed as a static one.

Jordan Harband

@ljharb

you’d use an override comment.

Igor Gassmann

@IGassmann

Would that break any of the guide rules? I wasn't able to find the relative guide rule in http://airbnb.io/javascript/

Jordan Harband

@ljharb

no, it’s fine

Igor Gassmann

@IGassmann

Alright, I opened this then https://github.com/eslint/eslint/issues/12390#issuecomment-539712898

ajay yadav

@ajay7868

anyone help how to get a folder path when i browse any folder

Shak Daniel

@shakdaniel

Anyone knows how to test a ternary operator using Jest? Ex…

return ( 
  <div>
    <div onClick={toggleCtrl.setOpen}>Toggle</div>
    { !isOpen ? <h1>Hide</h1> : <h1>Show</h1> }
  </div>
);

Jordan Harband

@ljharb

@shakdaniel has nothing to do with jest. have one test with isOpen truthy, and another with it falsy.

Dominika Bieder

@dominikabieder

CALLING ALL JUNIOR and SENIOR DEVS

Hi 👋 I’m researching the topic of
JUNIOR DEVS: challenges when working on a new project,
SENIOR DEVS: challenges when working with code written by someone else

and your feedback/rant would help a lot!

You can share your thoughts with me via survey:

JUNIORS: https://www.surveymonkey.de/r/contribution-new-project-2
SENIORS: https://www.surveymonkey.de/r/code-challenges-3

Big thanks,
Dominika