Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Ruud Welling
    @WellingR
    Added some review comments
    Renato Cavalcanti
    @renatocaval
    @WellingR I see you merged my lasted PR, but was the release triggered?
    Ruud Welling
    @WellingR
    No not yet. I will do this tonight
    Renato Cavalcanti
    @renatocaval
    ok, thanks. Ping me if possible. We have a Lagom release on the pipeline
    Ruud Welling
    @WellingR
    The release has been pushed to bintray, however @dnvriend should trigger the sync to maven central, hopefully he has the time to do this soon
    Renato Cavalcanti
    @renatocaval
    ok, thanks
    Ruud Welling
    @WellingR
    The sync to maven has been triggered
    It seems that the artifact is available
    Dmitriy Zakomirnyi
    @dmi3zkm
    hi guys!
    How can I decode journal messages from database to human readable format?
    Ruud Welling
    @WellingR
    There is no real easy way to do this
    Perhaps the easiest way to see the messages is to use the akka-persistence-query api
    Which means converting the data in the db back to events and logging that as part of a stream
    Renato Cavalcanti
    @renatocaval
    we have this ongoing idea, but unfortunately nobody is working on this yet.
    https://github.com/lagom/lagom/issues/1009#issuecomment-376823022
    the ideal situation is not to have it in Lagom, but something more generic that can be used outside Lagom as well
    Dmitriy Zakomirnyi
    @dmi3zkm
    @renatocaval @WellingR
    Actually, I recover actors in my tests using production db replica to see persisted events. Just was curious if there is a better way.
    Anyway, many thanks for your help.
    Ruud Welling
    @WellingR
    @renatocaval I have created a 4.0.0 milestone which labels issues which can only be solved by chaning the database schema
    One of the issues is an open PR, the other is the tag issue with the LIKE query.
    Renato Cavalcanti
    @renatocaval
    ok, thanks
    Renato Cavalcanti
    @renatocaval
    @WellingR I will merge @ktoso PR
    he made the changes you requested except the AnyRef to Any thing
    I will check with him later, but I don't think is a blocker for now
    Konrad `ktoso` Malawski
    @ktoso
    the any / anyref dance is about which one we value I guess, afair in persistence protocols it is AnyRefs isnt it?
    thanks; let’s keep moving things forward there
    Ruud Welling
    @WellingR
    I am okay with merging this. I personally thought Any was the better choice because some of the current persistence APIs use Any already. However we can leave it as is, and change it to Any if we ever run into trouble
    Konrad `ktoso` Malawski
    @ktoso
    I can have a second look at it later… thanks
    Ruud Welling
    @WellingR
    For migrations (see e.g. dnvriend/akka-persistence-jdbc#188) a query api (like eventsByTag, but without tag) which can return all events would make sense. I have considered adding such a query before. What do you guys think about this?
    Ruud Welling
    @WellingR
    @renatocaval dnvriend/akka-persistence-jdbc#194 seems to be an issue for lagom
    I have committed a branch with my work in progress changes where I store the tags in a separate table, but I had some trouble getting the tests green again. Also I fear that the insert performance will suffer.
    It might be worth investigating if tags can be stored using an Array or Jsonb list, not sure if all our database types support this though
    Renato Cavalcanti
    @renatocaval
    we will check it, I'm lagging behind with everything jdbc related
    your other PR is still waiting for a final review, sorry about that
    array and jsonb is only supported in postgres, as far as I can tell
    it would be nice to use jsonb to store the events payloads when using postgres, as a opt-in feature
    not sure if it will have better performance for the tags though
    Ruud Welling
    @WellingR
    It seems that h2 supports the Array type (but not json), oracle supports Array and Json, and mysql supports json but not arrays
    We still need to investigate if it is possible to create an index for the array or json array, since it makes no sense to use it if it is not possible
    I am considering to implement a configuration possibility for how tags are stored. Easy to implement options are "separated" (which is what we have now), "single-tag" (which allows no more than one tag per event).
    Later on, we could see if we can implement the "array" or "json" / "jsonb" options
    Renato Cavalcanti
    @renatocaval
    sounds a good plan @WellingR
    maybe you can open a PR for it already and we use it to discuss it further?
    Ruud Welling
    @WellingR
    Done
    Renato Cavalcanti
    @renatocaval
    hey @WellingR, finally did some updates on dnvriend/akka-persistence-jdbc#191
    add a warning when logical deletes are enabled and used
    not so convinced if best approach, let me know what you think
    tomorrow, I'm travelling to Amsterdam to speak at the Scala User group
    I will try to review dnvriend/akka-persistence-jdbc#191 on the train
    Ruud Welling
    @WellingR
    I took a quick look, but I need some more time to look at it later
    Ruud Welling
    @WellingR
    @renatocaval I have not heard from James for a while. Do you agree with merging dnvriend/akka-persistence-jdbc#180 to the 4.x.x branch? I can open separate issues for the open PR comments
    Dmitriy Zakomirnyi
    @dmi3zkm

    hi, team!
    There are a number of min/max connections related configs in reference.conf.

    # 5 * number of cores
          numThreads = 20
    
          # number of threads
          maxConnections = 20
    
          # number of threads
          minConnections = 20

    Do you know where that "magick" number 5 comes from ?

    Renato Cavalcanti
    @renatocaval
    @WellingR, sorry, somehow I missed your message here