These are chat archives for akkadotnet/AkkaStreams

10th
Jun 2016
Chris Constantin
@cconstantin
Jun 10 2016 15:07
This message was deleted
@Silv3rcircl3 changed my mind re RELEASE_NOTES
see my latest comment :)
Marc Piechura
@marcpiechura
Jun 10 2016 15:08
:-)
Chris Constantin
@cconstantin
Jun 10 2016 15:10
going over the tck now
Marc Piechura
@marcpiechura
Jun 10 2016 15:11
👍
Chris Constantin
@cconstantin
Jun 10 2016 15:16
no need for Optional and Some?
Marc Piechura
@marcpiechura
Jun 10 2016 15:31
I needed optional and a bunch of other classes like AtomicCounter, they are all in the Reactive.Streams.Util project
But now when I'm thinking about it, I could also move them into the examples project
Chris Constantin
@cconstantin
Jun 10 2016 15:33
yeah, sounds cleaner to me
should we call it Optional instead of Option, to match jvm?
also, how do you feel about starting the verification rules method names with an upppercase, to match .net conventions?
Bartosz Sypytkowski
@Horusiath
Jun 10 2016 15:40
@cconstantin leave Britney Option alone! Java is the only language with such strange name
Chris Constantin
@cconstantin
Jun 10 2016 15:40
ok :) not feeling too strongly about it
report in IntelliJ: “190 tests done: 87 ignored"
in VS/RS: “102 success, 419 ignored"
guessing there’s one tests that should have been run
@Silv3rcircl3 not very clear to me how this whole ignoring of tests works, but I can go through the list and check we’re running all tests that have been run on the jvm side
Marc Piechura
@marcpiechura
Jun 10 2016 15:51
What's not clear in that area? :-)
Chris Constantin
@cconstantin
Jun 10 2016 15:56
:)
btw, after the tck is pushed up, I guess we’ll want to run it with akka streams?
Chris Constantin
@cconstantin
Jun 10 2016 16:02
public void required_spec109_mustIssueOnSubscribeForNonNullSubscriber_mustFailIfOnErrorHappensFirst() throws Throwable {
Missing for PublisherVerificationTest
All the other tests seem to match OK
you good with all those changes @Silv3rcircl3? If not, I can help over the weekend, but we should decide how to split the work
Marc Piechura
@marcpiechura
Jun 10 2016 16:15
I'm currently a bit busy, if you want you can start with some task and tell me what's left, but I think I could also do it over the weekend so both is fine for me ;)
Chris Constantin
@cconstantin
Jun 10 2016 16:17
ok, I’ll let you know if/when I start working on some of it
Marc Piechura
@marcpiechura
Jun 10 2016 20:30
@cconstantin have you also checked the example tests? Are they matching the jvm numbers?
Chris Constantin
@cconstantin
Jun 10 2016 21:02
no, let me take a look
Chris Constantin
@cconstantin
Jun 10 2016 21:08
this appears to be missing optional_spec111_multicast_mustProduceTheSameElementsInTheSameSequenceToAllOfItsSubscribersWhenRequestingOneByOne
in IterablePublisherTest