These are chat archives for akkadotnet/AkkaStreams

24th
Jun 2016
Chris Constantin
@cconstantin
Jun 24 2016 14:35
@Silv3rcircl3 nope, sry
@Silv3rcircl3 any idea how to include .net portable in the reactive-streams package?
Marc Piechura
@marcpiechura
Jun 24 2016 15:46
Nop haven't used .net portable at all
Chris Constantin
@cconstantin
Jun 24 2016 15:47
I’m guessing it’s a matter of proper targeting in the fake script
Chris Constantin
@cconstantin
Jun 24 2016 16:14
@Silv3rcircl3 pushed the changes here alignedsolutions/reactive-streams-dotnet@05ca8b1
would you mind including it with the current PR?
(it’s a different fork than before)
Marc Piechura
@marcpiechura
Jun 24 2016 16:36
I hope I can do it in around 3 hours
Chris Constantin
@cconstantin
Jun 24 2016 16:36
thanks, appreciated
Marc Piechura
@marcpiechura
Jun 24 2016 16:37
Np
Chris Constantin
@cconstantin
Jun 24 2016 16:37
I’m hoping David Karnok can actually confirm the changes to the right thing
if not, I’ll have to figure out how to test myself
Chris Constantin
@cconstantin
Jun 24 2016 16:59
David says it’s all good
I’ve pushed another commit, to generate and include the xml documentation
Marc Piechura
@marcpiechura
Jun 24 2016 17:03
Nice :+1:
Marc Piechura
@marcpiechura
Jun 24 2016 20:16
@cconstantin updated the PR with your changes
Chris Constantin
@cconstantin
Jun 24 2016 20:16
thanks
Marc Piechura
@marcpiechura
Jun 24 2016 20:46
man Vitkor really wants to keep this PR open as long as possible :)
Chris Constantin
@cconstantin
Jun 24 2016 20:50
seems like it :)