These are chat archives for akkadotnet/AkkaStreams

11th
Jul 2016
Bartosz Sypytkowski
@Horusiath
Jul 11 2016 06:25 UTC
@Silv3rcircl3 yes I know. But we're limited in man hours we can spent on...
tbh I'd rather like to see new akka.io, ddata and .net core support first
we'll be chasing jvm tail anyway
also there are still a big black holes - it would be great to see some service discovery for akka (ServiceFabric, Consul and Zookeeper are first things that comes to my mind)
Bartosz Sypytkowski
@Horusiath
Jul 11 2016 06:33 UTC
personally, I think we could wait with upgrading streams to point, when lightbend guys will settle on arterty implementation - this way we'll know that what we have ported will be enough to implement new remoting layer
Marc Piechura
@marcpiechura
Jul 11 2016 06:35 UTC
Alright, Akka.IO and .net core is already in progress, so is someone working on DData? I have probably some free hours before I switch to a new company so I could work on something
Bartosz Sypytkowski
@Horusiath
Jul 11 2016 06:36 UTC
@maxim-s told he's working on it, but I don't know how his progress is
I think we could setup new channel for ddata
making working groups dedicated to specific parts of akka worked really great so far
and more people can participate in that
Arjen Smits
@Danthar
Jul 11 2016 06:37 UTC
who is working on akka.io ?
Marc Piechura
@marcpiechura
Jul 11 2016 06:38 UTC
akkadotnet/akka.net#2108
Bartosz Sypytkowski
@Horusiath
Jul 11 2016 06:39 UTC
this is very hard task IMO, hard to get right, hard to measure performance
Arjen Smits
@Danthar
Jul 11 2016 06:41 UTC
Alot of the lessons learned from improving helios could be applied here as well
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 08:35 UTC
@Horusiath someone has already started DData one year ago in this branch https://github.com/akkadotnet/akka.net/commits/ddata
Marc Piechura
@marcpiechura
Jul 11 2016 08:37 UTC
The current work is done on maxims fork https://github.com/maxim-s/akka.net/tree/distributed-data?files=1 looks like he has already done most of the work
Maxim Salamatko
@maxim-s
Jul 11 2016 09:01 UTC
@Silv3rcircl3 actually I haven't done a lot :) still can't get replication in multi node
but looks like issues in Test Transport, I'll check with Helios transport
Marc Piechura
@marcpiechura
Jul 11 2016 09:04 UTC
ah I see, @bruinbrown has done most of the work
but it seems that most of the classes are already there
Maxim Salamatko
@maxim-s
Jul 11 2016 09:05 UTC
yes
Marc Piechura
@marcpiechura
Jul 11 2016 09:06 UTC
let me know if you need some help
Maxim Salamatko
@maxim-s
Jul 11 2016 09:06 UTC
ok thank you
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 09:09 UTC
@Horusiath why we need the new modules in the master branch, while we have beta versions of Persistence, Cluster.Tools, Cluster.Sharding and Streams?
Bartosz Sypytkowski
@Horusiath
Jul 11 2016 09:13 UTC
??
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 09:13 UTC
ddata
Bartosz Sypytkowski
@Horusiath
Jul 11 2016 09:13 UTC
are you asking why are we working on ddata?
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 09:14 UTC
About priorities
We need this module, but our current modules has more priority
Bartosz Sypytkowski
@Horusiath
Jul 11 2016 09:14 UTC
cluster.tools and cluster.sharding are still in beta even on jvm
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 09:15 UTC
No
I don't see "experimental" here
Konrad `ktoso` Malawski
@ktoso
Jul 11 2016 09:17 UTC
uhm, distributed-data is not sharding
sharding is sharding :)
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 09:17 UTC
Only Ddata and Akka.Http Dsl in "experimental" stage
Konrad `ktoso` Malawski
@ktoso
Jul 11 2016 09:17 UTC
uhm, not only but I'm not sure what you're asking
Bartosz Sypytkowski
@Horusiath
Jul 11 2016 09:18 UTC
@ktoso we're talking about why work on ddata, while we still haven't released so many production modules into production ready state
Konrad `ktoso` Malawski
@ktoso
Jul 11 2016 09:18 UTC
oh i see
ddata is relatively stable from our end btw
not planning any big changes there
// if that helps in your planning
Bartosz Sypytkowski
@Horusiath
Jul 11 2016 09:19 UTC
@alexvaluyskiy ddata port has been started a year ago, it would be nice to have it before it will rot to the bone
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 10:26 UTC
For example I need this PR to be implemented to support NetCore: akka/akka#19701
Because they replaced Thread.Yield to something else
This PR from 2.4.3 version
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 10:33 UTC
@Silv3rcircl3 why Akka.Streams.Tests.TCK uses NUnit for tests, instead of Xunit2?
Marc Piechura
@marcpiechura
Jul 11 2016 10:37 UTC
Because XUnit can only skip tests via attribute, but I needed a way to skip tests at runtime depending on different properties
p
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 10:38 UTC
Ok
But I see xunit packages also
I have problems with than on NetCore
Can't have two testrunners in a project
Bartosz Sypytkowski
@Horusiath
Jul 11 2016 10:40 UTC
@Silv3rcircl3 couldn't we just copy-paste tests variants that rely on this runtime flag?
Marc Piechura
@marcpiechura
Jul 11 2016 10:40 UTC
I needed XUnit because I reference Akka.Streams.Tests or Teskit which use xunit
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 10:43 UTC
So, you don't use xunit test runner in this project
Am I right?
Marc Piechura
@marcpiechura
Jul 11 2016 10:45 UTC
@Horusiath all tests are inside the Reactive.Streams.TCK package, in Akka.Streams.TCK we simply inherit from the verification classes and provide the implementation as well as the environment, for example if you want to test a empty publisher you set the MaxElementsFromPublisher property to 0 zero, that way all tests that require elements are skipped at runtime
@alexvaluyskiy yup
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 10:46 UTC
that is fine for NetCore
Marc Piechura
@marcpiechura
Jul 11 2016 10:46 UTC
great :)
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 10:48 UTC

Akka.Tests.Shared.Internals has AkkaSpec class
Akka.Streams.TestKit.Tests has another AkkaSpec class

Akka.Streams.Tests has dependency on these projects. And dotnet CLI could not compile it

Why Akka.Streams.Tests uses Akka.Streams.TestKit.Tests? I think it should have a reference only on Akka.Streams.TestKit project
Marc Piechura
@marcpiechura
Jul 11 2016 13:49 UTC
@alexvaluyskiy that was the structure on the jvm in version 2.4.2, in the current master branch they switched to a single AkkaSpec class
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 14:06 UTC
I cannot convert Akka.Streams.Tests to NetCore while it has a reference to Akka.Streams.TestKit.Tests project
Marc Piechura
@marcpiechura
Jul 11 2016 14:18 UTC
What's the problem with Teskit.Tests?
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 14:19 UTC

this one

Why Akka.Streams.Tests uses Akka.Streams.TestKit.Tests? I think it should have a reference only on Akka.Streams.TestKit project

Marc Piechura
@marcpiechura
Jul 11 2016 14:22 UTC
So you can't port Teskit.Tests to core and that affects Streams.Tests?
Don't understand why this simple reference is an issue for donet cli
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 14:23 UTC
all tests projects have a target netcoreapp1.0. And one netcoreapp1.0 could not target another netcoreapp1.0. I don't know why
Marc Piechura
@marcpiechura
Jul 11 2016 14:26 UTC
interesting :) I can look into it and see if we can merge those two AkkaSpec classes together and remove the reference
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 14:27 UTC
@Horusiath if we want to have all akka JVM modules here. We should have a dedicated person, or a team for each module. Who will be responsible for syncing (or just track a change and create an issue in github) all changes from Akka JVM version
I'm doing this work for Cluster and Cluster.Tools. AkkaStreams team should do the same for Streams and Akka.Persistence.Query modules. We should not switch to another module only after RTM. Otherwise we get non-working modules, like ClusterClient
Marc Piechura
@marcpiechura
Jul 11 2016 15:40 UTC
@alexvaluyskiy Silv3rcircl3/akka.net@022f460 it compiles now,
do we really need these xunit runners as direct dependency for the project?
but this hole .net core thing is a pain in the ass with my current setup here :)
Marc Piechura
@marcpiechura
Jul 11 2016 15:48 UTC
If you really need the coreapp support then you need to add a runtime section to project.json and then it should work as well as reference
Alex Valuyskiy
@alexvaluyskiy
Jul 11 2016 16:44 UTC
How you can run tests if you don't have a dependency on xunit runner?\
Bartosz Sypytkowski
@Horusiath
Jul 11 2016 16:53 UTC
@alexvaluyskiy I never promised cluster tools to work ;) I've never managed finish test specs for them
and there was no help to make Multi node tests working back them (even MNTK itself felt a little broken)
Marc Piechura
@marcpiechura
Jul 11 2016 17:14 UTC
@alexvaluyskiy I thought it would work the same way as before with fake, but I have seen why you needed the coreapp target, will continue on it later
Marc Piechura
@marcpiechura
Jul 11 2016 20:23 UTC
So it's not only AkkaSpec we would need to move all classes except the four *Specs into Akka.Streams.Teskit,
will try tomorrow to fix the reference problem if that's not working we need to move these classes