These are chat archives for akkadotnet/AkkaStreams

12th
Jul 2016
Alex Valuyskiy
@alexvaluyskiy
Jul 12 2016 07:22
Akka.Streams.Tests.Performance also has references to Akka.Streams.Tests, Akka.Streams.TestKit.Tests and to Akka.TestKit.Xunit2.
Marc Piechura
@marcpiechura
Jul 12 2016 07:26
yup, but I fixed the reference problem and currently running the Akka.Streams.Tests so it shouldn't be a problem
Marc Piechura
@marcpiechura
Jul 12 2016 08:22
@alexvaluyskiy here we go, Silv3rcircl3/akka.net@c7483c1 one spec is consistently failing, don't know why
Alex Valuyskiy
@alexvaluyskiy
Jul 12 2016 08:30
@Silv3rcircl3 could you run tests in our branch?
Marc Piechura
@marcpiechura
Jul 12 2016 08:41
Akka.Streams.Tests.Dsl.FlowFlattenMergeSpec.A_FlattenMerge_must_cancel_substreams_when_failing_map_function is failing, the other four are passing
but it is possible that the others are also failing if you run all tests at once inside visual studio
we don't know why but this only happens when you run them all at once in visual studio, it doesn't happen if you run them separately or all via command line
Alex Valuyskiy
@alexvaluyskiy
Jul 12 2016 08:44
I can't run them in VS. Tests just disappeared after I've added the second target (netcore)
Marc Piechura
@marcpiechura
Jul 12 2016 08:45
have you added the additional dependency to xunit runners?
Alex Valuyskiy
@alexvaluyskiy
Jul 12 2016 08:45
I run tests like that "dotnet test -f net451" or "dotnet test -f netcoreapp1.0"
Do you mean xunit.runner.visualstudio?
Alex Valuyskiy
@alexvaluyskiy
Jul 12 2016 08:48
But dotnet-test-xunit works fine if I have only net45 target. And it worked fine for both targets in the previos version
Marc Piechura
@marcpiechura
Jul 12 2016 08:49
Mh I don't know, I needed to add this additional package to get it working within visual studio
interesting, now it is working even without the xunit.runner.console package
Alex Valuyskiy
@alexvaluyskiy
Jul 12 2016 11:17
@Silv3rcircl3 NetCore changes are growing so fast. Right now it is almost 3500 lines. So, I'm planning to create PR with GetType().GetTypeInfo()/Exceptions/Dispose->Close changes, merge them to the dev branch, and rebase my own branch after that. Could you help me with that and do the same for Streams?
Marc Piechura
@marcpiechura
Jul 12 2016 12:25
@alexvaluyskiy I'm not sure if we want to merge these changes already in dev. My proposal would be to discuss it tomorrow on the contributors meeting.