These are chat archives for akkadotnet/AkkaStreams

9th
Sep 2016
Alex Valuyskiy
@alexvaluyskiy
Sep 09 2016 10:58
@Silv3rcircl3 the file "Keep.cs" is not working on coreclr build
because coreclr doesn't have MethodBase.MethodHandle property
Bartosz Sypytkowski
@Horusiath
Sep 09 2016 11:01
@alexvaluyskiy we can replace it if needed, it's just the quickest way to check equality of two methods
Alex Valuyskiy
@alexvaluyskiy
Sep 09 2016 20:19
@Horusiath it would be good
@Silv3rcircl3 is it possible to do something with Keep class?
Marc Piechura
@marcpiechura
Sep 09 2016 20:34
If there is a equivalent on coreclr, sure
Alex Valuyskiy
@alexvaluyskiy
Sep 09 2016 20:38
I don't know
Is there another way to compare methods?
Marc Piechura
@marcpiechura
Sep 09 2016 20:39
Haven't looked into it and tbh it's at the end of my list, want to bring streams up to date and then try to make it coreclr ready
If that's the only blocker besides the thread part I could add the thread part with 2.4.5 and you could rewrite Keep and you're good to go
Alex Valuyskiy
@alexvaluyskiy
Sep 09 2016 20:44
what the thread part?
You have already fixed the thread part
here akkadotnet/akka.net#2198
Marc Piechura
@marcpiechura
Sep 09 2016 20:46
yeah right, I was confused with your message on the 2.4.9 PR but that was only to bring these changes into dev
Forgot that I already fixed it ;-)
Alex Valuyskiy
@alexvaluyskiy
Sep 09 2016 20:52
:)
Marc Piechura
@marcpiechura
Sep 09 2016 21:58
lol I should have looked two commits ahead
akka/akka#20454
akka/akka#20468