These are chat archives for akkadotnet/AkkaStreams

19th
Sep 2018
Bartosz Sypytkowski
@Horusiath
Sep 19 2018 06:05
@vasily-kirichenko afaik you should be able to OfferAsync from multple threads. There should be even a max degree of supported parallelism somewhere: this is also expressed in returned value (Enqueued|Dropped|Failure|QueueClosed).
In the past I've already said, that this is bad design for .NET - it should be ValueTask<bool> OfferAsync(T element) which returns true on enqueued, false on dropped, while failure and queue closed should return a failed task (i.e. ObjectDisposedException on closed queue).
Vasily Kirichenko
@vasily-kirichenko
Sep 19 2018 06:44
@Horusiath I think it should not be async at all.
What are you gonna do if it returns false? If it's back pressured, Offer should just block.
or, if it's async, .Wait() should block definitely, until queue is ready to get the element.
AndreSteenbergen
@AndreSteenbergen
Sep 19 2018 15:57
I agree with Vasily but I am uncertain of the implications that will have.
AndreSteenbergen
@AndreSteenbergen
Sep 19 2018 16:30
I am pushing a Kafka pr in a moment, with configurable sending of EOF's in a wrapped message. I have it running in Acc environment and working as a charm. If anyone could have a peek that would be great.
AndreSteenbergen
@AndreSteenbergen
Sep 19 2018 17:09
@alexvaluyskiy Could you have a look? as the original coder?
Vasily Kirichenko
@vasily-kirichenko
Sep 19 2018 18:59
@AndreSteenbergen have you looked at the jvm alpakka’s kafka source impl? Do they have such a feature?