These are chat archives for akkadotnet/akka.net

25th
Mar 2015
jcwrequests
@jcwrequests
Mar 25 2015 00:01
@nvivo I gave up on that stuff a long time ago and started using embedded text files for things like configuration and sql queries. If you were using VB.NET you could also use XML literals to solve the problem of readability. Anyway who needs specs :smile: .
Stefan Sedich
@stefansedich
Mar 25 2015 00:04
I went with base config in web.config and some overrides it seems to work nicely.
Roger Johansson
@rogeralsing
Mar 25 2015 04:34
I have to check that, URI's are case sensitive according to spec, dunno about akka behavior in JVM
Stefan Sedich
@stefansedich
Mar 25 2015 05:54
yeah right, didn't think the host was case sensitive though?
"the scheme and host are case-insensitive and therefore should be normalized to lowercase. For example, the URI HTTP://www.EXAMPLE.com/ is equivalent to http://www.example.com/."
Roger Johansson
@rogeralsing
Mar 25 2015 05:58
ah, a bug on our side then
Stefan Sedich
@stefansedich
Mar 25 2015 05:58
I am happy to fix it, I will create an issue and take it on.
Roger Johansson
@rogeralsing
Mar 25 2015 06:00
:+1:
Stefan Sedich
@stefansedich
Mar 25 2015 06:19
ok cool created akkadotnet/akka.net#750 will get it done soon!
ah damn can't assign to myself?
Roger Johansson
@rogeralsing
Mar 25 2015 06:39
Should be possible, Ill look into team settings
Stefan Sedich
@stefansedich
Mar 25 2015 07:39
I could just be blind :D
Stefan Sedich
@stefansedich
Mar 25 2015 07:44
@rogeralsing do you think the system should be case insensitive too on an Address?
same as protocol
Stefan Sedich
@stefansedich
Mar 25 2015 07:50
yeah cool system name is case sensitive in JVM missed that one.
Roger Johansson
@rogeralsing
Mar 25 2015 07:58
@stefansedich I found the problem, you were not in any of the access groups, added you. you should be able to assign the task now
Stefan Sedich
@stefansedich
Mar 25 2015 07:59
sweet
yeah cool found the issue, there are tests around the casing of a hostname when using ActorSelection which are fine as that parses into a Uri and gets the host which gets lower cased for us.
the HeliosTransport creates the Address instance but does not lowercase.
easy fix should be just to always lower case the host when creating an Address instance to be safe.
Stefan Sedich
@stefansedich
Mar 25 2015 08:10
how adverse are we to the boilerplate comments on things like this?
/// <summary>
/// Gets the host.
/// </summary>
I would rather remove them for cleanliness.
Roger Johansson
@rogeralsing
Mar 25 2015 08:11
Ye, I'm to blame for most of them, had a period of Ghost doccing everything in my way :P
Stefan Sedich
@stefansedich
Mar 25 2015 08:11
hehe yeah gathered it was ghost doc
Roger Johansson
@rogeralsing
Mar 25 2015 08:11
just remove if they are nonsense
Stefan Sedich
@stefansedich
Mar 25 2015 08:12
coolies I will give Address some love
my 1 line change made me feel bad have to do something useful
//TODO: conform to WithXYZ convention for each value?
public Address Copy(string protocol = null, string system = null, string host = null, int? port = null)
{
return new Address(protocol ?? Protocol, system ?? System, host ?? Host, port ?? Port);
}
@rogeralsing any insight on that TODO?
Roger Johansson
@rogeralsing
Mar 25 2015 08:14
yes, every other primitive has a WithSomething, WithSomethingElse method that builds new immutable copies with just that field changed.. and Address only have a Copy method that can change any field.. sort of inconsistent with the rest of the api imo
Stefan Sedich
@stefansedich
Mar 25 2015 08:15
yeah ok that makes sense
will go ahead and make that change, what is the convention for the Copy on it's own then?
that is used in a few places
Stefan Sedich
@stefansedich
Mar 25 2015 08:25
Copy() it is, I better go get some dinner into me, will get this done tonight/tomorrow.
Roger Johansson
@rogeralsing
Mar 25 2015 10:22
As Address is immutable, copy makes no sense if not changing any values
There was previously a bug where address was mutable, but that has been fixed, so no need for copy()
Stefan Sedich
@stefansedich
Mar 25 2015 21:49
morning gents/gentettes
Aaron Stannard
@Aaronontheweb
Mar 25 2015 21:49
hey dude
Stefan Sedich
@stefansedich
Mar 25 2015 21:52
what is the deal to actually run tests locally without stack overflows?
have not had much luck running the suite.
Aaron Stannard
@Aaronontheweb
Mar 25 2015 22:03
hahaha.... upgrading XUnit :(
2.0 RTM is out now, but I don't know if any of us have tried upgrading to it yet
since we had a lot of trouble with the release candidates
Stefan Sedich
@stefansedich
Mar 25 2015 22:04
heh ok, my r# is boned can't see any extensions I had just been running with build.bat RunTests for now.
Aaron Stannard
@Aaronontheweb
Mar 25 2015 22:04
lol
love it when that happens
Stefan Sedich
@stefansedich
Mar 25 2015 22:04
I see one extension in the available list
such selection
Aaron Stannard
@Aaronontheweb
Mar 25 2015 23:22
@stefansedich I'm not going to be able to take on the Mono build server for the next couple of days - have some Akka.NET v1.0 deliverables I need to finish first :p
I'll try to get that done ASAP though
Stefan Sedich
@stefansedich
Mar 25 2015 23:23
too easy
as soon as you can get me access let me know I will spin it all up and get it working next week.
Aaron Stannard
@Aaronontheweb
Mar 25 2015 23:35
sounds good buddy
Stefan Sedich
@stefansedich
Mar 25 2015 23:38
has anyone here done any work on a kafka consumer?