Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 14:40
    cptjazz synchronize #3974
  • 14:07
    cptjazz opened #3974
  • 08:30
    ismaelhamed commented #3937
  • Oct 12 15:50
    IrvinDominin opened #127
  • Oct 11 18:21
    Aaronontheweb commented #3973
  • Oct 11 18:20
    Aaronontheweb commented #3937
  • Oct 11 18:16
    Zetanova commented #3937
  • Oct 11 18:11
    Zetanova commented #3937
  • Oct 11 15:09
    Aaronontheweb commented #3937
  • Oct 11 15:08
    Aaronontheweb commented #3937
  • Oct 11 14:36
    Aaronontheweb commented #3973
  • Oct 11 01:00
    Horusiath commented #3057
  • Oct 10 20:02
    IgorFedchenko synchronize #3973
  • Oct 10 19:59
    IgorFedchenko synchronize #3973
  • Oct 10 19:58
    IgorFedchenko commented #3973
  • Oct 10 19:53
    IgorFedchenko opened #3973
  • Oct 10 14:04
    stijnherreman commented #3057
  • Oct 10 13:54
    Aaronontheweb commented #3970
  • Oct 10 13:54
    Aaronontheweb synchronize #3970
  • Oct 10 10:10
    Zetanova commented #3937
Aaron Stannard
@Aaronontheweb
it's going to follow Netty's design much more closely than the current version
(Akka.Cluster will ship after Akka.NET 1.0 is released)
Roger Johansson
@rogeralsing
Aaron, we should take a look if that was just my naive testcase or if it is a real issue
Aaron Stannard
@Aaronontheweb
if you have some bits that you can send me i can take a look
if it's a Helios issue then I know exactly where the problem is
it's the LengthFrameDecoder
either it or the ByteBuf sitting on top of it grabs only a partial chunk of a message
coffeeyesplease
@coffeeyesplease
yeah, I try and find the test
Aaron Stannard
@Aaronontheweb
the decoder reads some bytes that aren't actually the length-frame header
assumes the message is corrupt
and discards bytes until the buffer is empty
coffeeyesplease
@coffeeyesplease
it as basically sending logs messages the around. 128 len string
Aaron Stannard
@Aaronontheweb
it's possible that there's some race conditions I never caught with the reactive part of the socket
Roger Johansson
@rogeralsing
Found their test, mailed you
Aaron Stannard
@Aaronontheweb
thanks
I'll take a look at that
I've had a spec written down on paper, quite literally - in my notebook, for Helios 2.0 and I'm desperate to work on it because I think it'll finally be easy to work directly with Helios once I've made those changes :p
Helios' current API is simple but not the most intuitive
Aaron Stannard
@Aaronontheweb
@rogeralsing btw, have virtual nodes and all of that fun stuff implemented now
had to rewrite our Murmur3 implementation in order to support it
(followed the Scala implementation - it wasn't so different from mine, just optimized for being able to construct a hash in discrete steps)
(rather than treating it like a black-box all-or-nothing operation)
Roger Johansson
@rogeralsing
Nice :)
Roger Johansson
@rogeralsing
@Horusiath are you by any chance an old WoW gamer? from the looks of your alias :)
Aaron Stannard
@Aaronontheweb
@/all Unit2 for Akka.NET bootcamp is now available ;) https://github.com/petabridge/akka-bootcamp/tree/master/src/Unit-2
jcwrequests
@jcwrequests
@aaronontheweb the boot camp looks awesome. I will be adding it to my personal work load for the coming week. Good job 👍
Aaron Stannard
@Aaronontheweb
thanks @jcwrequests! We still have unit 3 to come yet but that'll be a ways off - unit 2 covered a lot of stuff, especially for folks who want to do WinForms / WPF / client programming with Akka.NET
jcwrequests
@jcwrequests
@Aaronontheweb Thanks again for sending the information on Resizer with Routing. The only problem is I can not figure out how to hook up the resizer to a ConsistentHashingGroup. The example you provided with with round robins. Any advice?
Aaron Stannard
@Aaronontheweb
Resizers only work with ConsistentHashingPool :p
group routers don't manage their routees
however, for turning on a resizer with consistent hashing pools
let me see if I can find a config example for that - about to head out but I'm in the middle of updating all of the consistent hashing routers now
brought them up to code with JVM akka, includes fun stuff like virtual nodes
jcwrequests
@jcwrequests
Okay got it. I will check that out. It should be fun once I get it hooked up to my eventstore with aggregates.
Once I get that done I may see if I have any Azure time left at work and try a stress test. My small Asus Ultra slim with an i5 is not the best for that sort of thing. Thanks again. I am will talk to you soon. Signing off here on the east coast.
One last thing I am blogging all about this experience so I may ping you with some research questions. Cheers and have a good one.
Håkan Canberger
@HCanber
I'm seeing PR:s (like #689 and #691) with no explanation to why they are submitted. I think A PR should at least have a sentence or two explaining why the changes are being made and what the changes are, even if it's only white space changes. In the case of #689 several bugs were introduced. An explanation to why the changes were made could have saved me some time, instead I had to decipher what was done, and trying to figure out why it had been changed. Thoughts?
Bartosz Sypytkowski
@Horusiath
@rogeralsing yep, old times ;)
Roger Johansson
@rogeralsing
Håkan, to get the community onboard, the more interest the better, and even if a PR is just ws, if it makes the code cleaner, why not? And regarding the child stats bug, thats on us if we dont have test coverage for it, the intended behavior cant just be in someones head. We do need more tests, and now we found a place where we could improve it.
Bartosz Sypytkowski
@Horusiath
we need to fix this damn test suite, I've got all the configurations of passing/failing tests, depending on FAKE test run, Resharper (with different configs) and maybe even phases of the moon
since tests are failing randomly for any reason
Roger Johansson
@rogeralsing
Threads run slower during fullmoon, dont you know? :P
Håkan Canberger
@HCanber
@rogeralsing Just to be clear, I'm not blaming the contributor, it's all on us. For not having tests, for not reviewing properly. As we know we don't have tests for everything, we have to be very restrictive when accepting PR:s in the core, and review everything thoroughly.
Håkan Canberger
@HCanber
I'm not saying we should stop small PR:s, just saying PR's should contain something that in short says what's been done, and why.
Rodrigo Vidal
@rodrigovidal
@HCanber Sorry about the PRs without description, they were supposed to be refactorings, so I thought they were self explaining. I'll try to do it right next time.
Aaron Stannard
@Aaronontheweb
@Horusiath my theory on why the tests fail is that we're using, on purpose, relatively small Azure VMs - the smallest 2-core instance I could find
I picked that size for the build server because that's the sort of VM I'd expect a basic Akka.NET application to run on on Azure
on my build machine the entire test suite passes pretty reliably most of the time, although some of the same tests that fail on the build server occasionally fail here too but way less often
err, development machine :p - giant Asus gaming laptop with 4 intel core i7s
I think the stuff that fails is either inherently racy or we're running into some system resource issue that causes tests with realtime constraints (i.e. expect message within 3 seconds) to timeout