Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 14:03

    Aaronontheweb on dev

    Bump Microsoft.Extensions.Depen… (compare)

  • 14:03

    Aaronontheweb on nuget

    (compare)

  • 14:03
    Aaronontheweb closed #5142
  • 13:39
    dependabot[bot] synchronize #5142
  • 13:39

    dependabot[bot] on nuget

    Bump Microsoft.Extensions.Depen… (compare)

  • 13:39
    dependabot[bot] edited #5142
  • 13:38
    dependabot[bot] edited #5142
  • 13:38

    Aaronontheweb on nuget

    (compare)

  • 13:38

    Aaronontheweb on dev

    Bump Microsoft.Data.SQLite from… (compare)

  • 13:38
    Aaronontheweb closed #5141
  • 13:31
    dependabot[bot] synchronize #5142
  • 13:31

    dependabot[bot] on nuget

    Bump Microsoft.Extensions.Depen… (compare)

  • 13:31
    dependabot[bot] edited #5142
  • 13:31
    dependabot[bot] synchronize #5141
  • 13:31

    dependabot[bot] on nuget

    Bump Microsoft.Data.SQLite from… (compare)

  • 13:30
    dependabot[bot] edited #5141
  • 13:30
    dependabot[bot] edited #5142
  • 13:30
    dependabot[bot] edited #5141
  • 13:30

    Aaronontheweb on dev

    SBR fix & update (#5147) * con… (compare)

  • 13:30
    Aaronontheweb closed #5147
Bartosz Sypytkowski
@Horusiath
@HCanber did you started to work with CircuitBreaker yet - I've created some general purpose CircuitBreaker with support for async code, non-locking state switching and test suite
maybe it could be usefull
Bartosz Sypytkowski
@Horusiath
it's available here - maybe I'll write a blog post about it
jcwrequests
@jcwrequests
@Horusiath Writing a post would be a good idea. The code looks really interesting and it would cool to see how you came up with your implementation. If I where in the Poland I would buy you a cold beer 🍺 and we could discuss it but a post will do.😊
Aaron Stannard
@Aaronontheweb
@jcwrequests here's an example of NrOfInstances:
common-router-settings = {
                        router = consistent-hashing-pool
                        nr-of-instances = 10
                        cluster {
                            enabled = on
                            max-nr-of-instances-per-node = 2
                        }
                    }
(from my latest PR)
jcwrequests
@jcwrequests
Thanks @Aaronontheweb . I am getting a strange symptom with this config. If I don't specify var pool = new ConsistentHashingPool(config);
pool.NrOfInstances = 10;
pool.NrOfInstances = 10 in the code is does not function. Shouldn't just specifying in the config be enough or am I am missing something?
Aaron Stannard
@Aaronontheweb
hmmm
not sure
I changed all of that stuff in my latest PR
rewrote consistent hashing routers from scratch basically
so I can't remember how the old stuff is supposed to function :p
however, it should work
jcwrequests
@jcwrequests
Let me rephrase that if I don't add the pool.NrOfInstances = 10 in the code is does not function but it I do it works fine. Seems like something is not correct. Here is what I have
akka.actor.deployment {
        /router1 {
           router = consistent-hashing-pool
                    nr-of-instances = 10
                    cluster {
                        enabled = on
                        max-nr-of-instances-per-node = 2
                    }

            }
Aaron Stannard
@Aaronontheweb
ahhh, this is with clustered consistent hashing pools?
jcwrequests
@jcwrequests
Yup
Aaron Stannard
@Aaronontheweb
haha.... yeah, that was a fun bug to fix: akkadotnet/akka.net#707
I rewrote all of the ActorOf methods in order to make that work
because they didn't properly chain configs
in that PR they will
should have that merged in soon unless someone sees something they don't like
it's big so I'll give it a couple more days
jcwrequests
@jcwrequests
No problem. Just wanted to be sure I was not going crazy.
Aaron Stannard
@Aaronontheweb
no, you're not
I experienced the same problem
when I was working with them
jcwrequests
@jcwrequests
Otherwise they have been really simple to setup and test.
Aaron Stannard
@Aaronontheweb
glad to hear it!
jcwrequests
@jcwrequests
They work perfectly with the IOC extensions.
Aaron Stannard
@Aaronontheweb
that reminds me, btw - did you get a chance to see this issue about IOC? akkadotnet/akka.net#706
err, DI
jcwrequests
@jcwrequests
Nope. I will take a look.
Aaron Stannard
@Aaronontheweb
ty sir
jcwrequests
@jcwrequests
Actually I brought this up in the google group before I started the project.
Because Props controls everything there is no way to implement a proper release strategey.
Aaron Stannard
@Aaronontheweb
yeah, I seem to recall that
It's a common problem with frameworks. I believe early editions of MVC had the same issue.
Aaron Stannard
@Aaronontheweb
I think we added IDisposable support for actors since
which @Horusiath mentions in his answer
not ideal because it's explicit
but still, something
really all three of @Horusiath's strategies are good ones
I thought about using the actor construction pipeline for tackling that, so I'm glad he brought it up
jcwrequests
@jcwrequests
It's probably a problem as well on the JVM side and since Akka.net is based on it that baggage came along with it.
Aaron Stannard
@Aaronontheweb
yeah
I have no idea how they do DI
jcwrequests
@jcwrequests
The same way. I based my code on the implementation.