Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 20 23:30

    Aaronontheweb on dev

    added ability to support custom… (compare)

  • Sep 20 23:30
    Aaronontheweb closed #3923
  • Sep 20 23:30
    Aaronontheweb closed #3861
  • Sep 20 23:26
    Aaronontheweb opened #3923
  • Sep 20 23:01
    Aaronontheweb commented #3922
  • Sep 20 22:59
    Aaronontheweb closed #3890
  • Sep 20 22:59
    Aaronontheweb commented #3890
  • Sep 20 22:58
    Aaronontheweb synchronize #3922
  • Sep 20 22:58
    Aaronontheweb opened #3922
  • Sep 20 22:21
    Aaronontheweb commented #3905
  • Sep 20 22:21

    Aaronontheweb on dev

    Fixed Akka.Remote.ResendUnfulfi… (compare)

  • Sep 20 22:21
    Aaronontheweb closed #3914
  • Sep 20 22:21
    Aaronontheweb closed #3905
  • Sep 20 21:07
    Aaronontheweb milestoned #3921
  • Sep 20 21:07
    Aaronontheweb labeled #3921
  • Sep 20 21:07
    Aaronontheweb labeled #3921
  • Sep 20 20:53
    spankr opened #3921
  • Sep 20 18:52
    ismaelhamed commented #3811
  • Sep 20 17:42
    Aaronontheweb commented #3879
  • Sep 20 17:39
    Aaronontheweb commented #3887
Aaron Stannard
@Aaronontheweb
I changed all of that stuff in my latest PR
rewrote consistent hashing routers from scratch basically
so I can't remember how the old stuff is supposed to function :p
however, it should work
jcwrequests
@jcwrequests
Let me rephrase that if I don't add the pool.NrOfInstances = 10 in the code is does not function but it I do it works fine. Seems like something is not correct. Here is what I have
akka.actor.deployment {
        /router1 {
           router = consistent-hashing-pool
                    nr-of-instances = 10
                    cluster {
                        enabled = on
                        max-nr-of-instances-per-node = 2
                    }

            }
Aaron Stannard
@Aaronontheweb
ahhh, this is with clustered consistent hashing pools?
jcwrequests
@jcwrequests
Yup
Aaron Stannard
@Aaronontheweb
haha.... yeah, that was a fun bug to fix: akkadotnet/akka.net#707
I rewrote all of the ActorOf methods in order to make that work
because they didn't properly chain configs
in that PR they will
should have that merged in soon unless someone sees something they don't like
it's big so I'll give it a couple more days
jcwrequests
@jcwrequests
No problem. Just wanted to be sure I was not going crazy.
Aaron Stannard
@Aaronontheweb
no, you're not
I experienced the same problem
when I was working with them
jcwrequests
@jcwrequests
Otherwise they have been really simple to setup and test.
Aaron Stannard
@Aaronontheweb
glad to hear it!
jcwrequests
@jcwrequests
They work perfectly with the IOC extensions.
Aaron Stannard
@Aaronontheweb
that reminds me, btw - did you get a chance to see this issue about IOC? akkadotnet/akka.net#706
err, DI
jcwrequests
@jcwrequests
Nope. I will take a look.
Aaron Stannard
@Aaronontheweb
ty sir
jcwrequests
@jcwrequests
Actually I brought this up in the google group before I started the project.
Because Props controls everything there is no way to implement a proper release strategey.
Aaron Stannard
@Aaronontheweb
yeah, I seem to recall that
It's a common problem with frameworks. I believe early editions of MVC had the same issue.
Aaron Stannard
@Aaronontheweb
I think we added IDisposable support for actors since
which @Horusiath mentions in his answer
not ideal because it's explicit
but still, something
really all three of @Horusiath's strategies are good ones
I thought about using the actor construction pipeline for tackling that, so I'm glad he brought it up
jcwrequests
@jcwrequests
It's probably a problem as well on the JVM side and since Akka.net is based on it that baggage came along with it.
Aaron Stannard
@Aaronontheweb
yeah
I have no idea how they do DI
jcwrequests
@jcwrequests
The same way. I based my code on the implementation.
Aaron Stannard
@Aaronontheweb
nice
well in that case, it's a buyer-beware thing for akka.net
just like akka
and frankly I think that's an ok place to start
as nice as it would be to have automatic scoping for releasing injected resources
might not be feasible atm
jcwrequests
@jcwrequests
What would be nice if we could pass a lambda to the actor system that could be used by the supervisor to release references. Basically that is all that is really needed.
Aaron Stannard
@Aaronontheweb
hmmmm
you know
THAT might be doable