@skotzko I just took a quick look. I see the part about the void PostStop() but that is something that needs to be implemented by the actor. What I am look for is more about the internals. So Props creates instances I need to have some hook to do releases of the actor created using my IOC contrib. All the someone should have to do is wire up the IOC container and then let Akka do the rest. Regardless the information is very helpful so thanks.
@Aaronontheweb @skotzko I think within the ActorCell specifically private void FinishTerminate() might be able to call a release method on Props. In Fact I think Props should have a Release method or expose the IndirectActorProducer where having the Release method makes most sense. I believe that was what you were referring to the last time we chatted.
you can also try this, which I've been in love with lately: https://dotnetfiddle.net/
@Aaronontheweb thanks for the link I will check it out. Today I was thinking that it actually may make a good blog post. Currently I am trying to keep a cadence of a new post every two weeks and right now I am a little off track and this would be the perfect thing to talk about since it's what my current focus is. @stefansedich thanks for offer I might take you up on it. I already have some preliminary thoughts down on paper which I know will work but what I am trying to do is minimize any impact to the core framework.
@stefansedich it looks like from your LinkedIn Profile you do AutoFac which would definitely come in handy since my IOC of choice is Castle WIndsor. Since my IOC contrib is being reworked it may be worth while to also find a way to validate the container to ensure that all registred actors are using the proper life cycle, like transient. I know it's something that is fairly easy to do in Castle but I am not sure about the other IOC containers. It's not something that is absolutely necessary but it help keep users on the happy path.
with autofac the props will need to work a bit differently I think
we should resolve an Owned<T>
and then later dispose that owned so that we release things properly.
Autofac container does not have anything like a release method.
or create a LifetimeScope and keep track of that inside the props, then when you call Props.Dispose() dispose that LifetimeScope
Sounds good to me. I am basing this on a great post that I read by the author of Dependency Injection for .Net Mark Seemann.
Either way I think the abstraction that I have in mind will work in both cases. Obviously the implementations will be different.
I would go ahead and start and what I can do is try and get my notes up on github or google docs and I will send you a link. It really seems like it should be fairly easy to accomplish but it will require some changes to the Props object and the IndirectActorProducer interface to work properly.
I am in the future
it is nice here
If you want to hit me up on linkedIn feel free or on email. I usually check those during the day.
Good I will talk to you soon. Signing off.
Stay Cool
I'm going to document it this week with an architecture diagram and some other stuff and once that's done you'll see it in https://github.com/petabridge/akkadotnet-code-samples
I'm also using pre-release Akka.NET bits which I still need to check into the repo in order for local builds to run :p
@stefansedich @Aaronontheweb I just wrote a quick (blog post)[http://www.message-flow.com/2015/03/ioc-contrib-design-flaw.html] in regards to my proposal. At the very least @stefansedich it will provide you with something to start by. Starting tomorrow I will synch my fork of Akka with the head and start coding up what I proposed and give it a test run with what I currently have. @Aaronontheweb I would like to add some tests where would be a good point in the repo to do so? Talk to you guys soon. Signing off..
best place to add a new repo for doing tests will be in the
/contrib folder
we can create test project for DI there
FAKE should be able to automatically discover it in the test runner if you follow the naming convention we use for the other test assemblies - just making sure the project name ends with .Tests