Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 21:02
    Aaronontheweb synchronize #3975
  • 21:02
    Aaronontheweb opened #3975
  • 20:11
    IgorFedchenko commented #3973
  • 20:10
    IgorFedchenko synchronize #3973
  • 20:06
    IgorFedchenko synchronize #3973
  • 20:06
    IgorFedchenko synchronize #3973
  • 19:42
    IgorFedchenko edited #3973
  • 18:08
    Aaronontheweb commented #3937
  • 17:27
    Aaronontheweb commented #90
  • 17:26
    Aaronontheweb commented #90
  • 17:25
    Aaronontheweb assigned #90
  • 17:16

    Aaronontheweb on dev

    Provide static GetRoutees.Insta… (compare)

  • 17:16
    Aaronontheweb closed #3974
  • 17:16
    Aaronontheweb milestoned #3974
  • 16:05
    jackowild opened #90
  • 15:08
    Aaronontheweb commented #3974
  • 15:08
    Aaronontheweb commented #3974
  • Oct 13 14:40
    cptjazz synchronize #3974
  • Oct 13 14:07
    cptjazz opened #3974
  • Oct 13 08:30
    ismaelhamed commented #3937
Roger Johansson
@rogeralsing
Even if two by two?
Possibly the threadpool is saturated, but that shouldnt be visible with a few tests at a time
Stefan Sedich
@stefansedich
should hostname casing matter? If I try use akka.tcp://import@foo:9998/user/foo
and my helios tcp hostname is FOO
the host will drop the message
Natan Vivo
@nvivo
@rogeralsing, I based that on the HOCON page that states "a JSON superset, that is, all valid JSON should be valid and should result in the same in-memory data that a JSON parser would have produced."
single quotes are not part of json spec?
wow.. that got me
it really isn't. who would have thought? =)
Natan Vivo
@nvivo
@rogeralsing nevermind. I agree, stick to the specs.
if only we read them... =)
Stefan Sedich
@stefansedich
that got me too yesterday @nvivo
jcwrequests
@jcwrequests
@nvivo I gave up on that stuff a long time ago and started using embedded text files for things like configuration and sql queries. If you were using VB.NET you could also use XML literals to solve the problem of readability. Anyway who needs specs :smile: .
Stefan Sedich
@stefansedich
I went with base config in web.config and some overrides it seems to work nicely.
Roger Johansson
@rogeralsing
I have to check that, URI's are case sensitive according to spec, dunno about akka behavior in JVM
Stefan Sedich
@stefansedich
yeah right, didn't think the host was case sensitive though?
"the scheme and host are case-insensitive and therefore should be normalized to lowercase. For example, the URI HTTP://www.EXAMPLE.com/ is equivalent to http://www.example.com/."
Roger Johansson
@rogeralsing
ah, a bug on our side then
Stefan Sedich
@stefansedich
I am happy to fix it, I will create an issue and take it on.
Roger Johansson
@rogeralsing
:+1:
Stefan Sedich
@stefansedich
ok cool created akkadotnet/akka.net#750 will get it done soon!
ah damn can't assign to myself?
Roger Johansson
@rogeralsing
Should be possible, Ill look into team settings
Stefan Sedich
@stefansedich
I could just be blind :D
Stefan Sedich
@stefansedich
@rogeralsing do you think the system should be case insensitive too on an Address?
same as protocol
Stefan Sedich
@stefansedich
yeah cool system name is case sensitive in JVM missed that one.
Roger Johansson
@rogeralsing
@stefansedich I found the problem, you were not in any of the access groups, added you. you should be able to assign the task now
Stefan Sedich
@stefansedich
sweet
yeah cool found the issue, there are tests around the casing of a hostname when using ActorSelection which are fine as that parses into a Uri and gets the host which gets lower cased for us.
the HeliosTransport creates the Address instance but does not lowercase.
easy fix should be just to always lower case the host when creating an Address instance to be safe.
Stefan Sedich
@stefansedich
how adverse are we to the boilerplate comments on things like this?
/// <summary>
/// Gets the host.
/// </summary>
I would rather remove them for cleanliness.
Roger Johansson
@rogeralsing
Ye, I'm to blame for most of them, had a period of Ghost doccing everything in my way :P
Stefan Sedich
@stefansedich
hehe yeah gathered it was ghost doc
Roger Johansson
@rogeralsing
just remove if they are nonsense
Stefan Sedich
@stefansedich
coolies I will give Address some love
my 1 line change made me feel bad have to do something useful
//TODO: conform to WithXYZ convention for each value?
public Address Copy(string protocol = null, string system = null, string host = null, int? port = null)
{
return new Address(protocol ?? Protocol, system ?? System, host ?? Host, port ?? Port);
}
@rogeralsing any insight on that TODO?
Roger Johansson
@rogeralsing
yes, every other primitive has a WithSomething, WithSomethingElse method that builds new immutable copies with just that field changed.. and Address only have a Copy method that can change any field.. sort of inconsistent with the rest of the api imo
Stefan Sedich
@stefansedich
yeah ok that makes sense
will go ahead and make that change, what is the convention for the Copy on it's own then?
that is used in a few places
Stefan Sedich
@stefansedich
Copy() it is, I better go get some dinner into me, will get this done tonight/tomorrow.
Roger Johansson
@rogeralsing
As Address is immutable, copy makes no sense if not changing any values
There was previously a bug where address was mutable, but that has been fixed, so no need for copy()