Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 14:40
    cptjazz synchronize #3974
  • 14:07
    cptjazz opened #3974
  • 08:30
    ismaelhamed commented #3937
  • Oct 12 15:50
    IrvinDominin opened #127
  • Oct 11 18:21
    Aaronontheweb commented #3973
  • Oct 11 18:20
    Aaronontheweb commented #3937
  • Oct 11 18:16
    Zetanova commented #3937
  • Oct 11 18:11
    Zetanova commented #3937
  • Oct 11 15:09
    Aaronontheweb commented #3937
  • Oct 11 15:08
    Aaronontheweb commented #3937
  • Oct 11 14:36
    Aaronontheweb commented #3973
  • Oct 11 01:00
    Horusiath commented #3057
  • Oct 10 20:02
    IgorFedchenko synchronize #3973
  • Oct 10 19:59
    IgorFedchenko synchronize #3973
  • Oct 10 19:58
    IgorFedchenko commented #3973
  • Oct 10 19:53
    IgorFedchenko opened #3973
  • Oct 10 14:04
    stijnherreman commented #3057
  • Oct 10 13:54
    Aaronontheweb commented #3970
  • Oct 10 13:54
    Aaronontheweb synchronize #3970
  • Oct 10 10:10
    Zetanova commented #3937
Roger Johansson
@rogeralsing
I have to check that, URI's are case sensitive according to spec, dunno about akka behavior in JVM
Stefan Sedich
@stefansedich
yeah right, didn't think the host was case sensitive though?
"the scheme and host are case-insensitive and therefore should be normalized to lowercase. For example, the URI HTTP://www.EXAMPLE.com/ is equivalent to http://www.example.com/."
Roger Johansson
@rogeralsing
ah, a bug on our side then
Stefan Sedich
@stefansedich
I am happy to fix it, I will create an issue and take it on.
Roger Johansson
@rogeralsing
:+1:
Stefan Sedich
@stefansedich
ok cool created akkadotnet/akka.net#750 will get it done soon!
ah damn can't assign to myself?
Roger Johansson
@rogeralsing
Should be possible, Ill look into team settings
Stefan Sedich
@stefansedich
I could just be blind :D
Stefan Sedich
@stefansedich
@rogeralsing do you think the system should be case insensitive too on an Address?
same as protocol
Stefan Sedich
@stefansedich
yeah cool system name is case sensitive in JVM missed that one.
Roger Johansson
@rogeralsing
@stefansedich I found the problem, you were not in any of the access groups, added you. you should be able to assign the task now
Stefan Sedich
@stefansedich
sweet
yeah cool found the issue, there are tests around the casing of a hostname when using ActorSelection which are fine as that parses into a Uri and gets the host which gets lower cased for us.
the HeliosTransport creates the Address instance but does not lowercase.
easy fix should be just to always lower case the host when creating an Address instance to be safe.
Stefan Sedich
@stefansedich
how adverse are we to the boilerplate comments on things like this?
/// <summary>
/// Gets the host.
/// </summary>
I would rather remove them for cleanliness.
Roger Johansson
@rogeralsing
Ye, I'm to blame for most of them, had a period of Ghost doccing everything in my way :P
Stefan Sedich
@stefansedich
hehe yeah gathered it was ghost doc
Roger Johansson
@rogeralsing
just remove if they are nonsense
Stefan Sedich
@stefansedich
coolies I will give Address some love
my 1 line change made me feel bad have to do something useful
//TODO: conform to WithXYZ convention for each value?
public Address Copy(string protocol = null, string system = null, string host = null, int? port = null)
{
return new Address(protocol ?? Protocol, system ?? System, host ?? Host, port ?? Port);
}
@rogeralsing any insight on that TODO?
Roger Johansson
@rogeralsing
yes, every other primitive has a WithSomething, WithSomethingElse method that builds new immutable copies with just that field changed.. and Address only have a Copy method that can change any field.. sort of inconsistent with the rest of the api imo
Stefan Sedich
@stefansedich
yeah ok that makes sense
will go ahead and make that change, what is the convention for the Copy on it's own then?
that is used in a few places
Stefan Sedich
@stefansedich
Copy() it is, I better go get some dinner into me, will get this done tonight/tomorrow.
Roger Johansson
@rogeralsing
As Address is immutable, copy makes no sense if not changing any values
There was previously a bug where address was mutable, but that has been fixed, so no need for copy()
Stefan Sedich
@stefansedich
morning gents/gentettes
Aaron Stannard
@Aaronontheweb
hey dude
Stefan Sedich
@stefansedich
what is the deal to actually run tests locally without stack overflows?
have not had much luck running the suite.
Aaron Stannard
@Aaronontheweb
hahaha.... upgrading XUnit :(
2.0 RTM is out now, but I don't know if any of us have tried upgrading to it yet
since we had a lot of trouble with the release candidates
Stefan Sedich
@stefansedich
heh ok, my r# is boned can't see any extensions I had just been running with build.bat RunTests for now.
Aaron Stannard
@Aaronontheweb
lol
love it when that happens
Stefan Sedich
@stefansedich
I see one extension in the available list
such selection
Aaron Stannard
@Aaronontheweb
@stefansedich I'm not going to be able to take on the Mono build server for the next couple of days - have some Akka.NET v1.0 deliverables I need to finish first :p
I'll try to get that done ASAP though
Stefan Sedich
@stefansedich
too easy