Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Dec 14 19:13
    hwanders commented #4096
  • Dec 14 13:05
    IgorFedchenko commented #4085
  • Dec 14 03:08
    hhko commented #4094
  • Dec 13 21:37
    Aaronontheweb commented #4085
  • Dec 13 20:28
    IgorFedchenko commented #4085
  • Dec 13 20:27
    IgorFedchenko commented #4085
  • Dec 13 15:38
    Aaronontheweb labeled #4096
  • Dec 13 15:38
    Aaronontheweb milestoned #4096
  • Dec 13 15:38
    Aaronontheweb labeled #4096
  • Dec 13 15:38
    Aaronontheweb opened #4096
  • Dec 13 10:41
    peirens-bart opened #4095
  • Dec 13 08:37
    Aaronontheweb synchronize #4071
  • Dec 13 08:13
    jiyeongj opened #4094
  • Dec 12 15:42
    Aaronontheweb synchronize #4086
  • Dec 12 15:42
    Aaronontheweb closed #4083
  • Dec 12 15:42

    Aaronontheweb on dev

    Fix #4083 - Endpoint receive bu… (compare)

  • Dec 12 15:42
    Aaronontheweb closed #4089
  • Dec 12 15:42
    Aaronontheweb labeled #4093
  • Dec 12 15:42
    Aaronontheweb labeled #4093
  • Dec 12 15:42
    Aaronontheweb labeled #4093
Stefan Sedich
@stefansedich
I could just be blind :D
Stefan Sedich
@stefansedich
@rogeralsing do you think the system should be case insensitive too on an Address?
same as protocol
Stefan Sedich
@stefansedich
yeah cool system name is case sensitive in JVM missed that one.
Roger Johansson
@rogeralsing
@stefansedich I found the problem, you were not in any of the access groups, added you. you should be able to assign the task now
Stefan Sedich
@stefansedich
sweet
yeah cool found the issue, there are tests around the casing of a hostname when using ActorSelection which are fine as that parses into a Uri and gets the host which gets lower cased for us.
the HeliosTransport creates the Address instance but does not lowercase.
easy fix should be just to always lower case the host when creating an Address instance to be safe.
Stefan Sedich
@stefansedich
how adverse are we to the boilerplate comments on things like this?
/// <summary>
/// Gets the host.
/// </summary>
I would rather remove them for cleanliness.
Roger Johansson
@rogeralsing
Ye, I'm to blame for most of them, had a period of Ghost doccing everything in my way :P
Stefan Sedich
@stefansedich
hehe yeah gathered it was ghost doc
Roger Johansson
@rogeralsing
just remove if they are nonsense
Stefan Sedich
@stefansedich
coolies I will give Address some love
my 1 line change made me feel bad have to do something useful
//TODO: conform to WithXYZ convention for each value?
public Address Copy(string protocol = null, string system = null, string host = null, int? port = null)
{
return new Address(protocol ?? Protocol, system ?? System, host ?? Host, port ?? Port);
}
@rogeralsing any insight on that TODO?
Roger Johansson
@rogeralsing
yes, every other primitive has a WithSomething, WithSomethingElse method that builds new immutable copies with just that field changed.. and Address only have a Copy method that can change any field.. sort of inconsistent with the rest of the api imo
Stefan Sedich
@stefansedich
yeah ok that makes sense
will go ahead and make that change, what is the convention for the Copy on it's own then?
that is used in a few places
Stefan Sedich
@stefansedich
Copy() it is, I better go get some dinner into me, will get this done tonight/tomorrow.
Roger Johansson
@rogeralsing
As Address is immutable, copy makes no sense if not changing any values
There was previously a bug where address was mutable, but that has been fixed, so no need for copy()
Stefan Sedich
@stefansedich
morning gents/gentettes
Aaron Stannard
@Aaronontheweb
hey dude
Stefan Sedich
@stefansedich
what is the deal to actually run tests locally without stack overflows?
have not had much luck running the suite.
Aaron Stannard
@Aaronontheweb
hahaha.... upgrading XUnit :(
2.0 RTM is out now, but I don't know if any of us have tried upgrading to it yet
since we had a lot of trouble with the release candidates
Stefan Sedich
@stefansedich
heh ok, my r# is boned can't see any extensions I had just been running with build.bat RunTests for now.
Aaron Stannard
@Aaronontheweb
lol
love it when that happens
Stefan Sedich
@stefansedich
I see one extension in the available list
such selection
Aaron Stannard
@Aaronontheweb
@stefansedich I'm not going to be able to take on the Mono build server for the next couple of days - have some Akka.NET v1.0 deliverables I need to finish first :p
I'll try to get that done ASAP though
Stefan Sedich
@stefansedich
too easy
as soon as you can get me access let me know I will spin it all up and get it working next week.
Aaron Stannard
@Aaronontheweb
sounds good buddy
Stefan Sedich
@stefansedich
has anyone here done any work on a kafka consumer?
Stefan Sedich
@stefansedich
Say I am listening to a terminated child to be able to fail a parent process, how does one get information on why that child died? should a child be sending a message to the parent upon termination? can I hook into that by any chance?
Stefan Sedich
@stefansedich
I want to know why my child died to be able to update a record that my parent keeps track of, say it is an AWS exception I want to update with "file not found" for example.
Roger Johansson
@rogeralsing
@stefansedich protected override void PreRestart(Exception reason, object message) should work?
or you mean before termination?
David Smith
@smalldave
@Aaronontheweb looking at restartnodespec. it downs one system and then brings up another but on the same port. this isn't working. the new system seems to work fine but the cluster leader can't send InitJoinAck to the new system so it never joins. I've tracked it down to the endpointwriter on the cluster leader for the new systems (and presumably the old systems) endpoint. it never changes message handler from Initialized and just keeps buffering the message. Any guess what is happening here? Is the endpoint writer likely to be the endpoint writer for the first system that has been shutdown. Should this matter?
David Smith
@smalldave
@Aaronontheweb ignore all that