by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 09:59
    mika76 commented #3323
  • 09:58
    mika76 commented #3323
  • 09:56
    revoltez commented #3323
  • 09:45
    revoltez commented #3323
  • 09:41
    revoltez commented #3323
  • 09:06
    mika76 commented #3323
  • 09:06
    mika76 commented #3323
  • 09:04
    revoltez commented #3323
  • 06:58
    Swoorup commented #4419
  • 02:01
    Arkatufus synchronize #4531
  • Aug 03 22:42

    Aaronontheweb on dev

    Minor fix to the automatic pass… (compare)

  • Aug 03 22:42
    Aaronontheweb closed #4536
  • Aug 03 22:42
    Aaronontheweb labeled #4536
  • Aug 03 14:18
    ismaelhamed opened #4536
  • Aug 03 07:37
    Swoorup commented #4419
  • Aug 01 18:10
    Aaronontheweb commented #4535
  • Jul 31 20:38
    Arkatufus synchronize #4534
  • Jul 31 19:08
    Zetanova commented #4533
  • Jul 31 16:29
    Arkatufus synchronize #4531
  • Jul 31 16:22
    Arkatufus synchronize #4534
Aaron Stannard
@Aaronontheweb
BECAUSE I BELIEEEEEEEEEEEEEEEEVE
Joshua Benjamin
@annymsMthd
@Aaronontheweb awesome!
Aaron Stannard
@Aaronontheweb
@annymsMthd oh god man
there are issues in this thing
going way back
I just found this gem
public bool HasWriteableEndpointFor(Address address)
        {
           return WritableEndpointWithPolicyFor(address) != null;
        }
technically, this means a quarantined node is considered "writeable"
total amount of time this code has been in Akka.Remote with this setting: 638 days
public bool HasWriteableEndpointFor(Address address)
        {
            var policy = WritableEndpointWithPolicyFor(address);
            return policy is EndpointManager.Pass;
        }
fixed
Joshua Benjamin
@annymsMthd
Ouch
Aaron Stannard
@Aaronontheweb
yeah, this has got to be at the root of it
there's a few more issues like this
like I said, dumb stuff
Joshua Benjamin
@annymsMthd
It happens.
Aaron Stannard
@Aaronontheweb
I'm going to harden some of the unit tests around this code today too
there's like, obviously bad shit that should not be in here
Joshua Benjamin
@annymsMthd
Nice. We should talk about akka android soon. We are going to be installing our new app in buses soon
Aaron Stannard
@Aaronontheweb
Guess I should talk to our lawyers about liability insurance while we're at it
just kidding :p
but yeah, I would like to see some official support for that
might not be a bad idea to move the ConfigurationManager stuff out of the main repo as part of 1.5
will help with Xamarin support as well as .NET Core
put that stuff into a separate library that's only referenced on full-blown .NET installations
can probably do that part without needing a second nuget package
just an extra binary that only gets added to full .NET profile installs
although, nuts - kind of do need that for the automatic config loading
meh, going to need to just do #IFDEF macros then I guess
we can pretend we're C++ programmers and be all smug about it
Arjen Smits
@Danthar
resistence is futile :P
Vagif Abilov
@object
@Horusiath this is my case too - JSON.NET wouldn't work with my example, this is why I am trying to configure Wire. But don't have that machine now with me, will investigate tomorrow.
Chris Martin
@trbngr
Where did ReplayMessagesSuccess go?
Chris Martin
@trbngr
I guess that was renamed to RecoverySuccess akkadotnet/akka.net@93af339
Aaron Stannard
@Aaronontheweb
@Silv3rcircl3 weird, having this spec fail locally now for some reason: EventFilterTestBase
a couple different implementations of it - never seen that before
ever had any problems with that?
Marc Piechura
@marcpiechura
@Aaronontheweb you mean the remote spec ?
Aaron Stannard
@Aaronontheweb
no
these are testkit specs
SS coming
blob
Marc Piechura
@marcpiechura
Tbh I don't know anything about it, I know there was the PR which added the overload for a custom ActorSystem but haven't run the tests locally for a long time
Aaron Stannard
@Aaronontheweb
I had it fail locally on ./build.cmd all which is bad
since that's build server stuff
Marc Piechura
@marcpiechura
Why do you think I know something about it ? :)
Aaron Stannard
@Aaronontheweb
shows you were one the last people to touch it :p
Marc Piechura
@marcpiechura
o_O
Aaron Stannard
@Aaronontheweb
blob
I think I've found the issue