Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 21:29
    Aaronontheweb commented #3863
  • 21:28
    Aaronontheweb synchronize #3863
  • 21:18
    Aaronontheweb synchronize #4000
  • 21:17
    Aaronontheweb commented #3964
  • 21:17
    Aaronontheweb commented #3964
  • 21:16
    Aaronontheweb synchronize #3964
  • 21:12
    Aaronontheweb commented #3964
  • 21:08
    Aaronontheweb synchronize #71
  • 21:04
    Aaronontheweb synchronize #3973
  • 21:00
    Aaronontheweb commented #71
  • 20:58

    Aaronontheweb on dev

    Akka.Persistence.TCK fix - chec… (compare)

  • 20:58
    Aaronontheweb closed #4002
  • 20:51
    Aaronontheweb synchronize #4002
  • 20:45
    Aaronontheweb commented #3811
  • 20:45
    Aaronontheweb commented #3811
  • 20:44
    Aaronontheweb labeled #4002
  • 20:43
    Aaronontheweb milestoned #4002
  • 20:43
    Aaronontheweb opened #4002
  • 20:37
    Aaronontheweb synchronize #71
  • 20:20
    Aaronontheweb synchronize #71
Aaron Stannard
@Aaronontheweb
there's a few more issues like this
like I said, dumb stuff
Joshua Benjamin
@annymsMthd
It happens.
Aaron Stannard
@Aaronontheweb
I'm going to harden some of the unit tests around this code today too
there's like, obviously bad shit that should not be in here
Joshua Benjamin
@annymsMthd
Nice. We should talk about akka android soon. We are going to be installing our new app in buses soon
Aaron Stannard
@Aaronontheweb
Guess I should talk to our lawyers about liability insurance while we're at it
just kidding :p
but yeah, I would like to see some official support for that
might not be a bad idea to move the ConfigurationManager stuff out of the main repo as part of 1.5
will help with Xamarin support as well as .NET Core
put that stuff into a separate library that's only referenced on full-blown .NET installations
can probably do that part without needing a second nuget package
just an extra binary that only gets added to full .NET profile installs
although, nuts - kind of do need that for the automatic config loading
meh, going to need to just do #IFDEF macros then I guess
we can pretend we're C++ programmers and be all smug about it
Arjen Smits
@Danthar
resistence is futile :P
Vagif Abilov
@object
@Horusiath this is my case too - JSON.NET wouldn't work with my example, this is why I am trying to configure Wire. But don't have that machine now with me, will investigate tomorrow.
Chris Martin
@trbngr
Where did ReplayMessagesSuccess go?
Chris Martin
@trbngr
I guess that was renamed to RecoverySuccess akkadotnet/akka.net@93af339
Aaron Stannard
@Aaronontheweb
@Silv3rcircl3 weird, having this spec fail locally now for some reason: EventFilterTestBase
a couple different implementations of it - never seen that before
ever had any problems with that?
Marc Piechura
@marcpiechura
@Aaronontheweb you mean the remote spec ?
Aaron Stannard
@Aaronontheweb
no
these are testkit specs
SS coming
blob
Marc Piechura
@marcpiechura
Tbh I don't know anything about it, I know there was the PR which added the overload for a custom ActorSystem but haven't run the tests locally for a long time
Aaron Stannard
@Aaronontheweb
I had it fail locally on ./build.cmd all which is bad
since that's build server stuff
Marc Piechura
@marcpiechura
Why do you think I know something about it ? :)
Aaron Stannard
@Aaronontheweb
shows you were one the last people to touch it :p
Marc Piechura
@marcpiechura
o_O
Aaron Stannard
@Aaronontheweb
blob
I think I've found the issue
 protected EventFilterTestBase(string config)
            : base(@"akka.loggers = [""" + typeof(ForwardAllEventsTestEventListener).AssemblyQualifiedName + @"""], " + (string.IsNullOrEmpty(config) ? "" : config))
        {
            //We send a ForwardAllEventsTo containing message to the TestEventListenerToForwarder logger (configured as a logger above).
            //It should respond with an "OK" message when it has received the message.
            var initLoggerMessage = new ForwardAllEventsTestEventListener.ForwardAllEventsTo(TestActor);
            // ReSharper disable once DoNotCallOverridableMethodsInConstructor
            SendRawLogEventMessage(initLoggerMessage);
            ExpectMsg("OK");
            //From now on we know that all messsages will be forwarded to TestActor
        }
assertion in the constructor of the test
Marc Piechura
@marcpiechura
Man I really can't remember that I ever touched this code, will check my PR's from this time
Aaron Stannard
@Aaronontheweb
smells to me like a race condition where something isn't started before this command fires
but not otherwise
works fine when I debug it
Marc Piechura
@marcpiechura
Sorry can't look into it at the moment, can you show me in which PR I changed that? I can't find it
Aaron Stannard
@Aaronontheweb
honestly I'm kind of puzzled by this
it's not even the EventFilter stuff that broke this
it's like the testkit initialization is fucked up
ah nope
sure enough
there is a bug here I'm pretty sure