These are chat archives for alariva/timegridDevelopment

13th
Dec 2016
Kashyap Sharma
@Kashyap12
Dec 13 2016 16:19
hi @alariva
Ariel Vallese
@alariva
Dec 13 2016 16:20
Hi @Kashyap12
Kashyap Sharma
@Kashyap12
Dec 13 2016 16:22
hey I was wondering if I can chip in for some pending issues or any other back logs
Ariel Vallese
@alariva
Dec 13 2016 16:24
Sure!
Kashyap Sharma
@Kashyap12
Dec 13 2016 16:25
can u please guide me on what to pick next?
Ariel Vallese
@alariva
Dec 13 2016 16:25
I'm not sure about issues difficulty right now
but lets see
I've got one
Ariel Vallese
@alariva
Dec 13 2016 16:32
timegridio/timegrid#150
Do you dare to research it yourself?
Kashyap Sharma
@Kashyap12
Dec 13 2016 16:33
sure
Ariel Vallese
@alariva
Dec 13 2016 16:34
You can find a slight mistake in this commit
Go ahead with research
if you find yourself stuck, here a hint: hint: https://github.com/timegridio/timegrid/pull/118#issuecomment-266789207
Ariel Vallese
@alariva
Dec 13 2016 16:45
I will leave now, keep me posted, you can update on github issue or here
good luck! :)
Kashyap Sharma
@Kashyap12
Dec 13 2016 16:47
sure
:)
Kashyap Sharma
@Kashyap12
Dec 13 2016 17:04
while running the phpunit
after making the change
i ran phpunit
from the container
Caused by
PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'listed' in 'field list'
Ariel Vallese
@alariva
Dec 13 2016 17:13
Ok
Similar to last time, you now run php artisan migrate
And composer install
Because there were changes to db schema
And packages upgrades
Go on :)
Kashyap Sharma
@Kashyap12
Dec 13 2016 17:16
OK
Ariel Vallese
@alariva
Dec 13 2016 17:19
And sorry, i forgot to mention
Also to your testing db
php artisan migrate --database=testing
Kashyap Sharma
@Kashyap12
Dec 13 2016 17:23
ok
Kashyap Sharma
@Kashyap12
Dec 13 2016 17:39
hey @alariva
on the login page
there is no message or option to suggest a new user to sign up
Ariel Vallese
@alariva
Dec 13 2016 17:40
How is it?
What do you mean?
Kashyap Sharma
@Kashyap12
Dec 13 2016 17:40
i mean
suppose a new user wants to sign up for the first time
Ariel Vallese
@alariva
Dec 13 2016 17:41
Ok
Suggestions?
Kashyap Sharma
@Kashyap12
Dec 13 2016 17:41
s1.png
he sses this page
there is no message like 'New user , please sign up'
Ariel Vallese
@alariva
Dec 13 2016 17:42
Ok
Suggestions are welcome, you may raise a github issue if theres none yet
Kashyap Sharma
@Kashyap12
Dec 13 2016 17:43
but it comes when u make a mistake while logging in , suppose i give a wrong user id or password , and press enter i get to see this page
s2.png
ok will create an issue
suggestion is that this message in the green tab should be a part of the page irrespective of whether a user is new or already existing
Ariel Vallese
@alariva
Dec 13 2016 17:48
Ok
Kashyap Sharma
@Kashyap12
Dec 13 2016 18:12
hi @alariva Submiited the PR
Ariel Vallese
@alariva
Dec 13 2016 18:15
Looking good!
Do ou understand why we arrived there and why we change that key?
Kashyap Sharma
@Kashyap12
Dec 13 2016 18:42
the email that a user get after an appointment , has certain framework , in which instead of name of the customer, date was printed before his name
key value pair was not correct for the name of the business
Ariel Vallese
@alariva
Dec 13 2016 18:43
Right
Thats it..
We will have to test it manually snce there are no tests cases for that
Kashyap Sharma
@Kashyap12
Dec 13 2016 18:43
ok,
so I ll book an appointment and check if I am getting the correct email
right?
Ariel Vallese
@alariva
Dec 13 2016 18:45
Yes... If you do it locally you will have to search for the email on logs file
Kashyap Sharma
@Kashyap12
Dec 13 2016 18:45
ok
Kashyap Sharma
@Kashyap12
Dec 13 2016 18:52
i booked an appointment
but i forgot how to check the logs
:/
Ariel Vallese
@alariva
Dec 13 2016 19:18
There is a file called laravel.log
Inside storage/logs
Else, go back in chat history 😁
Kashyap Sharma
@Kashyap12
Dec 13 2016 19:38
Business: Yogalution
Date: 2016-12-15
Time: Please arrive at 04:00 pm
Code: 9FA0
Service: Pranayam
customer notes for you: None
yeah
hot it
*got it
:)