These are chat archives for alariva/timegridDevelopment

14th
Dec 2016
Kashyap Sharma
@Kashyap12
Dec 14 2016 08:32
Hi @alariva
thanks for the merge
please let me know
would love to take up a new task,
Ariel Vallese
@alariva
Dec 14 2016 11:33
👌🏽
Making great progress!
Do you dare to test your fix in demo.timegrid.io?
Ive deployed updates
Kashyap Sharma
@Kashyap12
Dec 14 2016 11:40
will catch up with u in 3 to 4 hours, i am in office
Ariel Vallese
@alariva
Dec 14 2016 11:42
Sure! Let me know, have a nice day!
Kashyap Sharma
@Kashyap12
Dec 14 2016 16:29
hi @alariva
Ariel Vallese
@alariva
Dec 14 2016 16:33
hi!
Kashyap Sharma
@Kashyap12
Dec 14 2016 16:33
i ll start on testing my change in demo.timegrid.io
Ariel Vallese
@alariva
Dec 14 2016 16:34
good
remember that a reservation sends 2 emails... one for the client, one for the business
the affected email is the one sent to client
Kashyap Sharma
@Kashyap12
Dec 14 2016 16:35
ok
Kashyap Sharma
@Kashyap12
Dec 14 2016 16:41
s3.png
i am unable to pick a date
i tried to book an appointment for 2 diff business
but for either of them I was unable to pick a date
Ariel Vallese
@alariva
Dec 14 2016 16:42
did you publish any availability?
Kashyap Sharma
@Kashyap12
Dec 14 2016 16:42
no
i did not get u,
Ariel Vallese
@alariva
Dec 14 2016 16:42
you are owner of testing right?
Kashyap Sharma
@Kashyap12
Dec 14 2016 16:43
no i am not
Ariel Vallese
@alariva
Dec 14 2016 16:43
oh
ok
i will give you a place to book
Kashyap Sharma
@Kashyap12
Dec 14 2016 16:44
ok
book an skype for 21st
Kashyap Sharma
@Kashyap12
Dec 14 2016 16:45
ok
s4.png
Ariel Vallese
@alariva
Dec 14 2016 16:50
heyy!
looks like it's fixed! :)
well done!
Kashyap Sharma
@Kashyap12
Dec 14 2016 16:51
great
:)
(Y)
Ariel Vallese
@alariva
Dec 14 2016 16:51
i also got the msg
Kashyap Sharma
@Kashyap12
Dec 14 2016 16:51
cool
Ariel Vallese
@alariva
Dec 14 2016 16:52
Screenshot from 2016-12-14 13:51:33.png
Kashyap Sharma
@Kashyap12
Dec 14 2016 16:53

the last line :

customer note for you , the c of customer should be in caps, to make it consistent

i guess
Ariel Vallese
@alariva
Dec 14 2016 16:53
sure
do you dare to spot that in the code?
Kashyap Sharma
@Kashyap12
Dec 14 2016 16:54
sure
Kashyap Sharma
@Kashyap12
Dec 14 2016 17:03
i guess i spotted it in the code
/timegrid/resources/lang/en_US/email.php
/resources/lang/es_AR/emails.php
/resources/lang/en_US/emails.php
Ariel Vallese
@alariva
Dec 14 2016 17:04
exactly
Kashyap Sharma
@Kashyap12
Dec 14 2016 17:06
so can i make a change
Ariel Vallese
@alariva
Dec 14 2016 17:06
yes
Kashyap Sharma
@Kashyap12
Dec 14 2016 17:06
or should i create an issue first?
Ariel Vallese
@alariva
Dec 14 2016 17:07
Since we are talking this here, its a small change and we agreed, you can go directly
Kashyap Sharma
@Kashyap12
Dec 14 2016 17:07
sure
Ariel Vallese
@alariva
Dec 14 2016 17:07
otherwise id always suggest to open an issue first
you can open an issue if you want to practice anyway
your call :)
Kashyap Sharma
@Kashyap12
Dec 14 2016 17:10
i ll make a change directly, since it is trivial
Ariel Vallese
@alariva
Dec 14 2016 17:11
cool
Kashyap Sharma
@Kashyap12
Dec 14 2016 17:17
hi @alariva
done
pushed it
Ariel Vallese
@alariva
Dec 14 2016 17:17
lets see
PR is open?
Kashyap Sharma
@Kashyap12
Dec 14 2016 17:19
opened
Ariel Vallese
@alariva
Dec 14 2016 17:20
great!
Ariel Vallese
@alariva
Dec 14 2016 17:45
@Kashyap12 , for next item you'd like to take... maybe this one
timegridio/timegrid#58
Kashyap Sharma
@Kashyap12
Dec 14 2016 17:59
ok