Thanks a lot ;)
I don't have much experiance with DriverKit tbh, I know VoodooInput is in kernel space though
if you want to look driver development, look at Apple's IOKit development docs (though it's deprecated now and will be removed as Apple pushes people to use DriverKit)
Hello, I'm trying to fix the stylus issue in VoodooI2C. Could someone point me which portion of the code I can work on? I am hoping to contribute to VoodooI2C with my programming experience if no one can fix it. I found the multitouch gesture is not working on the touchscreen with the stylus pen on the secondary screen in my ASUS ZenBook Pro Duo 15 (has the main 4k and secondary touchscreens. Only the cursor and click functions work. (multi touch, scroll, and hold to drag/right click functions are not available.) The secondary touchscreen comes with stylus pen and support multi touch in Windows 10 and Ubuntu). I have tried disconnected the main touchscreen (unplug the eDP connector from MB), and had only the secondary screen in macOS 10.15.7. However, the issue remains the same. (only the cursor and click functions work.)
@astro-lee-k Take a look at:
https://github.com/VoodooI2C/VoodooI2CHID/blob/master/VoodooI2CHID/VoodooI2CStylusHIDEventDriver.cpp#L23
https://github.com/VoodooI2C/VoodooI2CHID/blob/master/VoodooI2CHID/VoodooI2CStylusHIDEventDriver.cpp#L23
though, I could be wrong
I found this could be where MultitouchHIDEvent checks for stylus
https://github.com/VoodooI2C/VoodooI2CHID/blob/master/VoodooI2CHID/VoodooI2CMultitouchHIDEventDriver.cpp#L187-L203
https://github.com/VoodooI2C/VoodooI2CHID/blob/master/VoodooI2CHID/VoodooI2CMultitouchHIDEventDriver.cpp#L187-L203
Also I'm sure what wrapper means, I keep seeing it in MultitouchHIDEvent and StylusHIDEvent
https://github.com/VoodooI2C/VoodooI2CHID/blob/master/VoodooI2CHID/VoodooI2CMultitouchHIDEventDriver.cpp#L685-L699
https://github.com/VoodooI2C/VoodooI2CHID/blob/master/VoodooI2CHID/VoodooI2CMultitouchHIDEventDriver.cpp#L685-L699
➜ VoodooI2C git:(master) ls
Dependencies Multitouch Support VoodooI2C Satellites
Documentation README.md VoodooI2C.xcworkspace
LICENSE.txt Utilities docs
MacKernelSDK VoodooI2C
/Users/username/Library/Developer/Xcode/DerivedData/VoodooI2C-brfmrnnidcznlxgxjrczhdfukmxm/Build/Intermediates.noindex/VoodooI2C.build/Release/VoodooI2C.build/Script-ACA4A00D21E25F0E00A91B61.sh: line 2: cpplint: command not found
Command PhaseScriptExecution failed with a nonzero exit code
Command PhaseScriptExecution failed with a nonzero exit code
you need to install cldoc from https://voodooi2c.github.io/ and other dependencies.
I'm trying to figure out how to install cldoc
don't need cpplint or cldoc for that
@zhen-zen I saw your commit in https://github.com/VoodooI2C/VoodooI2CHID/pull/36#issuecomment-643612068
Do you have any idea how to debug or fix this issue? Thank you.
Do you have any idea how to debug or fix this issue? Thank you.
Also, I put some IOLOG to check which lines were loaded; it looks like VoodooI2CTouchscreenHIDEventDriver.cpp was able to detect whether the touch is triggered by finger or the stylus pen. However, it's always been recognized as one point contact no matter how many fingers I used to touch that screen.
Actually it looks like VoodooI2CMultitouchInterface.cpp was not used even for the main touchscreen, which the multitouch gesture works. Does that mean it's actually the VoodooI2C.kext instead of the satellite driver VoodooI2CHID.kext handling multitouch service?
PS. Sorry for sending so many messages at the same time for this debug.
PS. Sorry for sending so many messages at the same time for this debug.
it should show which services are attached to the device which should help narrow down what's attaching and isn't attaching
it'll also show all the properties
I2C2:TPL0 is the stylus touchscreen
But I don't see the lines in VoodooI2CMultitouchInterface.cpp got executed based on IOLOG I put in that cpp file. I checking if it's actually the native engine handling the multi touch functions. (I was check the four finger swipe gesture on the main and secondary touch screens. i.e. I2C2:TPL0 and I2C3:TPL1)
Also tested the previous VoodooI2C versions and found none of them work for the secondary stylus touchscreen. I was guessing it was @zhen-zen's patch in the latest version (2.6.5) to make the single point work on this screen. I wonder if it's related to my DSDT/SSDT. Found a post from tonymac, which demos the similar issue and was able to fix it in the latest VoodooI2C version with multitouch on his stylus touchscreen. His laptop is HP and has a bit different DSDT for TPL device from mine.
Here is my DSDT, OC EFI, and other debug files if anyone could take a look.
https://drive.google.com/file/d/1fB-K3Dw2CISDaLb6qZmpKOe4xM14fe5_/view?usp=sharing
https://drive.google.com/file/d/1fB-K3Dw2CISDaLb6qZmpKOe4xM14fe5_/view?usp=sharing
Also, I wonder are the touchscreen and stylus handled differently in VoodooI2c? What would happen to touchscreens with stylus generally? Is it possible this could be a DSDT/SSDT thing on the GPIO? I currently do not have any SSDT path on I2C and GPIO but my trackpad, the main touchscreen and stylus on the secondary screen work. Wonder if that means I do/don't need GPIO SSDT patch for stylus touchscreen?
One thing I found interesting is the line in here:
https://github.com/VoodooI2C/VoodooI2C/blob/master/Multitouch%20Support/Native/VoodooI2CNativeEngine.cpp#L34
If I make it "event.transducers->getObject(i)" instead of "event.transducers->getObject(i+stylus_check)", the secondary touchscreen (with stylus function) would be completely usable.
https://github.com/VoodooI2C/VoodooI2C/blob/master/Multitouch%20Support/Native/VoodooI2CNativeEngine.cpp#L34
If I make it "event.transducers->getObject(i)" instead of "event.transducers->getObject(i+stylus_check)", the secondary touchscreen (with stylus function) would be completely usable.