These are chat archives for allegro/hermes

11th
Aug 2016
Samuel Beniamin
@samuel-beniamin
Aug 11 2016 11:04
Hi
I've a question regards the SelectiveSupervisorController it has no listener over the "onSubscriptionRemoved" event, this is preventing the consumer from being stopped when the subscription gets deleted
or this meant to be done in other place ?
Adam Dubiel
@adamdubiel
Aug 11 2016 11:29
let me take a look
it works :) but i need to see how
Samuel Beniamin
@samuel-beniamin
Aug 11 2016 11:30
Cool
Adam Dubiel
@adamdubiel
Aug 11 2016 11:34
okay, so SelectiveSupervisorController only reacts to changes in assignments. this is an entirely different branch. the real job tracking what subscriptions exist and if they are active/suspended is done in SelectiveWorkBalancer called via BalancingJob. There new, removed and suspended subscriptions are detected and proper assignments are made
so if you remove subscription, the work balancer picks up that change, removes assignment and thus effectively shuts down consumers for this subscription
Samuel Beniamin
@samuel-beniamin
Aug 11 2016 11:36
but what I'm experiencing is a little bit different as the consumer still a live in memory after deleting the subscription even after the balancing job kicks in
Adam Dubiel
@adamdubiel
Aug 11 2016 11:36
hmm this might mean there was some problem with picking up the change signal from Zookeeper
in long term we would like to get rid of zookeeper as kind of a "messenger"
do you have any connection lost logs etc?
Samuel Beniamin
@samuel-beniamin
Aug 11 2016 11:39
No, actually I was able to reproduce locally
maybe I have something misconfigured, let me double check
Adam Dubiel
@adamdubiel
Aug 11 2016 11:50
hmm i don't think its confguration issue
Samuel Beniamin
@samuel-beniamin
Aug 11 2016 13:03
here is the logs from my local test, please have a look, I left few comments on it https://gist.github.com/samuel-beniamin/12819bab1434084f5fd73239d027b38a
There is a new assignment created after the subscription is deleted ??
Does it meant to be like this and if so, why ?
Adam Dubiel
@adamdubiel
Aug 11 2016 13:05
hmmm i will take a look at it, create a test case and so on, it should shutdown subscription
Samuel Beniamin
@samuel-beniamin
Aug 11 2016 13:05
thanks
Adam Dubiel
@adamdubiel
Aug 11 2016 13:05
thanks for reporting this and giving the logs :) if it's a bug we will fix it in hotfix3
Samuel Beniamin
@samuel-beniamin
Aug 11 2016 13:07
I had one instance and the consumer had some undelivered messages when I tried to delete the subscription
Adam Dubiel
@adamdubiel
Aug 11 2016 13:11
okay, thanks for the details. could you create github issue so we can communicate on this issue and track progress?
Samuel Beniamin
@samuel-beniamin
Aug 11 2016 13:14
Sure, I'll
Samuel Beniamin
@samuel-beniamin
Aug 11 2016 13:37
here it is allegro/hermes#557
Adam Dubiel
@adamdubiel
Aug 11 2016 13:40
great, thanks! someone will take a look at it tomorrow
Samuel Beniamin
@samuel-beniamin
Aug 11 2016 13:45
Thanks a lot :)