These are chat archives for allegro/hermes

14th
Feb 2017
miguelpuyol
@miguelpuyol
Feb 14 2017 09:22

Hi, if I am not mistaken, Hermes Consumers in versions 0.8.x worked without using the frontend for publishing messages. Now when I publish directly to Kafka without the internal format, the consumer does not push messages to the subscriber.

Am I doing something wrong or this is the only supported way?

Adam Dubiel
@adamdubiel
Feb 14 2017 09:23
hmm i would need to check on this, you mean without adding JSON wrapping and magic _w?
miguelpuyol
@miguelpuyol
Feb 14 2017 09:23
exactly
Adam Dubiel
@adamdubiel
Feb 14 2017 09:24
let me check this, i don't remeber, but i dont think we been changing anything there
what version did you migrate to?
miguelpuyol
@miguelpuyol
Feb 14 2017 09:25
I am using the latest now and in my previous gig we were using 0.8.x
Adam Dubiel
@adamdubiel
Feb 14 2017 09:25
okay
hmm code is still in place, it should log.warn when reading message without wrapping
miguelpuyol
@miguelpuyol
Feb 14 2017 09:26
but should it send it?
Adam Dubiel
@adamdubiel
Feb 14 2017 09:26
yes, it just generates some random uuid to have hermes-id
miguelpuyol
@miguelpuyol
Feb 14 2017 09:27
mmm ok in our case it did not
I will double check
Adam Dubiel
@adamdubiel
Feb 14 2017 09:27
i can try it on docker, but later today
have some proposals to prepare atm
miguelpuyol
@miguelpuyol
Feb 14 2017 09:27
I will try again and will get back to you
Adam Dubiel
@adamdubiel
Feb 14 2017 09:28
okay, great. i will check on my own when i have an hour to spare
miguelpuyol
@miguelpuyol
Feb 14 2017 09:28
could you please tell me where the log.warn is produced?
miguelpuyol
@miguelpuyol
Feb 14 2017 09:30
thanks @adamdubiel !
Adam Dubiel
@adamdubiel
Feb 14 2017 09:30
hmm i see one dangerous thing there
the isWrapped() function checks for indexOf(_w) in string, so it might be your events have this sequence at some other place
and then it fails to do the unwrapping
miguelpuyol
@miguelpuyol
Feb 14 2017 09:32
mmm let me check again the logs
Adam Dubiel
@adamdubiel
Feb 14 2017 09:32
if you need this, we might think of a better way to search for _w, as it is always appended as first element in JSON in Frontend, so there should be no problem with limiting the socpe of search to first few bytes
miguelpuyol
@miguelpuyol
Feb 14 2017 09:33
that would be a good improvement
Adam Dubiel
@adamdubiel
Feb 14 2017 09:33
an issue please? :)
miguelpuyol
@miguelpuyol
Feb 14 2017 09:33
will do it asap
Adam Dubiel
@adamdubiel
Feb 14 2017 09:33
PR would be even greater
miguelpuyol
@miguelpuyol
Feb 14 2017 09:34
of course :)
Stevo Slavić
@sslavic
Feb 14 2017 09:46
@miguelpuyol it works with latest hermes as well
miguelpuyol
@miguelpuyol
Feb 14 2017 10:04
Thanks @sslavic
it was an error on our side
Adam Dubiel
@adamdubiel
Feb 14 2017 10:04
great :)
miguelpuyol
@miguelpuyol
Feb 14 2017 10:04
Just doubled checked it
thanks again
to both