These are chat archives for allegro/ralph

18th
Apr 2017
@mkurek @szok @ar4s
Roman Prykhodchenko
@romcheg
Apr 18 2017 11:32
@mkurek could you please take a quick look at allegro/ralph#3024
That should get rid of nasty discincts.
Mateusz Kurek
@mkurek
Apr 18 2017 11:41
@romcheg so ugly :) could you add some description in OperationChangeList. get_filters?
Roman Prykhodchenko
@romcheg
Apr 18 2017 11:42
something like """This is a dirty hack to avoid nasty problems"""? :)
Mateusz Kurek
@mkurek
Apr 18 2017 11:45
sth better :)
Roman Prykhodchenko
@romcheg
Apr 18 2017 11:45
done it wrong
xliiv
@xliiv
Apr 18 2017 11:52
@mkurek @romcheg
i need review (allegro/ralph#3002), will you make it today?
romcheg @romcheg is looking
Mateusz Kurek
@mkurek
Apr 18 2017 13:25
@romcheg are you sure that the following case will work: two Operations (A and B) and two base objects - X and Y, each of them attached to every Operation (this means 4 connections between Operation and BaseObject). What will happen when I will search by X and Y in operations filters - will distinct work then (in other words, how many Operations will I get on the list - 2 or 4)? :)
Roman Prykhodchenko
@romcheg
Apr 18 2017 13:26
easier to test
gimme a few minutes :)
Mateusz Kurek
@mkurek
Apr 18 2017 13:38
cool
Roman Prykhodchenko
@romcheg
Apr 18 2017 13:38
@mkurek did you mean this use case?
Mateusz Kurek
@mkurek
Apr 18 2017 13:38
yes (show the filters too) :)
Roman Prykhodchenko
@romcheg
Apr 18 2017 13:39
all empty
ah, I see
Mateusz Kurek
@mkurek
Apr 18 2017 13:39
filter by these two base objects (at the same time)
Roman Prykhodchenko
@romcheg
Apr 18 2017 13:39
I've added one of objects and everything is ok
and when I add two objects, everything fails
I mean, I've got 4 objects
and that's weird, because distinct should be present when filters are not empty
lemme fix that
Mateusz Kurek
@mkurek
Apr 18 2017 13:40
ok :)
Roman Prykhodchenko
@romcheg
Apr 18 2017 13:46
done
I've misread the sources a little