These are chat archives for allegro/ralph

24th
Jan 2019
look77
@look77
Jan 24 10:58
Helo, I have a question. Have you thought about:
  1. add field "phone number" in userlist/personal info
  2. add field IMEI 2 (the newer phone have 2 number of IMEI -dual sim)
Roman Prykhodchenko
@romcheg
Jan 24 11:05
add field "phone number" in userlist/personal info
wouldn't that be better to use add sim cards an assign them to users?
add field IMEI 2 (the newer phone have 2 number of IMEI -dual sim)
that makes sense, would you mind creating a pull request for that? I'm working on something else atm and this is really easy to do
look77
@look77
Jan 24 11:06
OK
Roman Prykhodchenko
@romcheg
Jan 24 11:52
@look77 you have 108 commits in your PR :)
did you base your changes on the master branch?
look77
@look77
Jan 24 11:55
probably no :)
Roman Prykhodchenko
@romcheg
Jan 24 11:56
the default branch is ng
look77
@look77
Jan 24 11:56
on the master branch I have inactive field "create pull request"
look77
@look77
Jan 24 12:02
what I'm doing wrong?
Roman Prykhodchenko
@romcheg
Jan 24 12:07
Could you please describe the steps you did to create the PR?
look77
@look77
Jan 24 12:11
When I click "New pull request" it moves me to the "<>Code" (compare changes)
when BASE and COMPARE field are NG then field "create pull request" is inactive and have comments "Choose different branches or forks above to discuss and review changes."
If I change Base or Compare to other i can click "Create pull request"
Roman Prykhodchenko
@romcheg
Jan 24 12:12
Do you click Create PR on your clone?
look77
@look77
Jan 24 12:13
where it was?
and how I can fix that?
Roman Prykhodchenko
@romcheg
Jan 24 12:16
Sorry for this question, I just would like to save your time -- are you a programmer?
look77
@look77
Jan 24 12:16
no
junior :)
Roman Prykhodchenko
@romcheg
Jan 24 12:17
sorry then, just create an issue with your request
adding fields to Ralph requires some programming skills
For some reason I assumed you are a programmer :)
look77
@look77
Jan 24 12:18
nice, I would like but I'm not yet :)