Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
✪ vi4m Marcin Kliks
@vi4m
ok, so docker should be enough for this
MarcinJanowski
@MarcinJanowski
oughhh... ok ;)
Michał Suszko
@msuszko
You lost JS on logon page
allegro/ralph@6896eb5 this commit removed {{ media.js }} from admin/templates/base.html
Michał Suszko
@msuszko
and now admin/templates/login.html renders with no jQuery
hm, actually {{ media.js }} was included in this commit, but logon page view doesn't set it
Michał Suszko
@msuszko
Hm, this JS code on logon page is useless, but because ralphs login.html extends base_site.html which extends base.html it includes ralphs base.html
and apparently it suppose to include djangos base.html instead
✪ vi4m Marcin Kliks
@vi4m
@damian1976 did you change (in old ralph) the way how ssh_linux plugin works?
without relying on snmp plugin?
because @MarcinJanowski has the same issue (snmp is not enabled probably, thus, ssh_linux won't fire at all)
MarcinJanowski
@MarcinJanowski
;)
✪ vi4m Marcin Kliks
@vi4m
so the thing is, we require snmp enabled, even when you just want to use ssh_linux ordinary plugin
but it's just our company policy, you can easily change this behavior
damian1976
@damian1976
@v4m No, I did it only locally. Anyway I commented out lines 247...263 @ ./src/ralph/scan/plugins/ssh_linux.py
Michał Suszko
@msuszko
How to set default value with new filters?
Mateusz Kurek
@mkurek
@msuszko what kind of filter? choice, date, text etc?
Michał Suszko
@msuszko
I used to have custom ChoiceFilter with default value
using overloaded value method
It seems to be possible to register custom filter before register_custom_filters but there must be a better way ;-)
Mateusz Kurek
@mkurek
@msuszko it's now raw django approach to admin filters - we're only overwriting default filters classes for some fields types. Your custom filter should work fine now (maybe you should inherit from other class than before). See https://docs.djangoproject.com/en/1.8/ref/contrib/admin/#django.contrib.admin.ModelAdmin.list_filter for details
✪ vi4m Marcin Kliks
@vi4m
we removed Ralph.* prefix from filters classes, you can subclass as documented above
Michał Suszko
@msuszko
When you register filter using FieldListFilter.register with take_priority=True I have no way to use subclassed filter in my app
Mateusz Kurek
@mkurek
yes, but you filter will be specified by class, not by field name, so our registration doesn't matter here
Michał Suszko
@msuszko
@mkurek I've used list_filter = [('field_name', MyCustomChoicesListFilter)] but had to fix AdminSearchFieldsMixin (#1823)
och
Mateusz Kurek
@mkurek
Wouldn't list_filter = [MyCustomChoicesListFilter] work?
Michał Suszko
@msuszko
@mkurek No: (admin.E114) The value of 'list_filter[0]' must not inherit from 'FieldListFilter'.
Mateusz Kurek
@mkurek
@msuszko you're right. I give :ok: to your PR
Michał Suszko
@msuszko
Guys, what is octodocker?
✪ vi4m Marcin Kliks
@vi4m
it allows you to actually run pull request changes before merging
testing on real instance
Michał Suszko
@msuszko
I'm using Gerrit, Jenkins and Docker for that. Is Octodocker released as OSS?
✪ vi4m Marcin Kliks
@vi4m
We will release it as OSS after some polishing
Michał Suszko
@msuszko
Data center asset has no relation to person. I'd like to bind administrators to assets. Are you considering adding something similar?
damian1976
@damian1976
This kind of relation was implemented in 2.x. I don't remember why but it seems it's been abandoned in 3.x. Guys should (or not) confirm that.
Mateusz Kurek
@mkurek
@msuszko this could be done right now but not directly - you could assign Service to Asset, Team to Service, and User to Team - is this flow ok for you?
✪ vi4m Marcin Kliks
@vi4m
i would rather stay with current model object, but change how it's displayed
previously we were showing "Support Group" inline, on ther Device view which was sufficient
Mateusz Kurek
@mkurek
@vi4m of course - my question was rather if @msuszko could assign some service to asset and them user to this team (which could be one-person-only in extreme case)
and i forgot about business owners and technical owners, which could be assigned to service - so there is no need to involve team here :)
damian1976
@damian1976
I think @msuszko rather meant "User Info" section in Asset add/edit form, not Support Group. Please correct me if I'm wrong.
Michał Suszko
@msuszko
@mkurek could you assign person to a support?
Mateusz Kurek
@mkurek
@msuszko afaik no - why you want to assign a person to a support?
Michał Suszko
@msuszko
@damian1976 Yes, I'm looking for assigning person to a data center asset as it is done with back office asset
damian1976
@damian1976
@mkurek, once you described me why in 3.x this info has been discarded. I don't remember the reasons why.
Michał Suszko
@msuszko
My security department is looking for a way to address vulnerability scan results, they need to identify person administering system with specific IP
Mateusz Kurek
@mkurek
@msuszko @damian1976 it useless (at least from our point of view) to assign single person to a single person - we rather prefer to assign person to service and then this service to asset; advantage of this flow is when the person is gone or the owner is changed - then you're just replacing it in one place, not in every asset; the only problem which I see here is when there is more than one person administering servers within one service - is it your case @msuszko (and @damian1976 too)?
damian1976
@damian1976
It happens quite often. But from my point of view - a single person is enough. In the worst case this person can contact another person or provide the info who is really responsible for given servers.
So the given flow should be ok for me.